* [PATCH] clocksource/drivers/loongson1: set variable ls1x_timer_lock storage-class-specifier to static
@ 2023-07-02 13:31 Tom Rix
2023-07-03 7:24 ` Keguang Zhang
0 siblings, 1 reply; 2+ messages in thread
From: Tom Rix @ 2023-07-02 13:31 UTC (permalink / raw)
To: keguang.zhang, daniel.lezcano, tglx; +Cc: linux-mips, linux-kernel, Tom Rix
smatch reports
drivers/clocksource/timer-loongson1-pwm.c:31:1: warning: symbol
'ls1x_timer_lock' was not declared. Should it be static?
This variable is only used in its defining file, so it should be static.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/clocksource/timer-loongson1-pwm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clocksource/timer-loongson1-pwm.c b/drivers/clocksource/timer-loongson1-pwm.c
index 6335fee03017..244d66835508 100644
--- a/drivers/clocksource/timer-loongson1-pwm.c
+++ b/drivers/clocksource/timer-loongson1-pwm.c
@@ -28,7 +28,7 @@
#define CNTR_WIDTH 24
-DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
+static DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
struct ls1x_clocksource {
void __iomem *reg_base;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] clocksource/drivers/loongson1: set variable ls1x_timer_lock storage-class-specifier to static
2023-07-02 13:31 [PATCH] clocksource/drivers/loongson1: set variable ls1x_timer_lock storage-class-specifier to static Tom Rix
@ 2023-07-03 7:24 ` Keguang Zhang
0 siblings, 0 replies; 2+ messages in thread
From: Keguang Zhang @ 2023-07-03 7:24 UTC (permalink / raw)
To: Tom Rix; +Cc: daniel.lezcano, tglx, linux-mips, linux-kernel
> smatch reports
> drivers/clocksource/timer-loongson1-pwm.c:31:1: warning: symbol
> 'ls1x_timer_lock' was not declared. Should it be static?
>
> This variable is only used in its defining file, so it should be static.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
Acked-by: Keguang Zhang <keguang.zhang@gmail.com>
> ---
> drivers/clocksource/timer-loongson1-pwm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/timer-loongson1-pwm.c b/drivers/clocksource/timer-loongson1-pwm.c
> index 6335fee03017..244d66835508 100644
> --- a/drivers/clocksource/timer-loongson1-pwm.c
> +++ b/drivers/clocksource/timer-loongson1-pwm.c
> @@ -28,7 +28,7 @@
>
> #define CNTR_WIDTH 24
>
> -DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
> +static DEFINE_RAW_SPINLOCK(ls1x_timer_lock);
>
> struct ls1x_clocksource {
> void __iomem *reg_base;
> --
> 2.27.0
>
--
Best regards,
Keguang Zhang
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-03 7:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-07-02 13:31 [PATCH] clocksource/drivers/loongson1: set variable ls1x_timer_lock storage-class-specifier to static Tom Rix
2023-07-03 7:24 ` Keguang Zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox