From: Rany Hany <rany_hany@riseup.net>
To: linux-mips@vger.kernel.org
Cc: Rany Hany <rany_hany@riseup.net>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Subject: [PATCH 1/3] MIPS: Stop secondary CPUs before platform restart/halt/poweroff
Date: Mon, 6 Apr 2026 02:59:53 +0300 [thread overview]
Message-ID: <20260405235956.79535-2-rany_hany@riseup.net> (raw)
In-Reply-To: <20260405235956.79535-1-rany_hany@riseup.net>
smp_send_stop() was placed after the platform restart, halt, and
power-off callbacks. These callbacks never return, so smp_send_stop()
was dead code and secondary CPUs were never stopped before the system
reset.
Move smp_send_stop() before the callbacks.
Signed-off-by: Rany Hany <rany_hany@riseup.net>
---
arch/mips/kernel/reset.c | 19 +++++++++++--------
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/arch/mips/kernel/reset.c b/arch/mips/kernel/reset.c
index e7ce07b3e..12c54d1b7 100644
--- a/arch/mips/kernel/reset.c
+++ b/arch/mips/kernel/reset.c
@@ -87,13 +87,14 @@ static void machine_hang(void)
void machine_restart(char *command)
{
- if (_machine_restart)
- _machine_restart(command);
-
#ifdef CONFIG_SMP
preempt_disable();
smp_send_stop();
#endif
+
+ if (_machine_restart)
+ _machine_restart(command);
+
do_kernel_restart(command);
mdelay(1000);
pr_emerg("Reboot failed -- System halted\n");
@@ -102,23 +103,25 @@ void machine_restart(char *command)
void machine_halt(void)
{
- if (_machine_halt)
- _machine_halt();
-
#ifdef CONFIG_SMP
preempt_disable();
smp_send_stop();
#endif
+
+ if (_machine_halt)
+ _machine_halt();
+
machine_hang();
}
void machine_power_off(void)
{
- do_kernel_power_off();
-
#ifdef CONFIG_SMP
preempt_disable();
smp_send_stop();
#endif
+
+ do_kernel_power_off();
+
machine_hang();
}
--
2.53.0
next prev parent reply other threads:[~2026-04-06 0:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-05 23:59 [PATCH 0/3] Fix MT7621 restart deadlock Rany Hany
2026-04-05 23:59 ` Rany Hany [this message]
2026-04-05 23:59 ` [PATCH 2/3] MIPS: SMP: Wait for secondary CPUs to stop in smp_send_stop() Rany Hany
2026-04-05 23:59 ` [PATCH 3/3] MIPS: SMP: Properly stop secondary CPUs for restart Rany Hany
2026-05-05 6:48 ` Thomas Bogendoerfer
-- strict thread matches above, loose matches on Subject: below --
2026-04-05 23:22 [PATCH 1/3] MIPS: Stop secondary CPUs before platform restart/halt/poweroff Rany Hany
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260405235956.79535-2-rany_hany@riseup.net \
--to=rany_hany@riseup.net \
--cc=linux-mips@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox