[PATCH v2] mips: econet: fix unmet dependencies for ECONET

[PATCH v2] mips: econet: fix unmet dependencies for ECONET

[Julian Braha]

ECONET selects EARLY_PRINTK_8250, SERIAL_OF_PLATFORM, and SERIAL_8250
without ensuring their dependencies, EARLY_PRINTK and TTY are met. This
causes unmet dependencies:

WARNING: unmet direct dependencies detected for SERIAL_8250
  Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && !S390
  Selected by [y]:
  - ECONET [=y]

WARNING: unmet direct dependencies detected for EARLY_PRINTK_8250
  Depends on [n]: EARLY_PRINTK [=n] && USE_GENERIC_EARLY_PRINTK_8250 [=y]
  Selected by [y]:
  - ECONET [=y]

WARNING: unmet direct dependencies detected for SERIAL_OF_PLATFORM
  Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && SERIAL_8250 [=y] && OF [=y]
  Selected by [y]:
  - ECONET [=y]

However, in the discussion of v1 of this patch, Arnd pointed out that these
selects don't belong here in the first place. [1]
Let's remove them to resolve the unmet dependencies.

These unmet dependencies were found by kconfirm, a static analysis tool for
Kconfig.

Fixes: 79ee1d20e37c ("mips: econet: Fix incorrect Kconfig dependencies")
Fixes: 35fb26f94dfa ("mips: Add EcoNet MIPS platform support")
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Julian Braha <julianbraha@gmail.com>
---
Link: https://lore.kernel.org/all/59c5582d-6fc1-48d0-a5df-b3b6f58aa227@app.fastmail.com/ [1]

Changes since v1: remove the selects, instead of selecting more
Link to v1: https://lore.kernel.org/all/20260802161555.491549-1-julianbraha@gmail.com/
---
 arch/mips/Kconfig | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index e2eb9627bd14..c3f69def2008 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -396,10 +396,7 @@ config ECONET
 	bool "EcoNet MIPS family"
 	select BOOT_RAW
 	select DEBUG_ZBOOT if DEBUG_KERNEL
-	select EARLY_PRINTK_8250
 	select ECONET_EN751221_TIMER
-	select SERIAL_8250
-	select SERIAL_OF_PLATFORM
 	select SYS_SUPPORTS_BIG_ENDIAN
 	select SYS_HAS_CPU_MIPS32_R1
 	select SYS_HAS_CPU_MIPS32_R2
-- 
2.55.0

Re: [PATCH v2] mips: econet: fix unmet dependencies for ECONET

[Caleb James DeLisle]

On 16/08/2026 01:51, Julian Braha wrote:
> ECONET selects EARLY_PRINTK_8250, SERIAL_OF_PLATFORM, and SERIAL_8250
> without ensuring their dependencies, EARLY_PRINTK and TTY are met. This
> causes unmet dependencies:
>
> WARNING: unmet direct dependencies detected for SERIAL_8250
>    Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && !S390
>    Selected by [y]:
>    - ECONET [=y]
>
> WARNING: unmet direct dependencies detected for EARLY_PRINTK_8250
>    Depends on [n]: EARLY_PRINTK [=n] && USE_GENERIC_EARLY_PRINTK_8250 [=y]
>    Selected by [y]:
>    - ECONET [=y]
>
> WARNING: unmet direct dependencies detected for SERIAL_OF_PLATFORM
>    Depends on [n]: TTY [=n] && HAS_IOMEM [=y] && SERIAL_8250 [=y] && OF [=y]
>    Selected by [y]:
>    - ECONET [=y]
>
> However, in the discussion of v1 of this patch, Arnd pointed out that these
> selects don't belong here in the first place. [1]
> Let's remove them to resolve the unmet dependencies.
>
> These unmet dependencies were found by kconfirm, a static analysis tool for
> Kconfig.
>
> Fixes: 79ee1d20e37c ("mips: econet: Fix incorrect Kconfig dependencies")
> Fixes: 35fb26f94dfa ("mips: Add EcoNet MIPS platform support")
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Julian Braha <julianbraha@gmail.com>


Tested-by: Caleb James DeLisle <cjd@cjdns.fr>


> ---
> Link: https://lore.kernel.org/all/59c5582d-6fc1-48d0-a5df-b3b6f58aa227@app.fastmail.com/ [1]
>
> Changes since v1: remove the selects, instead of selecting more
> Link to v1: https://lore.kernel.org/all/20260802161555.491549-1-julianbraha@gmail.com/
> ---
>   arch/mips/Kconfig | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index e2eb9627bd14..c3f69def2008 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -396,10 +396,7 @@ config ECONET
>   	bool "EcoNet MIPS family"
>   	select BOOT_RAW
>   	select DEBUG_ZBOOT if DEBUG_KERNEL
> -	select EARLY_PRINTK_8250
>   	select ECONET_EN751221_TIMER
> -	select SERIAL_8250
> -	select SERIAL_OF_PLATFORM
>   	select SYS_SUPPORTS_BIG_ENDIAN
>   	select SYS_HAS_CPU_MIPS32_R1
>   	select SYS_HAS_CPU_MIPS32_R2