From: "Mikael Nousiainen" <turja@mbnet.fi>
To: "Martin Michlmayr" <tbm@cyrius.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] SGI VINO driver 64-bit fix / V4L ioctl compatibility layer needs fixes
Date: Sat, 18 Mar 2006 10:58:12 +0200 (EET) [thread overview]
Message-ID: <2052.88.192.17.186.1142672292.squirrel@webmail.mbnet.fi> (raw)
In-Reply-To: <20060318015941.GY18750@deprecation.cyrius.com>
> * turja@mbnet.fi <turja@mbnet.fi> [2006-03-17 14:19]:
>> This patch should fix problems with VINO drivers when using a 64-bit
>> kernel.
>
> Did you test this?
To be honest, I didn't test this (as I didn't have 64-bit kernel available),
but the fix was quite trivial. Basically I only had to change one unsigned
long
back to u32 as the DMA addresses VINO uses are always 32-bit.
Nothing else should prevent the driver from working in a 64-bit environment.
>
> It looks exactly like the patch you gave me for testing a few days ago
> and that did not work...
Yup, it didn't work...
>
>> There are also other bugs which prevent V4L drivers from functioning
>> correctly when using 32-bit userland with a 64-bit kernel as the ioctl
>> compatibility layer (in drivers/media/video/compat_ioctl32.c) doesn't
>> seem
>> to handle VIDIOC_CROPCAP.
>
> ... or did I see this bug?
.... because the bug you saw was this. The compatibility layer
doesn't forward certain ioctls to the driver and only returns an error code.
Also please remember to download the newest version (0.7.1) of the
patched camsource from my web page when testing the driver.
The newest version has a couple of fixes which should allow
the application to work with the driver even if VIDIOC_CROPCAP fails.
But anyway the V4L ioctl compatibility layer needs to be fixed.
http://www.mbnet.fi/~turja/vino/
Mikael Nousiainen
WARNING: multiple messages have this Message-ID (diff)
From: "Mikael Nousiainen" <turja@mbnet.fi>
To: Martin Michlmayr <tbm@cyrius.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] SGI VINO driver 64-bit fix / V4L ioctl compatibility layer needs fixes
Date: Sat, 18 Mar 2006 10:58:12 +0200 (EET) [thread overview]
Message-ID: <2052.88.192.17.186.1142672292.squirrel@webmail.mbnet.fi> (raw)
Message-ID: <20060318085812.PybU9dh-MMTcKisF_9ECgeZgyv9A1bpKhKd3EMAnYd0@z> (raw)
In-Reply-To: <20060318015941.GY18750@deprecation.cyrius.com>
> * turja@mbnet.fi <turja@mbnet.fi> [2006-03-17 14:19]:
>> This patch should fix problems with VINO drivers when using a 64-bit
>> kernel.
>
> Did you test this?
To be honest, I didn't test this (as I didn't have 64-bit kernel available),
but the fix was quite trivial. Basically I only had to change one unsigned
long
back to u32 as the DMA addresses VINO uses are always 32-bit.
Nothing else should prevent the driver from working in a 64-bit environment.
>
> It looks exactly like the patch you gave me for testing a few days ago
> and that did not work...
Yup, it didn't work...
>
>> There are also other bugs which prevent V4L drivers from functioning
>> correctly when using 32-bit userland with a 64-bit kernel as the ioctl
>> compatibility layer (in drivers/media/video/compat_ioctl32.c) doesn't
>> seem
>> to handle VIDIOC_CROPCAP.
>
> ... or did I see this bug?
.... because the bug you saw was this. The compatibility layer
doesn't forward certain ioctls to the driver and only returns an error code.
Also please remember to download the newest version (0.7.1) of the
patched camsource from my web page when testing the driver.
The newest version has a couple of fixes which should allow
the application to work with the driver even if VIDIOC_CROPCAP fails.
But anyway the V4L ioctl compatibility layer needs to be fixed.
http://www.mbnet.fi/~turja/vino/
Mikael Nousiainen
next prev parent reply other threads:[~2006-03-18 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-17 12:19 [PATCH] SGI VINO driver 64-bit fix / V4L ioctl compatibility layer needs fixes turja
2006-03-18 1:59 ` Martin Michlmayr
2006-03-18 8:58 ` Mikael Nousiainen [this message]
2006-03-18 8:58 ` Mikael Nousiainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2052.88.192.17.186.1142672292.squirrel@webmail.mbnet.fi \
--to=turja@mbnet.fi \
--cc=linux-mips@linux-mips.org \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox