From: Maarten ter Huurne <maarten@treewalker.org>
To: Florian Fainelli <florian@openwrt.org>
Cc: linux-mips@linux-mips.org,
Antony Pavlov <antonynpavlov@gmail.com>,
Ralf Baechle <ralf@linux-mips.org>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [RFC 11/13] MIPS: JZ4750D: Add Kbuild files
Date: Wed, 24 Oct 2012 20:15:37 +0200 [thread overview]
Message-ID: <2898753.opXRKuz76b@hyperion> (raw)
In-Reply-To: <6315819.WnqMkxcSqV@bender>
On Wednesday 24 October 2012 19:43:25 Florian Fainelli wrote:
> On Wednesday 24 October 2012 18:16:35 Maarten ter Huurne wrote:
> > On Tuesday 23 October 2012 21:43:59 Antony Pavlov wrote:
> > > Add the Kbuild files for the JZ4750D architecture and adds JZ4750D
> > > support to the MIPS Kbuild files.
> >
> > [snip]
> >
> > > diff --git a/arch/mips/jz4750d/Platform b/arch/mips/jz4750d/Platform
> > > new file mode 100644
> > > index 0000000..2e4e050
> > > --- /dev/null
> > > +++ b/arch/mips/jz4750d/Platform
> > > @@ -0,0 +1,3 @@
> > > +platform-$(CONFIG_MACH_JZ4750D) += jz4750d/
> > > +cflags-$(CONFIG_MACH_JZ4750D) +=
> > > -I$(srctree)/arch/mips/include/asm/mach-jz4750d
> > > +load-$(CONFIG_MACH_JZ4750D) += 0xffffffff80010000
> >
> > What is the purpose of padding the load address to 64 bits?
> >
> > The reason I'm asking is that we encountered a bug with that when
> > creating a u-boot image on a 32-bit host machine: the mkimage tool will
> > only parse the first 8 hex digits and then inserts the wrong load
> > address into the uImage.
>
> AFAIR u-boot's mkimage expects 32-bits quantities as a load address, so I
> would not be surprised that using this line as-is as an input parameter
> to mkimage does not give yout the expected result.
The actual uImage format supports only 32-bit addresses, but mkimage is
inconsistent in its handling of 64-bit addresses: if the tool is compiled
for x86_64 it parses all 16 hex digits and uses the lower 32 bits, but if it
is compiled for x86 it parses only the first 8 hex digits and the resulting
image won't boot.
There is no "uImage" target for MIPS in the mainline kernel; we added our
own and it indeed passes $(VMLINUX_LOAD_ADDRESS) to mkimage as-is on the
command line. Since Ralf indicated that there are good reasons for sign
extending the address, I think I'll have to change how it is passed to
mkimage.
Bye,
Maarten
next prev parent reply other threads:[~2012-10-24 18:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 17:43 [RFC 00/13] MIPS: JZ4750D: Add base support for Ingenic JZ4750D SOC Antony Pavlov
2012-10-23 17:43 ` [RFC 01/13] MIPS: JZ4750D: Add base support for Ingenic JZ4750D System-on-a-Chip Antony Pavlov
2012-10-23 17:43 ` [RFC 02/13] MIPS: JZ4750D: Add clock API support Antony Pavlov
2012-10-23 17:43 ` [RFC 03/13] MIPS: JZ4750D: Add IRQ handler code Antony Pavlov
2012-10-23 17:43 ` [RFC 04/13] MIPS: JZ4750D: Add timer support Antony Pavlov
2012-10-23 17:43 ` [RFC 05/13] MIPS: JZ4750D: Add clocksource/clockevent support Antony Pavlov
2012-10-23 17:43 ` [RFC 06/13] MIPS: JZ4750D: Add system reset support Antony Pavlov
2012-10-23 17:43 ` [RFC 07/13] MIPS: JZ4750D: Add setup code Antony Pavlov
2012-10-23 17:43 ` [RFC 08/13] MIPS: JZ4750D: Add serial support Antony Pavlov
2012-10-23 17:43 ` [RFC 09/13] MIPS: JZ4750D: Add prom support Antony Pavlov
2012-10-23 17:43 ` [RFC 10/13] MIPS: JZ4750D: Add platform UART devices Antony Pavlov
2012-10-23 17:43 ` [RFC 11/13] MIPS: JZ4750D: Add Kbuild files Antony Pavlov
2012-10-24 16:16 ` Maarten ter Huurne
2012-10-24 16:56 ` Ralf Baechle
2012-10-24 17:18 ` Antony Pavlov
2012-10-24 17:43 ` Florian Fainelli
2012-10-24 18:15 ` Maarten ter Huurne [this message]
2012-10-23 17:44 ` [RFC 12/13] MIPS: JZ4750D: Add rzx50 board support Antony Pavlov
2012-10-23 17:44 ` [RFC 13/13] MIPS: rzx50: Add defconfig file Antony Pavlov
2012-10-23 18:15 ` [RFC 00/13] MIPS: JZ4750D: Add base support for Ingenic JZ4750D SOC Lars-Peter Clausen
2012-10-23 19:57 ` Steven J. Hill
2012-10-24 8:25 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2898753.opXRKuz76b@hyperion \
--to=maarten@treewalker.org \
--cc=antonynpavlov@gmail.com \
--cc=florian@openwrt.org \
--cc=lars@metafoo.de \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox