Re: [PATCH v2 1/4] dt-bindings: clock: mediatek,mtmips-sysc: Adapt compatible for MT7688 boards

[Krzysztof Kozlowski <krzk@kernel.org>]

On 17/06/2025 17:29, Ezra Buehler wrote:
> On Tue, Jun 17, 2025 at 2:05 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 17/06/2025 13:40, Krzysztof Kozlowski wrote:
>>> On 17/06/2025 12:30, Ezra Buehler wrote:
>>>> From: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
>>>>
>>>> As the MT7628 and MT7688 are identical in most respects, mt7628a.dtsi is
>>>> used for both SoCs. To prevent "Kernel panic - not syncing: unable to
>>>> get CPU clock, err=-2" and allow an MT7688-based board to boot, the
>>>> following must be allowed:
>>>>
>>>>     compatible = "ralink,mt7628-sysc", "ralink,mt7688-sysc", "syscon";
>>>>
>>>> Signed-off-by: Ezra Buehler <ezra.buehler@husqvarnagroup.com>
>>>> ---
>>>>  .../bindings/clock/mediatek,mtmips-sysc.yaml  | 29 +++++++++++--------
>>>>  1 file changed, 17 insertions(+), 12 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml b/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
>>>> index 83c1803ffd16..550807301fc5 100644
>>>> --- a/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
>>>> +++ b/Documentation/devicetree/bindings/clock/mediatek,mtmips-sysc.yaml
>>>> @@ -26,18 +26,23 @@ description: |
>>>>
>>>>  properties:
>>>>    compatible:
>>>> -    items:
>>>> -      - enum:
>>>> -          - ralink,mt7620-sysc
>>>> -          - ralink,mt7628-sysc
>>>> -          - ralink,mt7688-sysc
>>>> -          - ralink,rt2880-sysc
>>>> -          - ralink,rt3050-sysc
>>>> -          - ralink,rt3052-sysc
>>>> -          - ralink,rt3352-sysc
>>>> -          - ralink,rt3883-sysc
>>>> -          - ralink,rt5350-sysc
>>>> -      - const: syscon
>>>> +    oneOf:
>>>> +      - items:
>>>> +          - enum:
>>>> +              - ralink,mt7620-sysc
>>>> +              - ralink,mt7628-sysc
>>>
>>> It's here already, so this must be dropped.
>>
>>
>> I meant mt7628 is here already and you are adding it again further, so
>> it is now in two places.
> 
> My idea was to support these variants, as they are all valid:
> 
> compatible = "ralink,mt7628-sysc", "syscon";
> compatible = "ralink,mt7688-sysc", "syscon";
> compatible = "ralink,mt7628-sysc", "ralink,mt7688-sysc", "syscon";

How is it valid? Provide arguments because this defies logic. Device is
and is not compatible with 7688? The same time? How, really how?


Best regards,
Krzysztof