From: Jun Sun <jsun@mvista.com>
To: "Maciej W. Rozycki" <macro@ds2.pg.gda.pl>
Cc: linux-mips@oss.sgi.com, Ralf Baechle <ralf@uni-koblenz.de>
Subject: Re: [PATCH] Let us die more gracefully
Date: Mon, 22 Jul 2002 09:40:18 -0700 [thread overview]
Message-ID: <3D3C3572.40807@mvista.com> (raw)
In-Reply-To: Pine.GSO.3.96.1020722154730.2373E-100000@delta.ds2.pg.gda.pl
[-- Attachment #1: Type: text/plain, Size: 308 bytes --]
Maciej W. Rozycki wrote:
> On Fri, 19 Jul 2002, Jun Sun wrote:
>
>
>>This patch dumps the offending code context rather than dumping the context of
>>do_ri() function call itself.
>
>
> The message is misleading -- the reason may be any illegal opcode.
>
That is true. Here is the revised one.
Jun
[-- Attachment #2: 020719.b.graceful-death-in-do_ri.patch --]
[-- Type: text/plain, Size: 404 bytes --]
diff -Nru linux/arch/mips/kernel/traps.c.orig linux/arch/mips/kernel/traps.c
--- linux/arch/mips/kernel/traps.c.orig Thu Jul 18 15:39:50 2002
+++ linux/arch/mips/kernel/traps.c Thu Jul 18 16:49:32 2002
@@ -614,8 +614,7 @@
*/
asmlinkage void do_ri(struct pt_regs *regs)
{
- if (!user_mode(regs))
- BUG();
+ die_if_kernel("Reserved instruction in kernel code", regs);
#ifndef CONFIG_CPU_HAS_LLSC
prev parent reply other threads:[~2002-07-22 16:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-19 21:18 [PATCH] Let us die more gracefully Jun Sun
2002-07-22 13:48 ` Maciej W. Rozycki
2002-07-22 16:40 ` Jun Sun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D3C3572.40807@mvista.com \
--to=jsun@mvista.com \
--cc=linux-mips@oss.sgi.com \
--cc=macro@ds2.pg.gda.pl \
--cc=ralf@uni-koblenz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox