[PATCH] Let us die more gracefully

[PATCH] Let us die more gracefully

[Jun Sun]

[-- Attachment #1: Type: text/plain, Size: 182 bytes --]


This patch dumps the offending code context rather than dumping the context of 
do_ri() function call itself.

Apply to both branches.  (Same is true with the previous patch)

Jun


[-- Attachment #2: 020719.b.graceful-death-in-do_ri.patch --]
[-- Type: text/plain, Size: 403 bytes --]

diff -Nru linux/arch/mips/kernel/traps.c.orig linux/arch/mips/kernel/traps.c
--- linux/arch/mips/kernel/traps.c.orig	Thu Jul 18 15:39:50 2002
+++ linux/arch/mips/kernel/traps.c	Thu Jul 18 16:49:32 2002
@@ -614,8 +614,7 @@
  */
 asmlinkage void do_ri(struct pt_regs *regs)
 {
-	if (!user_mode(regs))
-		BUG();
+	die_if_kernel("no ll/sc emulation for kernel code", regs);
 
 #ifndef CONFIG_CPU_HAS_LLSC
 

Re: [PATCH] Let us die more gracefully

[Maciej W. Rozycki]

On Fri, 19 Jul 2002, Jun Sun wrote:

> This patch dumps the offending code context rather than dumping the context of 
> do_ri() function call itself.

 The message is misleading -- the reason may be any illegal opcode.

-- 
+  Maciej W. Rozycki, Technical University of Gdansk, Poland   +
+--------------------------------------------------------------+
+        e-mail: macro@ds2.pg.gda.pl, PGP key available        +

Re: [PATCH] Let us die more gracefully

[Jun Sun]

[-- Attachment #1: Type: text/plain, Size: 308 bytes --]

Maciej W. Rozycki wrote:
> On Fri, 19 Jul 2002, Jun Sun wrote:
> 
> 
>>This patch dumps the offending code context rather than dumping the context of 
>>do_ri() function call itself.
> 
> 
>  The message is misleading -- the reason may be any illegal opcode.
> 

That is true.  Here is the revised one.

Jun

[-- Attachment #2: 020719.b.graceful-death-in-do_ri.patch --]
[-- Type: text/plain, Size: 404 bytes --]

diff -Nru linux/arch/mips/kernel/traps.c.orig linux/arch/mips/kernel/traps.c
--- linux/arch/mips/kernel/traps.c.orig	Thu Jul 18 15:39:50 2002
+++ linux/arch/mips/kernel/traps.c	Thu Jul 18 16:49:32 2002
@@ -614,8 +614,7 @@
  */
 asmlinkage void do_ri(struct pt_regs *regs)
 {
-	if (!user_mode(regs))
-		BUG();
+	die_if_kernel("Reserved instruction in kernel code", regs);
 
 #ifndef CONFIG_CPU_HAS_LLSC