Linux MIPS Architecture development
 help / color / mirror / Atom feed
* scatterlist.h
@ 2002-10-01  8:48 Mike Nugent
  2002-10-01  8:48 ` scatterlist.h Mike Nugent
  2002-10-01  9:05 ` scatterlist.h Carsten Langgaard
  0 siblings, 2 replies; 3+ messages in thread
From: Mike Nugent @ 2002-10-01  8:48 UTC (permalink / raw)
  To: linux-mips


Next problem  ( I know you all love my by now :)

in drivers/scsi/scsi_merge.c

scsi_merge.c:939: structure has no member named `page'

line 939: sgpnt[count - 1].page = NULL;

(struct scatterlist *sgpnt;  included from scsi.h, which includes
asm/scatterlist.h)


struct scatterlist {
    char *  address;    /* Location data is to be transferred to */
    unsigned int length;

    __u32 dvma_address;
};

Yes!  It's right!  No member page!

From 2.4.16:

struct scatterlist {
	char * address;		/* Location data is to be transferred to */
	struct page * page;	/* Location for highmem page, if any */
	unsigned int length;
	__u32 dvma_address;
};

I suggest we put that variable back into the structure.

There's more to come, but it's almost 2 am and it's bedtime.  I'll send
the next one out tomorrow if no one writes me back to tell me I'm
nuts/not using the right code/can't reproduce the error/etc.


-- 
Mike Nugent
Programmer/Author
mike@illuminatus.org
"I believe the use of noise to make music will increase until we reach a
music produced through the aid of electrical instruments which will make
available for musical purposes any and all sounds that can be heard."
 -- composer John Cage, 1937

^ permalink raw reply	[flat|nested] 3+ messages in thread

* scatterlist.h
  2002-10-01  8:48 scatterlist.h Mike Nugent
@ 2002-10-01  8:48 ` Mike Nugent
  2002-10-01  9:05 ` scatterlist.h Carsten Langgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Mike Nugent @ 2002-10-01  8:48 UTC (permalink / raw)
  To: linux-mips


Next problem  ( I know you all love my by now :)

in drivers/scsi/scsi_merge.c

scsi_merge.c:939: structure has no member named `page'

line 939: sgpnt[count - 1].page = NULL;

(struct scatterlist *sgpnt;  included from scsi.h, which includes
asm/scatterlist.h)


struct scatterlist {
    char *  address;    /* Location data is to be transferred to */
    unsigned int length;

    __u32 dvma_address;
};

Yes!  It's right!  No member page!

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: scatterlist.h
  2002-10-01  8:48 scatterlist.h Mike Nugent
  2002-10-01  8:48 ` scatterlist.h Mike Nugent
@ 2002-10-01  9:05 ` Carsten Langgaard
  1 sibling, 0 replies; 3+ messages in thread
From: Carsten Langgaard @ 2002-10-01  9:05 UTC (permalink / raw)
  To: Mike Nugent; +Cc: linux-mips

Try to check out the latest sources, I believe this has been fixed already.

/Carsten




Mike Nugent wrote:

> Next problem  ( I know you all love my by now :)
>
> in drivers/scsi/scsi_merge.c
>
> scsi_merge.c:939: structure has no member named `page'
>
> line 939: sgpnt[count - 1].page = NULL;
>
> (struct scatterlist *sgpnt;  included from scsi.h, which includes
> asm/scatterlist.h)
>
> struct scatterlist {
>     char *  address;    /* Location data is to be transferred to */
>     unsigned int length;
>
>     __u32 dvma_address;
> };
>
> Yes!  It's right!  No member page!
>
> >From 2.4.16:
>
> struct scatterlist {
>         char * address;         /* Location data is to be transferred to */
>         struct page * page;     /* Location for highmem page, if any */
>         unsigned int length;
>         __u32 dvma_address;
> };
>
> I suggest we put that variable back into the structure.
>
> There's more to come, but it's almost 2 am and it's bedtime.  I'll send
> the next one out tomorrow if no one writes me back to tell me I'm
> nuts/not using the right code/can't reproduce the error/etc.
>
> --
> Mike Nugent
> Programmer/Author
> mike@illuminatus.org
> "I believe the use of noise to make music will increase until we reach a
> music produced through the aid of electrical instruments which will make
> available for musical purposes any and all sounds that can be heard."
>  -- composer John Cage, 1937

--
_    _ ____  ___   Carsten Langgaard   Mailto:carstenl@mips.com
|\  /|||___)(___   MIPS Denmark        Direct: +45 4486 5527
| \/ |||    ____)  Lautrupvang 4B      Switch: +45 4486 5555
  TECHNOLOGIES     2750 Ballerup       Fax...: +45 4486 5556
                   Denmark             http://www.mips.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2002-10-01  9:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-10-01  8:48 scatterlist.h Mike Nugent
2002-10-01  8:48 ` scatterlist.h Mike Nugent
2002-10-01  9:05 ` scatterlist.h Carsten Langgaard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox