From: Pete Popov <ppopov@embeddedalley.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
"linux-mips@linux-mips.org" <linux-mips@linux-mips.org>
Subject: Re: PATCH
Date: Sun, 10 Oct 2004 17:47:20 -0700 [thread overview]
Message-ID: <4169D818.5020802@embeddedalley.com> (raw)
In-Reply-To: <Pine.LNX.4.58L.0410110126120.4217@blysk.ds.pg.gda.pl>
Maciej W. Rozycki wrote:
> On Mon, 10 Oct 2004, Pete Popov wrote:
>
>
>>diff -u -r1.13 addrspace.h
>>--- include/asm-mips/addrspace.h 30 Nov 2003 01:52:25 -0000 1.13
>>+++ include/asm-mips/addrspace.h 19 Sep 2004 22:51:28 -0000
>>@@ -80,7 +80,11 @@
>> #define XKSSEG 0x4000000000000000
>> #define XKPHYS 0x8000000000000000
>> #define XKSEG 0xc000000000000000
>>+#if defined(CONFIG_64BIT_PHYS_ADDR) && defined(CONFIG_CPU_MIPS32)
>>+#define CKSEG0 0x80000000
>>+#else
>> #define CKSEG0 0xffffffff80000000
>>+#endif
>> #define CKSEG1 0xffffffffa0000000
>> #define CKSSEG 0xffffffffc0000000
>> #define CKSEG3 0xffffffffe0000000
>
>
> This looks suspicious, please explain.
Clearly a buglet, carried over from 2.4. That section of the code
wouldn't even be compiled, since CONFIG_MIPS64 is not defined. I'll
remove that and send a new patch. Anything else you see that's
suspicious :)?
Pete
next prev parent reply other threads:[~2004-10-11 0:47 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-11 0:01 PATCH Pete Popov
2004-10-11 0:32 ` PATCH Maciej W. Rozycki
2004-10-11 0:47 ` Pete Popov [this message]
2004-10-11 7:55 ` PATCH Pete Popov
2004-10-11 10:32 ` PATCH Christoph Hellwig
2004-10-11 17:07 ` PATCH Pete Popov
2004-10-11 13:53 ` PATCH Atsushi Nemoto
2004-10-11 16:33 ` PATCH Pete Popov
2004-10-11 18:04 ` PATCH Pete Popov
-- strict thread matches above, loose matches on Subject: below --
2004-10-10 23:43 PATCH Pete Popov
2004-10-10 17:17 PATCH Pete Popov
2004-10-10 18:01 ` PATCH Geert Uytterhoeven
2004-10-10 19:11 ` PATCH Maciej W. Rozycki
2004-10-10 22:50 ` PATCH Pete Popov
2004-10-11 0:25 ` PATCH Maciej W. Rozycki
2004-10-11 0:39 ` PATCH Pete Popov
2004-10-10 19:33 ` PATCH Matt Porter
2004-10-10 22:52 ` PATCH Pete Popov
2004-10-10 23:41 ` PATCH Pete Popov
2004-10-10 7:17 PATCH Pete Popov
2004-10-10 5:31 PATCH Pete Popov
2002-12-14 4:52 PATCH Pete Popov
2002-12-17 22:29 ` PATCH Greg Lindahl
2002-12-17 22:40 ` PATCH Pete Popov
2002-12-17 23:24 ` PATCH Alan Cox
2002-12-17 22:51 ` PATCH Pete Popov
2002-12-17 22:59 ` PATCH Greg Lindahl
2002-12-20 20:43 ` PATCH James Simmons
2002-12-20 20:59 ` PATCH Pete Popov
2002-12-21 20:39 ` PATCH James Simmons
2002-12-14 4:50 PATCH Pete Popov
2002-07-15 22:29 PATCH Pete Popov
2002-07-16 15:07 ` PATCH Ralf Baechle
2002-07-16 15:15 ` PATCH Pete Popov
2002-07-16 17:43 ` PATCH Joe George
2002-07-16 18:00 ` PATCH Pete Popov
2002-07-17 0:29 ` PATCH Vivien Chappelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4169D818.5020802@embeddedalley.com \
--to=ppopov@embeddedalley.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox