From: Pete Popov <ppopov@embeddedalley.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: macro@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: PATCH
Date: Mon, 11 Oct 2004 09:33:35 -0700 [thread overview]
Message-ID: <416AB5DF.70209@embeddedalley.com> (raw)
In-Reply-To: <20041011.225341.59463723.anemo@mba.ocn.ne.jp>
Atsushi Nemoto wrote:
>>>>>>On Sun, 10 Oct 2004 17:47:20 -0700, Pete Popov <ppopov@embeddedalley.com> said:
>
>
> ppopov> Clearly a buglet, carried over from 2.4. That section of the
> ppopov> code wouldn't even be compiled, since CONFIG_MIPS64 is not
> ppopov> defined. I'll remove that and send a new patch. Anything else
> ppopov> you see that's suspicious :)?
>
> Hi. I wonder why following change is needed.
>
>
>>--- include/asm-mips/page.h 20 Aug 2004 12:02:18 -0000 1.44
>>+++ include/asm-mips/page.h 19 Sep 2004 22:51:29 -0000
>>@@ -32,7 +32,7 @@
>> #ifdef CONFIG_PAGE_SIZE_64KB
>> #define PAGE_SHIFT 16
>> #endif
>>-#define PAGE_SIZE (1UL << PAGE_SHIFT)
>>+#define PAGE_SIZE (1L << PAGE_SHIFT)
>> #define PAGE_MASK (~(PAGE_SIZE-1))
>>
>> #ifdef __KERNEL__
It was related to some compiler problem I mentioned to Ralf sometime
ago. Perhaps it's not needed anymore, I'll take a look.
Pete
next prev parent reply other threads:[~2004-10-11 16:33 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-11 0:01 PATCH Pete Popov
2004-10-11 0:32 ` PATCH Maciej W. Rozycki
2004-10-11 0:47 ` PATCH Pete Popov
2004-10-11 7:55 ` PATCH Pete Popov
2004-10-11 10:32 ` PATCH Christoph Hellwig
2004-10-11 17:07 ` PATCH Pete Popov
2004-10-11 13:53 ` PATCH Atsushi Nemoto
2004-10-11 16:33 ` Pete Popov [this message]
2004-10-11 18:04 ` PATCH Pete Popov
-- strict thread matches above, loose matches on Subject: below --
2004-10-10 23:43 PATCH Pete Popov
2004-10-10 17:17 PATCH Pete Popov
2004-10-10 18:01 ` PATCH Geert Uytterhoeven
2004-10-10 19:11 ` PATCH Maciej W. Rozycki
2004-10-10 22:50 ` PATCH Pete Popov
2004-10-11 0:25 ` PATCH Maciej W. Rozycki
2004-10-11 0:39 ` PATCH Pete Popov
2004-10-10 19:33 ` PATCH Matt Porter
2004-10-10 22:52 ` PATCH Pete Popov
2004-10-10 23:41 ` PATCH Pete Popov
2004-10-10 7:17 PATCH Pete Popov
2004-10-10 5:31 PATCH Pete Popov
2002-12-14 4:52 PATCH Pete Popov
2002-12-17 22:29 ` PATCH Greg Lindahl
2002-12-17 22:40 ` PATCH Pete Popov
2002-12-17 23:24 ` PATCH Alan Cox
2002-12-17 22:51 ` PATCH Pete Popov
2002-12-17 22:59 ` PATCH Greg Lindahl
2002-12-20 20:43 ` PATCH James Simmons
2002-12-20 20:59 ` PATCH Pete Popov
2002-12-21 20:39 ` PATCH James Simmons
2002-12-14 4:50 PATCH Pete Popov
2002-07-15 22:29 PATCH Pete Popov
2002-07-16 15:07 ` PATCH Ralf Baechle
2002-07-16 15:15 ` PATCH Pete Popov
2002-07-16 17:43 ` PATCH Joe George
2002-07-16 18:00 ` PATCH Pete Popov
2002-07-17 0:29 ` PATCH Vivien Chappelier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416AB5DF.70209@embeddedalley.com \
--to=ppopov@embeddedalley.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox