* [2.6 patch] 2.6.10-mm2: let I2C_ALGO_SGI depend on MIPS
[not found] <20050106002240.00ac4611.akpm@osdl.org>
@ 2005-01-06 18:15 ` Adrian Bunk
2005-01-06 19:27 ` Ralf Baechle
0 siblings, 1 reply; 6+ messages in thread
From: Adrian Bunk @ 2005-01-06 18:15 UTC (permalink / raw)
To: Andrew Morton, greg, Ladislav Michl
Cc: linux-kernel, sensors, ralf, linux-mips
On Thu, Jan 06, 2005 at 12:22:40AM -0800, Andrew Morton wrote:
>...
> All 560 patches:
>...
> bk-i2c.patch
>...
There's no reason for offering a MIPS-only driver on other architectures
(even though it does compile).
Even better dependencies on specific MIPS variables might be possible
that obsolete this patch, but this patch fixes at least the !MIPS case.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.10-mm2-full/drivers/i2c/algos/Kconfig.old 2005-01-06 19:07:16.000000000 +0100
+++ linux-2.6.10-mm2-full/drivers/i2c/algos/Kconfig 2005-01-06 19:08:22.000000000 +0100
@@ -61,7 +61,7 @@
config I2C_ALGO_SGI
tristate "I2C SGI interfaces"
- depends on I2C
+ depends on I2C && MIPS
help
Supports the SGI interfaces like the ones found on SGI Indy VINO
or SGI O2 MACE.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] 2.6.10-mm2: let I2C_ALGO_SGI depend on MIPS
2005-01-06 18:15 ` [2.6 patch] 2.6.10-mm2: let I2C_ALGO_SGI depend on MIPS Adrian Bunk
@ 2005-01-06 19:27 ` Ralf Baechle
2005-01-06 19:35 ` Ilya A. Volynets-Evenbakh
0 siblings, 1 reply; 6+ messages in thread
From: Ralf Baechle @ 2005-01-06 19:27 UTC (permalink / raw)
To: Adrian Bunk
Cc: Andrew Morton, greg, Ladislav Michl, linux-kernel, sensors,
linux-mips
On Thu, Jan 06, 2005 at 07:15:20PM +0100, Adrian Bunk wrote:
> There's no reason for offering a MIPS-only driver on other architectures
> (even though it does compile).
>
> Even better dependencies on specific MIPS variables might be possible
> that obsolete this patch, but this patch fixes at least the !MIPS case.
Please make that depend on SGI_IP22 || SGI_IP32 instead; the only machines
actually using it.
Ladis, is VisWS using this algo also?
Ralf
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] 2.6.10-mm2: let I2C_ALGO_SGI depend on MIPS
2005-01-06 19:27 ` Ralf Baechle
@ 2005-01-06 19:35 ` Ilya A. Volynets-Evenbakh
2005-01-06 19:46 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Ilya A. Volynets-Evenbakh @ 2005-01-06 19:35 UTC (permalink / raw)
To: Ralf Baechle
Cc: Adrian Bunk, Andrew Morton, greg, Ladislav Michl, linux-kernel,
sensors, linux-mips
Ralf Baechle wrote:
>On Thu, Jan 06, 2005 at 07:15:20PM +0100, Adrian Bunk wrote:
>
>
>
>>There's no reason for offering a MIPS-only driver on other architectures
>>(even though it does compile).
>>
>>Even better dependencies on specific MIPS variables might be possible
>>that obsolete this patch, but this patch fixes at least the !MIPS case.
>>
>>
>
>Please make that depend on SGI_IP22 || SGI_IP32 instead; the only machines
>actually using it.
>
>Ladis, is VisWS using this algo also?
>
>
Since MACE is common part, it most likely does.
> Ralf
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] 2.6.10-mm2: let I2C_ALGO_SGI depend on MIPS
2005-01-06 19:35 ` Ilya A. Volynets-Evenbakh
@ 2005-01-06 19:46 ` Greg KH
2005-01-07 9:12 ` Ladislav Michl
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2005-01-06 19:46 UTC (permalink / raw)
To: Ilya A. Volynets-Evenbakh
Cc: Ralf Baechle, Adrian Bunk, Andrew Morton, Ladislav Michl,
linux-kernel, sensors, linux-mips
On Thu, Jan 06, 2005 at 11:35:47AM -0800, Ilya A. Volynets-Evenbakh wrote:
> Ralf Baechle wrote:
>
> >On Thu, Jan 06, 2005 at 07:15:20PM +0100, Adrian Bunk wrote:
> >
> >
> >
> >>There's no reason for offering a MIPS-only driver on other architectures
> >>(even though it does compile).
> >>
> >>Even better dependencies on specific MIPS variables might be possible
> >>that obsolete this patch, but this patch fixes at least the !MIPS case.
> >>
> >>
> >
> >Please make that depend on SGI_IP22 || SGI_IP32 instead; the only machines
> >actually using it.
> >
> >Ladis, is VisWS using this algo also?
> >
> >
> Since MACE is common part, it most likely does.
Ok, can someone send me the proper patch then?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] 2.6.10-mm2: let I2C_ALGO_SGI depend on MIPS
2005-01-06 19:46 ` Greg KH
@ 2005-01-07 9:12 ` Ladislav Michl
2005-01-07 19:14 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Ladislav Michl @ 2005-01-07 9:12 UTC (permalink / raw)
To: Greg KH
Cc: Ilya A. Volynets-Evenbakh, Ralf Baechle, Adrian Bunk,
Andrew Morton, linux-kernel, sensors, linux-mips
On Thu, Jan 06, 2005 at 11:46:46AM -0800, Greg KH wrote:
> Ok, can someone send me the proper patch then?
Index: drivers/i2c/algos/Kconfig
===================================================================
RCS file: /home/cvs/linux/drivers/i2c/algos/Kconfig,v
retrieving revision 1.3
diff -u -r1.3 Kconfig
--- drivers/i2c/algos/Kconfig 24 Aug 2004 15:10:09 -0000 1.3
+++ drivers/i2c/algos/Kconfig 7 Jan 2005 09:10:10 -0000
@@ -61,7 +61,7 @@
config I2C_ALGO_SGI
tristate "I2C SGI interfaces"
- depends on I2C
+ depends on I2C && (SGI_IP22 || SGI_IP32 || X86_VISWS)
help
Supports the SGI interfaces like the ones found on SGI Indy VINO
or SGI O2 MACE.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [2.6 patch] 2.6.10-mm2: let I2C_ALGO_SGI depend on MIPS
2005-01-07 9:12 ` Ladislav Michl
@ 2005-01-07 19:14 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2005-01-07 19:14 UTC (permalink / raw)
To: Ladislav Michl
Cc: Ilya A. Volynets-Evenbakh, Ralf Baechle, Adrian Bunk,
Andrew Morton, linux-kernel, sensors, linux-mips
On Fri, Jan 07, 2005 at 10:12:19AM +0100, Ladislav Michl wrote:
> On Thu, Jan 06, 2005 at 11:46:46AM -0800, Greg KH wrote:
> > Ok, can someone send me the proper patch then?
>
> Index: drivers/i2c/algos/Kconfig
Applied, thanks.
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-01-07 19:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20050106002240.00ac4611.akpm@osdl.org>
2005-01-06 18:15 ` [2.6 patch] 2.6.10-mm2: let I2C_ALGO_SGI depend on MIPS Adrian Bunk
2005-01-06 19:27 ` Ralf Baechle
2005-01-06 19:35 ` Ilya A. Volynets-Evenbakh
2005-01-06 19:46 ` Greg KH
2005-01-07 9:12 ` Ladislav Michl
2005-01-07 19:14 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox