Re: adding another PCI based serial port board causing errors on db1550

Re: adding another PCI based serial port board causing errors on db1550

[Michael Stickel]

rolf liu wrote:

>the driver for the board also has function "register_serial" and
>"unregister_serial", which are already defined by au1x00-serial.c. So
>there comes "multiple deginition" of these functions. Any idea on this
>issue?
>  
>

I also needed another serial port. I have made register_serial and 
unregister_serial static in au1x00-serial.c so they will shadow the 
external functions with the same name and will not be exported and 
changed the name from ttyS to ttySA to avoid conflicts with serial.c.
After that it worked for me.

static struct console sercons = {
        .name           = "ttySA",
        .write          = serial_console_write,
        .device         = serial_console_device,
        .setup          = serial_console_setup,
        .flags          = CON_PRINTBUFFER,
        .index          = -1,
};

adding another PCI based serial port board causing errors on db1550

[rolf liu]

the driver for the board also has function "register_serial" and
"unregister_serial", which are already defined by au1x00-serial.c. So
there comes "multiple deginition" of these functions. Any idea on this
issue?

thanks

Re: adding another PCI based serial port board causing errors on db1550

[Ralf Baechle]

On Fri, Jun 24, 2005 at 03:51:06PM -0700, rolf liu wrote:
> Date:	Fri, 24 Jun 2005 15:51:06 -0700
> From:	rolf liu <rolfliu@gmail.com>
> To:	linux-mips@linux-mips.org
> Subject: adding another PCI based serial port board causing errors on db1550
> Content-Type:	text/plain; charset=US-ASCII
> 
> the driver for the board also has function "register_serial" and
> "unregister_serial", which are already defined by au1x00-serial.c. So
> there comes "multiple deginition" of these functions. Any idea on this
> issue?

The driver is basically a copy of the 8250 driver with everything including
all the unused gunk.

Pete, the driver really needs a cleanup ...

  Ralf