From: Sergei Shtylylov <sshtylyov@ru.mvista.com>
To: Linux MIPS Development <linux-mips@linux-mips.org>
Cc: Manish Lachwani <mlachwani@mvista.com>
Subject: Re: Misc. AMD DBAu1550 fixes
Date: Sun, 23 Oct 2005 00:23:14 +0400 [thread overview]
Message-ID: <435A9FB2.3070303@ru.mvista.com> (raw)
In-Reply-To: <4357F774.9010208@ru.mvista.com>
[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]
Hello, I wrote:
> Here's a couple of DBAu1550 fixes: the first one fixes BCSR accesses in
> the board setup/reset code (the registers are actually 16-bit, and their
> addresses are different between DBAu1550 and other DBAu1xx0 boards), the
Here's an updated BCSR patch. Stupid typo. :-/
> second one just selects the proper machine type for DBAu1550.
It was somewhat incomplete, more #ifdef's are needed to set the proper
machine types for DB1100/DB1500...
> ------------------------------------------------------------------------
>
> Index: linux/arch/mips/au1000/db1x00/board_setup.c
> ===================================================================
> --- linux.orig/arch/mips/au1000/db1x00/board_setup.c
> +++ linux/arch/mips/au1000/db1x00/board_setup.c
> @@ -45,13 +45,12 @@
> #include <asm/mach-au1x00/au1000.h>
> #include <asm/mach-db1x00/db1x00.h>
>
> -/* not correct for db1550 */
> -static BCSR * const bcsr = (BCSR *)0xAE000000;
> +static BCSR * const bcsr = (BCSR *)BCSR_KSEG1_ADDR;
>
> void board_reset (void)
> {
> /* Hit BCSR.SYSTEM_CONTROL[SW_RST] */
> - au_writel(0x00000000, 0xAE00001C);
> + bcsr->swreset = 0x0000);
My bad. Really don't know how this paren got there. :-/
WBR, Sergei
[-- Attachment #2: db1550-bcsr-fix.patch --]
[-- Type: text/plain, Size: 901 bytes --]
Index: linux/arch/mips/au1000/db1x00/board_setup.c
===================================================================
--- linux.orig/arch/mips/au1000/db1x00/board_setup.c
+++ linux/arch/mips/au1000/db1x00/board_setup.c
@@ -45,13 +45,12 @@
#include <asm/mach-au1x00/au1000.h>
#include <asm/mach-db1x00/db1x00.h>
-/* not correct for db1550 */
-static BCSR * const bcsr = (BCSR *)0xAE000000;
+static BCSR * const bcsr = (BCSR *)BCSR_KSEG1_ADDR;
void board_reset (void)
{
/* Hit BCSR.SYSTEM_CONTROL[SW_RST] */
- au_writel(0x00000000, 0xAE00001C);
+ bcsr->swreset = 0x0000;
}
void __init board_setup(void)
@@ -75,7 +75,7 @@ void __init board_setup(void)
bcsr->resets |= BCSR_RESETS_IRDA_MODE_OFF;
au_sync();
#endif
- au_writel(0, 0xAE000010); /* turn off pcmcia power */
+ bcsr->pcmcia = 0x0000; /* turn off PCMCIA power */
#ifdef CONFIG_MIPS_MIRAGE
/* enable GPIO[31:0] inputs */
next prev parent reply other threads:[~2005-10-22 20:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-20 20:00 Misc. AMD DBAu1550 fixes Sergei Shtylylov
2005-10-22 20:23 ` Sergei Shtylylov [this message]
2005-10-31 21:06 ` [PATCH] Set proper machine type for DB1xx0 boards Sergei Shtylylov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=435A9FB2.3070303@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=linux-mips@linux-mips.org \
--cc=mlachwani@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox