From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Geoff Levand <geoffrey.levand@am.sony.com>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
ralf@linux-mips.org, linux-mips@linux-mips.org
Subject: Re: tx49 Ether problems
Date: Sun, 16 Apr 2006 00:52:39 +0400 [thread overview]
Message-ID: <44415D17.1070005@ru.mvista.com> (raw)
In-Reply-To: <444032A5.3030304@am.sony.com>
Hello.
Geoff Levand wrote:
>>On Fri, 14 Apr 2006 08:38:00 -0700, Geoff Levand
>><geoffrey.levand@am.sony.com> wrote:
>>>I seem to get a lot of problems with an nfs root fs
>>>on tx4937 board. I haven't looked at it closely yet,
>>>but I guess its some problem with the ne2000 driver.
>>>I wanted to know if you know anything about this.
>>Please look at:
>>http://www.linux-mips.org/cgi-bin/mesg.cgi?a=linux-mips&i=20060226.23054
>>1.75185772.anemo%40mba.ocn.ne.jp
>>With a quick glance of ne.c, it seems ei_status.stop_page should be
>>changed to 0x60 on the board. Please confirm its value.
> Yes, this seems to fix the problem.
> Index: 2.6.16.1/drivers/net/ne.c
> ===================================================================
> --- 2.6.16.1.orig/drivers/net/ne.c 2006-04-14 15:54:41.000000000 -0700
> +++ 2.6.16.1/drivers/net/ne.c 2006-04-14 16:27:51.000000000 -0700
> @@ -140,7 +140,8 @@
> #define NE1SM_START_PG 0x20 /* First page of TX buffer */
> #define NE1SM_STOP_PG 0x40 /* Last page +1 of RX ring */
> #define NESM_START_PG 0x40 /* First page of TX buffer */
> -#define NESM_STOP_PG 0x80 /* Last page +1 of RX ring */
> +#define NESM_8_STOP_PG 0x60 /* Last page +1 of RX ring, RTL8019 8 bit mode */
> +#define NESM_STOP_PG 0x80 /* Last page +1 of RX ring */
>
> #if defined(CONFIG_PLAT_MAPPI)
> # define DCR_VAL 0x4b
> @@ -516,6 +517,7 @@
> ei_status.tx_start_page = start_page;
> ei_status.stop_page = stop_page;
> #if defined(CONFIG_TOSHIBA_RBTX4927) || defined(CONFIG_TOSHIBA_RBTX4938)
> + ei_status.stop_page = NESM_8_STOP_PG;
> wordlength = 1;
> #endif
This is really strange place for that #ifdef -- 'wordlength' is determined
much earlier in this function (and stop_page is set to 0x40 for 8-bit case),
shouldn't #ifdef be moved instead?
WBR, Sergei
next prev parent reply other threads:[~2006-04-15 20:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-14 15:38 tx49 Ether problems Geoff Levand
2006-04-14 16:05 ` Atsushi Nemoto
2006-04-14 23:39 ` Geoff Levand
2006-04-15 20:52 ` Sergei Shtylyov [this message]
2006-04-16 18:50 ` Sergei Shtylyov
2006-04-17 2:09 ` Atsushi Nemoto
2006-04-17 13:06 ` Sergei Shtylyov
2006-04-17 15:09 ` Atsushi Nemoto
2006-04-17 16:07 ` Sergei Shtylyov
2006-04-17 16:12 ` Sergei Shtylyov
2006-05-08 20:00 ` [PATCH] Fix RTL8019AS init for Toshiba RBTX49xx boards Sergei Shtylyov
2006-05-08 20:55 ` Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44415D17.1070005@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=geoffrey.levand@am.sony.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox