From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: geoffrey.levand@am.sony.com, linux-mips@linux-mips.org
Subject: Re: tx49 Ether problems
Date: Mon, 17 Apr 2006 17:06:23 +0400 [thread overview]
Message-ID: <444392CF.7070808@ru.mvista.com> (raw)
In-Reply-To: <20060417.110945.59031594.nemoto@toshiba-tops.co.jp>
Hello.
Atsushi Nemoto wrote:
> On Sun, 16 Apr 2006 22:50:17 +0400, Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:
>>> This is really strange place for that #ifdef -- 'wordlength' is
>>>determined much earlier in this function (and stop_page is set to 0x40
>>>for 8-bit case), shouldn't #ifdef be moved instead?
>> What I think we actually need is more generic fix for RTL8019AS, not the
>>board specific hacks -- if this RX ring stop page value limitation *really*
>>needs to be enforced.
> I agree with you. Then how about something like
> CONFIG_NE2000_RTL8019_BYTEMODE?
Have you looked at the patch? RTL8019 is easily detectable at runtime, so
the limitation is easily enforcable w/o extra Kconfig option, I think
> Also, setting 0xbad value to mem_end
> can skip the Product-ID checking without inflating bad_clone_list.
> Just a thought...
0xbad in dev->mem_end currently skips 8390 reset which is not a good thing
for the clones for which it does work...
> ---
> Atsushi Nemoto
WBR, Sergei
next prev parent reply other threads:[~2006-04-17 12:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-14 15:38 tx49 Ether problems Geoff Levand
2006-04-14 16:05 ` Atsushi Nemoto
2006-04-14 23:39 ` Geoff Levand
2006-04-15 20:52 ` Sergei Shtylyov
2006-04-16 18:50 ` Sergei Shtylyov
2006-04-17 2:09 ` Atsushi Nemoto
2006-04-17 13:06 ` Sergei Shtylyov [this message]
2006-04-17 15:09 ` Atsushi Nemoto
2006-04-17 16:07 ` Sergei Shtylyov
2006-04-17 16:12 ` Sergei Shtylyov
2006-05-08 20:00 ` [PATCH] Fix RTL8019AS init for Toshiba RBTX49xx boards Sergei Shtylyov
2006-05-08 20:55 ` Auke Kok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=444392CF.7070808@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=geoffrey.levand@am.sony.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox