From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Rodolfo Giometti <giometti@linux.it>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Physical addresses fix for au1x00 serial driver
Date: Thu, 04 May 2006 18:27:49 +0400 [thread overview]
Message-ID: <445A0F65.8060803@ru.mvista.com> (raw)
In-Reply-To: <20060504135837.GF19913@gundam.enneenne.com>
Hello.
Rodolfo Giometti wrote:
>>> This is not quite correct. The UARTs take up 1 MB of memory each.
> The patch:
> diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
> index 8365d5b..3473e7a 100644
> --- a/drivers/serial/8250.c
> +++ b/drivers/serial/8250.c
> @@ -1935,8 +1935,10 @@ static int serial8250_request_std_resour
> int ret = 0;
>
> switch (up->port.iotype) {
> - case UPIO_MEM:
> case UPIO_AU:
> + size = 0x100000;
> + /* fall thru */
> + case UPIO_MEM:
> if (!up->port.mapbase)
> break;
> I'll merge this patch with my previous one ASAP...
Better just use my patch. There's no sense in calling ioremp() on UART
addresses.
> Ciao,
>
> Rodolfo
WBR, Sergei
prev parent reply other threads:[~2006-05-04 14:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-04 10:11 [PATCH] Physical addresses fix for au1x00 serial driver Rodolfo Giometti
2006-05-04 12:44 ` Sergei Shtylyov
2006-05-04 13:24 ` Rodolfo Giometti
2006-05-04 13:58 ` Rodolfo Giometti
2006-05-04 14:27 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=445A0F65.8060803@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=giometti@linux.it \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox