* [PATCH] Physical addresses fix for au1x00 serial driver
@ 2006-05-04 10:11 Rodolfo Giometti
2006-05-04 12:44 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Rodolfo Giometti @ 2006-05-04 10:11 UTC (permalink / raw)
To: linux-mips
Hello,
here:
http://ftp.enneenne.com/pub/misc/au1100-patches/linux/patch-au1x00-serial-phys-addr
a little patch (against «linux-2.6.16-stable» branch and tested on
au1100 based board) to fix the addresses specification for the serial
driver. With this patch at boot time we get:
Serial: 8250/16550 driver $Revision: 1.90 $ 3 ports, IRQ sharing disabled
serial8250.7: ttyS0 at MMIO 0x11100000 (irq = 0) is a 16550A
serial8250.7: ttyS1 at MMIO 0x11200000 (irq = 1) is a 16550A
serial8250.7: ttyS2 at MMIO 0x11400000 (irq = 3) is a 16550A
and into procfs we read:
wwpc:~# cat /proc/iomem
10100000-10200000 : au1xxx-ohci.0
10500000-1050ffff : eth-base
10520000-10520003 : eth-mac
11100000-1110001f : serial
11200000-1120001f : serial
11400000-1140001f : serial
wwpc:~# cat /proc/tty/driver/serial
serinfo:1.0 driver revision:
0: uart:16550A port:11100000 irq:0 tx:3905 rx:39 RTS|CTS|DTR|DSR|CD|RI
1: uart:16550A port:11200000 irq:1 tx:0 rx:0 CTS|DSR|CD|RI
2: uart:16550A port:11400000 irq:3 tx:0 rx:0 CTS|DSR|CD|RI
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@gnudd.com
Embedded Systems giometti@linux.it
UNIX programming phone: +39 349 2432127
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Physical addresses fix for au1x00 serial driver
2006-05-04 10:11 [PATCH] Physical addresses fix for au1x00 serial driver Rodolfo Giometti
@ 2006-05-04 12:44 ` Sergei Shtylyov
2006-05-04 13:24 ` Rodolfo Giometti
0 siblings, 1 reply; 5+ messages in thread
From: Sergei Shtylyov @ 2006-05-04 12:44 UTC (permalink / raw)
To: Rodolfo Giometti; +Cc: linux-mips
Hello.
Rodolfo Giometti wrote:
> here:
>
> http://ftp.enneenne.com/pub/misc/au1100-patches/linux/patch-au1x00-serial-phys-addr
> a little patch (against «linux-2.6.16-stable» branch and tested on
> au1100 based board) to fix the addresses specification for the serial
> driver. With this patch at boot time we get:
> Serial: 8250/16550 driver $Revision: 1.90 $ 3 ports, IRQ sharing disabled
> serial8250.7: ttyS0 at MMIO 0x11100000 (irq = 0) is a 16550A
> serial8250.7: ttyS1 at MMIO 0x11200000 (irq = 1) is a 16550A
> serial8250.7: ttyS2 at MMIO 0x11400000 (irq = 3) is a 16550A
I have already noticed and fixed this. The fix is in Andrew Morton's tree
(unpublished yet). See this msg for the patch:
http://www.linux-mips.org/archives/linux-mips/2006-04/msg00029.html
> wwpc:~# cat /proc/iomem
> 10100000-10200000 : au1xxx-ohci.0
> 10500000-1050ffff : eth-base
> 10520000-10520003 : eth-mac
> 11100000-1110001f : serial
> 11200000-1120001f : serial
> 11400000-1140001f : serial
This is not quite correct. The UARTs take up 1 MB of memory each.
> Ciao,
>
> Rodolfo
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Physical addresses fix for au1x00 serial driver
2006-05-04 12:44 ` Sergei Shtylyov
@ 2006-05-04 13:24 ` Rodolfo Giometti
2006-05-04 13:58 ` Rodolfo Giometti
0 siblings, 1 reply; 5+ messages in thread
From: Rodolfo Giometti @ 2006-05-04 13:24 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-mips
[-- Attachment #1: Type: text/plain, Size: 996 bytes --]
On Thu, May 04, 2006 at 04:44:29PM +0400, Sergei Shtylyov wrote:
>
> I have already noticed and fixed this. The fix is in Andrew Morton's
> tree (unpublished yet). See this msg for the patch:
>
> http://www.linux-mips.org/archives/linux-mips/2006-04/msg00029.html
I see. :)
> This is not quite correct. The UARTs take up 1 MB of memory each.
Yes, in my patch is missing this part:
switch (up->port.iotype) {
+ case UPIO_AU:
+ size = 0x100000;
+ /* fall thru */
case UPIO_MEM:
if (!up->port.mapbase)
Are you already working on 8250_early for au1x00? I'm quite ready for
the patch. :)
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@gnudd.com
Embedded Systems giometti@linux.it
UNIX programming phone: +39 349 2432127
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Physical addresses fix for au1x00 serial driver
2006-05-04 13:24 ` Rodolfo Giometti
@ 2006-05-04 13:58 ` Rodolfo Giometti
2006-05-04 14:27 ` Sergei Shtylyov
0 siblings, 1 reply; 5+ messages in thread
From: Rodolfo Giometti @ 2006-05-04 13:58 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: linux-mips
[-- Attachment #1: Type: text/plain, Size: 949 bytes --]
On Thu, May 04, 2006 at 03:24:13PM +0200, Rodolfo Giometti wrote:
> > This is not quite correct. The UARTs take up 1 MB of memory each.
The patch:
diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
index 8365d5b..3473e7a 100644
--- a/drivers/serial/8250.c
+++ b/drivers/serial/8250.c
@@ -1935,8 +1935,10 @@ static int serial8250_request_std_resour
int ret = 0;
switch (up->port.iotype) {
- case UPIO_MEM:
case UPIO_AU:
+ size = 0x100000;
+ /* fall thru */
+ case UPIO_MEM:
if (!up->port.mapbase)
break;
I'll merge this patch with my previous one ASAP...
Ciao,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@gnudd.com
Embedded Systems giometti@linux.it
UNIX programming phone: +39 349 2432127
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Physical addresses fix for au1x00 serial driver
2006-05-04 13:58 ` Rodolfo Giometti
@ 2006-05-04 14:27 ` Sergei Shtylyov
0 siblings, 0 replies; 5+ messages in thread
From: Sergei Shtylyov @ 2006-05-04 14:27 UTC (permalink / raw)
To: Rodolfo Giometti; +Cc: linux-mips
Hello.
Rodolfo Giometti wrote:
>>> This is not quite correct. The UARTs take up 1 MB of memory each.
> The patch:
> diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c
> index 8365d5b..3473e7a 100644
> --- a/drivers/serial/8250.c
> +++ b/drivers/serial/8250.c
> @@ -1935,8 +1935,10 @@ static int serial8250_request_std_resour
> int ret = 0;
>
> switch (up->port.iotype) {
> - case UPIO_MEM:
> case UPIO_AU:
> + size = 0x100000;
> + /* fall thru */
> + case UPIO_MEM:
> if (!up->port.mapbase)
> break;
> I'll merge this patch with my previous one ASAP...
Better just use my patch. There's no sense in calling ioremp() on UART
addresses.
> Ciao,
>
> Rodolfo
WBR, Sergei
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-05-04 14:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-05-04 10:11 [PATCH] Physical addresses fix for au1x00 serial driver Rodolfo Giometti
2006-05-04 12:44 ` Sergei Shtylyov
2006-05-04 13:24 ` Rodolfo Giometti
2006-05-04 13:58 ` Rodolfo Giometti
2006-05-04 14:27 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox