[PATCH] add "depends on BROKEN" to broken boards support

[PATCH] add "depends on BROKEN" to broken boards support

[Yoichi Yuasa]

Hi Ralf,

This patch has added "depends on BROKEN" to broken boards support.
These boards cannot build now.

Yoichi

Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>

diff -pruN -X mips/Documentation/dontdiff mips-orig/arch/mips/Kconfig mips/arch/mips/Kconfig
--- mips-orig/arch/mips/Kconfig	2006-10-05 22:29:18.893785250 +0900
+++ mips/arch/mips/Kconfig	2006-10-05 22:30:34.042481750 +0900
@@ -121,6 +121,7 @@ config MIPS_MIRAGE
 
 config BASLER_EXCITE
 	bool "Basler eXcite smart camera support"
+	depends on BROKEN
 	select DMA_COHERENT
 	select HW_HAS_PCI
 	select IRQ_CPU
@@ -188,7 +189,7 @@ config MACH_DECSTATION
 
 config MIPS_EV64120
 	bool "Galileo EV64120 Evaluation board (EXPERIMENTAL)"
-	depends on EXPERIMENTAL
+	depends on BROKEN
 	select DMA_NONCOHERENT
 	select HW_HAS_PCI
 	select MIPS_GT64120
@@ -343,6 +344,7 @@ config MIPS_SIM
 
 config MOMENCO_JAGUAR_ATX
 	bool "Momentum Jaguar board"
+	depends on BROKEN
 	select BOOT_ELF32
 	select DMA_NONCOHERENT
 	select HW_HAS_PCI
@@ -363,6 +365,7 @@ config MOMENCO_JAGUAR_ATX
 
 config MOMENCO_OCELOT
 	bool "Momentum Ocelot board"
+	depends on BROKEN
 	select DMA_NONCOHERENT
 	select HW_HAS_PCI
 	select IRQ_CPU
@@ -380,6 +383,7 @@ config MOMENCO_OCELOT
 
 config MOMENCO_OCELOT_3
 	bool "Momentum Ocelot-3 board"
+	depends on BROKEN
 	select BOOT_ELF32
 	select DMA_NONCOHERENT
 	select HW_HAS_PCI
@@ -399,6 +403,7 @@ config MOMENCO_OCELOT_3
 
 config MOMENCO_OCELOT_C
 	bool "Momentum Ocelot-C board"
+	depends on BROKEN
 	select DMA_NONCOHERENT
 	select HW_HAS_PCI
 	select IRQ_CPU
@@ -416,6 +421,7 @@ config MOMENCO_OCELOT_C
 
 config MOMENCO_OCELOT_G
 	bool "Momentum Ocelot-G board"
+	depends on BROKEN
 	select DMA_NONCOHERENT
 	select HW_HAS_PCI
 	select IRQ_CPU
@@ -511,6 +517,7 @@ config QEMU
 
 config MARKEINS
 	bool "Support for NEC EMMA2RH Mark-eins"
+	depends on BROKEN
 	select DMA_NONCOHERENT
 	select HW_HAS_PCI
 	select IRQ_CPU
@@ -717,6 +724,7 @@ config SNI_RM200_PCI
 
 config TOSHIBA_JMR3927
 	bool "Toshiba JMR-TX3927 board"
+	depends on BROKEN
 	select DMA_NONCOHERENT
 	select HW_HAS_PCI
 	select MIPS_TX3927
@@ -728,6 +736,7 @@ config TOSHIBA_JMR3927
 
 config TOSHIBA_RBTX4927
 	bool "Toshiba TBTX49[23]7 board"
+	depends on BROKEN
 	select DMA_NONCOHERENT
 	select HAS_TXX9_SERIAL
 	select HW_HAS_PCI
@@ -745,6 +754,7 @@ config TOSHIBA_RBTX4927
 
 config TOSHIBA_RBTX4938
 	bool "Toshiba RBTX4938 board"
+	depends on BROKEN
 	select HAVE_STD_PC_SERIAL_PORT
 	select DMA_NONCOHERENT
 	select GENERIC_ISA_DMA

Re: [PATCH] add "depends on BROKEN" to broken boards support

[Sergei Shtylyov]

Hello.

Yoichi Yuasa wrote:

> This patch has added "depends on BROKEN" to broken boards support.
> These boards cannot build now.

> Yoichi

> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>

> @@ -511,6 +517,7 @@ config QEMU
>  
>  config MARKEINS
>  	bool "Support for NEC EMMA2RH Mark-eins"
> +	depends on BROKEN
>  	select DMA_NONCOHERENT
>  	select HW_HAS_PCI
>  	select IRQ_CPU

    What's broken about this board?

> @@ -717,6 +724,7 @@ config SNI_RM200_PCI
>  
>  config TOSHIBA_JMR3927
>  	bool "Toshiba JMR-TX3927 board"
> +	depends on BROKEN
>  	select DMA_NONCOHERENT
>  	select HW_HAS_PCI
>  	select MIPS_TX3927
> @@ -728,6 +736,7 @@ config TOSHIBA_JMR3927
>  
>  config TOSHIBA_RBTX4927
>  	bool "Toshiba TBTX49[23]7 board"
> +	depends on BROKEN
>  	select DMA_NONCOHERENT
>  	select HAS_TXX9_SERIAL
>  	select HW_HAS_PCI

    ... and this one?

> @@ -745,6 +754,7 @@ config TOSHIBA_RBTX4927
>  
>  config TOSHIBA_RBTX4938
>  	bool "Toshiba RBTX4938 board"
> +	depends on BROKEN
>  	select HAVE_STD_PC_SERIAL_PORT
>  	select DMA_NONCOHERENT
>  	select GENERIC_ISA_DMA

    There's a patch from Atsushi Nemoto still pending commit, IIRC...

WBR, Sergei

Re: [PATCH] add "depends on BROKEN" to broken boards support

[Yoichi Yuasa]

Hello Sergei,

On Fri, 06 Oct 2006 22:31:15 +0400
Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:

> Hello.
> 
> Yoichi Yuasa wrote:
> 
> > This patch has added "depends on BROKEN" to broken boards support.
> > These boards cannot build now.
> 
> > Yoichi
> 
> > Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
> 
> > @@ -511,6 +517,7 @@ config QEMU
> >  
> >  config MARKEINS
> >  	bool "Support for NEC EMMA2RH Mark-eins"
> > +	depends on BROKEN
> >  	select DMA_NONCOHERENT
> >  	select HW_HAS_PCI
> >  	select IRQ_CPU
> 
>     What's broken about this board?

I got build error under arch/mips/emma2rh .
This board support cannot be built for three months or more.

  CC      arch/mips/emma2rh/common/irq.o
arch/mips/emma2rh/common/irq.c: In function `emma2rh_irq_dispatch':
arch/mips/emma2rh/common/irq.c:59: error: too many arguments to function `__do_IRQ'
arch/mips/emma2rh/common/irq.c:68: error: too many arguments to function `__do_IRQ'
arch/mips/emma2rh/common/irq.c:84: error: too many arguments to function `__do_IRQ'
arch/mips/emma2rh/common/irq.c:93: error: too many arguments to function `__do_IRQ'
arch/mips/emma2rh/common/irq.c:103: error: too many arguments to function `__do_IRQ'
make[1]: *** [arch/mips/emma2rh/common/irq.o] Error 1
make: *** [arch/mips/emma2rh/common] Error 2


> 
> > @@ -717,6 +724,7 @@ config SNI_RM200_PCI
> >  
> >  config TOSHIBA_JMR3927
> >  	bool "Toshiba JMR-TX3927 board"
> > +	depends on BROKEN
> >  	select DMA_NONCOHERENT
> >  	select HW_HAS_PCI
> >  	select MIPS_TX3927
> > @@ -728,6 +736,7 @@ config TOSHIBA_JMR3927
> >  
> >  config TOSHIBA_RBTX4927
> >  	bool "Toshiba TBTX49[23]7 board"
> > +	depends on BROKEN
> >  	select DMA_NONCOHERENT
> >  	select HAS_TXX9_SERIAL
> >  	select HW_HAS_PCI
> 
>     ... and this one?

Also, this board support cannot be built for three months or more.

  CC      arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_prom.o
  CC      arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.o
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c: In function `tx4927_pcibios_init':
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c:274: warning: unused variable `s'
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c:359: warning: unused variable `s'
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c: In function `toshiba_rbtx4927_setup':
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c:1003: warning: implicit declaration of function `prom_getcmdline'
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c:1003: warning: assignment makes pointer from integer without a cast
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c:1011: warning: assignment makes pointer from integer without a cast
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c: In function `toshiba_rbtx4927_time_init':
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c:1031: warning: unused variable `c1'
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c:1032: warning: unused variable `c2'
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c: At top level:
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c:165: warning: 'tx4927_pcierr_interrupt' defined but not used
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c:244: warning: 'early_read_config_word' defined but not used
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_setup.c:247: warning: 'early_write_config_word' defined but not used
  CC      arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_irq.o
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_irq.c: In function `toshiba_rbtx4927_irq_ioc_enable':
arch/mips/tx4927/toshiba_rbtx4927/toshiba_rbtx4927_irq.c:434: warning: implicit declaration of function `wbflush'
  LD      arch/mips/tx4927/toshiba_rbtx4927/built-in.o
  CC      arch/mips/tx4927/common/tx4927_prom.o
  CC      arch/mips/tx4927/common/tx4927_setup.o
  CC      arch/mips/tx4927/common/tx4927_irq.o
arch/mips/tx4927/common/tx4927_irq.c: In function `tx4927_irq_nested':
arch/mips/tx4927/common/tx4927_irq.c:563: warning: implicit declaration of function `toshiba_rbtx4927_irq_nested'
make[1]: *** No rule to make target `arch/mips/tx4927/common/smsc_fdc37m81x.o', needed by `arch/mips/tx4927/common/built-in.o'.  Stop.
make: *** [arch/mips/tx4927/common] Error 2

> > @@ -745,6 +754,7 @@ config TOSHIBA_RBTX4927
> >  
> >  config TOSHIBA_RBTX4938
> >  	bool "Toshiba RBTX4938 board"
> > +	depends on BROKEN
> >  	select HAVE_STD_PC_SERIAL_PORT
> >  	select DMA_NONCOHERENT
> >  	select GENERIC_ISA_DMA
> 
>     There's a patch from Atsushi Nemoto still pending commit, IIRC...

Is it fixed these errors.

  LD      .tmp_vmlinux1
arch/mips/tx4938/toshiba_rbtx4938/built-in.o: In function `toshiba_rbtx4938_irq_nested':
: undefined reference to `wbflush'
arch/mips/tx4938/toshiba_rbtx4938/built-in.o: In function `toshiba_rbtx4938_irq_nested':
: relocation truncated to fit: R_MIPS_26 against `wbflush'
arch/mips/tx4938/toshiba_rbtx4938/built-in.o: In function `arch_init_irq':
: undefined reference to `wbflush'
arch/mips/tx4938/toshiba_rbtx4938/built-in.o: In function `arch_init_irq':
: relocation truncated to fit: R_MIPS_26 against `wbflush'
arch/mips/tx4938/toshiba_rbtx4938/built-in.o: In function `arch_init_irq':
: undefined reference to `wbflush'
arch/mips/tx4938/toshiba_rbtx4938/built-in.o: In function `arch_init_irq':
: relocation truncated to fit: R_MIPS_26 against `wbflush'
arch/mips/tx4938/common/built-in.o: In function `tx4938_irq_nested':
: undefined reference to `wbflush'
arch/mips/tx4938/common/built-in.o: In function `tx4938_irq_nested':
: relocation truncated to fit: R_MIPS_26 against `wbflush'
make: *** [.tmp_vmlinux1] Error 1


Yoichi

Re: [PATCH] add "depends on BROKEN" to broken boards support

[Yoichi Yuasa]

On Sat, 07 Oct 2006 22:55:07 +0900 (JST)
Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:

> On Sat, 7 Oct 2006 06:48:05 +0900, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
> > >     There's a patch from Atsushi Nemoto still pending commit, IIRC...
> > 
> > Is it fixed these errors.
> > 
> >   LD      .tmp_vmlinux1
> > arch/mips/tx4938/toshiba_rbtx4938/built-in.o: In function `toshiba_rbtx4938_irq_nested':
> > : undefined reference to `wbflush'
> > arch/mips/tx4938/toshiba_rbtx4938/built-in.o: In function `toshiba_rbtx4938_irq_nested':
> > : relocation truncated to fit: R_MIPS_26 against `wbflush'
> 
> Yes.  The patch is here.
> 
> http://www.linux-mips.org/archives/linux-mips/2006-08/msg00204.html

OK, It's fixed rbhma4500 errors.
I'll update my patch.

Yoichi

Re: [PATCH] add "depends on BROKEN" to broken boards support

[Atsushi Nemoto]

On Sat, 7 Oct 2006 06:48:05 +0900, Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp> wrote:
> >     There's a patch from Atsushi Nemoto still pending commit, IIRC...
> 
> Is it fixed these errors.
> 
>   LD      .tmp_vmlinux1
> arch/mips/tx4938/toshiba_rbtx4938/built-in.o: In function `toshiba_rbtx4938_irq_nested':
> : undefined reference to `wbflush'
> arch/mips/tx4938/toshiba_rbtx4938/built-in.o: In function `toshiba_rbtx4938_irq_nested':
> : relocation truncated to fit: R_MIPS_26 against `wbflush'

Yes.  The patch is here.

http://www.linux-mips.org/archives/linux-mips/2006-08/msg00204.html

---
Atsushi Nemoto