From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
danieljlaird@hotmail.com, linux-mips@linux-mips.org,
ralf@linux-mips.org, Vitaly Wool <vwool@ru.mvista.com>
Subject: Re: 2.6.19 timer API changes
Date: Wed, 20 Dec 2006 18:48:12 +0300 [thread overview]
Message-ID: <45895B3C.9030204@ru.mvista.com> (raw)
In-Reply-To: <458948C5.4050909@ru.mvista.com>
Hello, I wrote:
>> +
>> +static void pnx8550_timer_ack(void)
>> +{
>> + write_c0_compare(cycles_per_jiffy);
>> +}
>> +
>> +static cycle_t pnx8550_hpt_read(void)
>> +{
>> + /* FIXME: we should use timer2 or timer3 as freerun counter */
>> + return read_c0_count();
>> +}
> I'd suggest read_c0_count2() here, possibly adding an interrupt
> handler for it since it will interrupt upon hitting compare2 reg. value
> (but we could probably just mask the IRQ off), and enabling the timer 2,
> of course (the current code disables it)...
No, we'll have to handle IRQ it once the timer is enabled -- there seems
to be no provision to mask it off other than disabling the timer.
WBR, Sergei
next prev parent reply other threads:[~2006-12-20 15:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-18 9:15 2.6.19 timer API changes Daniel Laird
2006-12-19 8:17 ` Daniel Laird
2006-12-19 14:34 ` Atsushi Nemoto
2006-12-19 14:51 ` Daniel Laird
2006-12-19 16:23 ` Sergei Shtylyov
2006-12-19 15:01 ` Atsushi Nemoto
2006-12-19 15:34 ` Daniel Laird
2006-12-19 17:15 ` Atsushi Nemoto
2006-12-20 9:37 ` Daniel Laird
2006-12-20 14:12 ` Sergei Shtylyov
2006-12-20 14:50 ` Kevin D. Kissell
2006-12-20 14:50 ` Kevin D. Kissell
2006-12-20 18:01 ` Sergei Shtylyov
2006-12-20 15:24 ` Atsushi Nemoto
2006-12-20 15:46 ` Daniel Laird
2006-12-20 14:29 ` Sergei Shtylyov
2006-12-20 15:40 ` Atsushi Nemoto
2006-12-20 15:48 ` Daniel Laird
2006-12-20 15:48 ` Sergei Shtylyov [this message]
2006-12-19 15:52 ` Sergei Shtylyov
2006-12-19 16:29 ` Atsushi Nemoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45895B3C.9030204@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=danieljlaird@hotmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=vwool@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox