Re: [PATCH] Philips(NXP)/STB810 changes

[Sergei Shtylyov <sshtylyov@ru.mvista.com>]

Hello.

Daniel Laird wrote:

> We have found the following changes are necessary for the Philips(NXP)/STB810
> platform

> Signed-off-by: Daniel Laird <daniel.j.laird@nxp.com> 

> --- kernel/arch/mips/philips/pnx8550/common/setup.c
> +++ kernel-new/arch/mips/philips/pnx8550/common/setup.c 
> @@ -100,11 +100,29 @@
>  
>  	board_setup();  /* board specific setup */
>  
> -        _machine_restart = pnx8550_machine_restart;
> -        _machine_halt = pnx8550_machine_halt;
> -        pm_power_off = pnx8550_machine_power_off;
> +    _machine_restart = pnx8550_machine_restart;
> +    _machine_halt = pnx8550_machine_halt;
> +    pm_power_off = pnx8550_machine_power_off;

> +	board_time_init = pnx8550_time_init;

> -	board_time_init = pnx8550_time_init;

    What is changed here beside the tab being converted to 4 spaces for no 
reason? This violates kernel style and so is not acceptable.

> +    /* Setup CMEM Registers */
> +    /* CMEM0 = MMIO */
> +    write_c0_diag4((0x1be00000 & PR4450_CMEMF_BBA) |
> +                   (PR4450_CMEM_SIZE_2MB << PR4450_CMEMB_SIZE) |
> +                   (1 << PR4450_CMEMB_VALID));
> +
> +    /* CMEM1 = XIO */
> +    write_c0_diag5((0x10000000 & PR4450_CMEMF_BBA) |
> +                   (PR4450_CMEM_SIZE_128MB << PR4450_CMEMB_SIZE) |
> +                   (1 << PR4450_CMEMB_VALID));
> +
> +    /* CMEM2 = PCI */
> +    write_c0_diag6((0x20000000 & PR4450_CMEMF_BBA) |
> +                   (PR4450_CMEM_SIZE_128MB << PR4450_CMEMB_SIZE) |
> +                   (1 << PR4450_CMEMB_VALID));
> +
> +    /* CMEM3 = Not used */
> +    write_c0_diag7(0);

    Please indent these properly too.

>  
>  	/* Clear the Global 2 Register, PCI Inta Output Enable Registers
>  	   Bit 1:Enable DAC Powerdown

> Cheers
> Dan Laird

WBR, Sergei