From: Marc St-Jean <Marc_St-Jean@pmc-sierra.com>
To: Satyam Sharma <satyam.sharma@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Satyam Sharma <satyam.sharma@gmail.com>,
Tom Spink <tspink@gmail.com>,
Toralf F?rster <toralf.foerster@gmx.de>,
linux-kernel@vger.kernel.org,
Paolo Giarrusso <blaisorblade@yahoo.it>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-mips@linux-mips.org,
Brian Oostenbrink <Brian_Oostenbrink@pmc-sierra.com>,
Dan Doucette <Dan_Doucette@pmc-sierra.com>
Subject: Re: build failure due to ROOT_DEV in mtd module (was Re: linux-2. 6.22-rc5-g7c8545e build #298 failed ...)
Date: Thu, 21 Jun 2007 16:06:58 -0700 [thread overview]
Message-ID: <467B0492.1080007@pmc-sierra.com> (raw)
> On Thu, Jun 21, 2007 at 04:13:27 EST, Satyam Sharma wrote:
> On 6/21/07, Christoph Hellwig <hch@infradead.org> wrote:
>> On Thu, Jun 21, 2007 at 12:22:01PM +0530, Satyam Sharma wrote:
>> > >> The build seems to fail because of:
>> > >> ERROR: "ROOT_DEV" [drivers/mtd/maps/nettel.ko] undefined!
>> > >>
>> > >> After taking a quick look at the code, I can't immediately see why
>> > >> this would be, since there is an include for linux/root_dev.h at the
>> > >> top, there.
>> > >>
>> > >> There's only one occurrence of ROOT_DEV (line 425), and after a quick
>> > >> look at the git history, it seems the include was originally missing,
>> > >> but was put back in, in commit
>> > >> 6cc449c7d0292cb9b993f0df84fd3225e3099492.
>>
>> Please just the reference to ROOT_DEV from this driver. Just because
>> someone builds this driver there should be no change in the default root
>> device.
>
> I agree, but this (drivers/mtd/maps/nettel.c) isn't the only modular driver
> referencing ROOT_DEV. We also have drivers/mtd/maps/pmcmsp-ramroot.c
> using ROOT_DEV (in fact the purpose of that driver seems to be precisely
> to special-case the root fs and do something with it ...) but considering
> that other driver's (tristate) Kconfig option depends on another symbol that
> is non-existent in the mainline tree, there is no way someone can build
> pmcmsp-ramroot and so we'll never actually hit that problem even with an
> allmodconfig build.
>
> Anyway, I'll leave this up to David / linux-mtd to sort out. [ No other
> modular user of ROOT_DEV in the tree other than the two mtd drivers
> mentioned here. ]han the two mtd drivers
> mentioned here. ]]
Hi Satyam,
The support for the platform which introduced drivers/mtd/maps/pmcmsp-ramroot.c
is being queued in the linux-mips tree at linux-mips.org. At some point it should
work it's way to the main tree and be buildable.
Marc
WARNING: multiple messages have this Message-ID (diff)
From: Marc St-Jean <Marc_St-Jean@pmc-sierra.com>
To: Satyam Sharma <satyam.sharma@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Tom Spink <tspink@gmail.com>,
Toralf F?rster <toralf.foerster@gmx.de>,
linux-kernel@vger.kernel.org,
Paolo Giarrusso <blaisorblade@yahoo.it>,
David Woodhouse <dwmw2@infradead.org>,
linux-mtd@lists.infradead.org, linux-mips@linux-mips.org,
Brian Oostenbrink <Brian_Oostenbrink@pmc-sierra.com>,
Dan Doucette <Dan_Doucette@pmc-sierra.com>
Subject: Re: build failure due to ROOT_DEV in mtd module (was Re: linux-2. 6.22-rc5-g7c8545e build #298 failed ...)
Date: Thu, 21 Jun 2007 16:06:58 -0700 [thread overview]
Message-ID: <467B0492.1080007@pmc-sierra.com> (raw)
Message-ID: <20070621230658.pQL4i-gmco2Xu8jNVnQVm1RAlLXiSyjucyafRozwrZQ@z> (raw)
> On Thu, Jun 21, 2007 at 04:13:27 EST, Satyam Sharma wrote:
> On 6/21/07, Christoph Hellwig <hch@infradead.org> wrote:
>> On Thu, Jun 21, 2007 at 12:22:01PM +0530, Satyam Sharma wrote:
>> > >> The build seems to fail because of:
>> > >> ERROR: "ROOT_DEV" [drivers/mtd/maps/nettel.ko] undefined!
>> > >>
>> > >> After taking a quick look at the code, I can't immediately see why
>> > >> this would be, since there is an include for linux/root_dev.h at the
>> > >> top, there.
>> > >>
>> > >> There's only one occurrence of ROOT_DEV (line 425), and after a quick
>> > >> look at the git history, it seems the include was originally missing,
>> > >> but was put back in, in commit
>> > >> 6cc449c7d0292cb9b993f0df84fd3225e3099492.
>>
>> Please just the reference to ROOT_DEV from this driver. Just because
>> someone builds this driver there should be no change in the default root
>> device.
>
> I agree, but this (drivers/mtd/maps/nettel.c) isn't the only modular driver
> referencing ROOT_DEV. We also have drivers/mtd/maps/pmcmsp-ramroot.c
> using ROOT_DEV (in fact the purpose of that driver seems to be precisely
> to special-case the root fs and do something with it ...) but considering
> that other driver's (tristate) Kconfig option depends on another symbol that
> is non-existent in the mainline tree, there is no way someone can build
> pmcmsp-ramroot and so we'll never actually hit that problem even with an
> allmodconfig build.
>
> Anyway, I'll leave this up to David / linux-mtd to sort out. [ No other
> modular user of ROOT_DEV in the tree other than the two mtd drivers
> mentioned here. ]han the two mtd drivers
> mentioned here. ]]
Hi Satyam,
The support for the platform which introduced drivers/mtd/maps/pmcmsp-ramroot.c
is being queued in the linux-mips tree at linux-mips.org. At some point it should
work it's way to the main tree and be buildable.
Marc
next reply other threads:[~2007-06-21 23:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-21 23:06 Marc St-Jean [this message]
2007-06-21 23:06 ` build failure due to ROOT_DEV in mtd module (was Re: linux-2. 6.22-rc5-g7c8545e build #298 failed ...) Marc St-Jean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=467B0492.1080007@pmc-sierra.com \
--to=marc_st-jean@pmc-sierra.com \
--cc=Brian_Oostenbrink@pmc-sierra.com \
--cc=Dan_Doucette@pmc-sierra.com \
--cc=blaisorblade@yahoo.it \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mtd@lists.infradead.org \
--cc=satyam.sharma@gmail.com \
--cc=toralf.foerster@gmx.de \
--cc=tspink@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox