* [PATCH] mips: pci: remove extraneous asterisk from top level comment of ar2315 PCI driver
[not found] <202208221854.8ASrzjKa-lkp@intel.com>
@ 2022-08-23 3:00 ` Bagas Sanjaya
2022-08-23 6:28 ` Greg KH
2022-08-23 8:06 ` Sergey Ryazanov
0 siblings, 2 replies; 4+ messages in thread
From: Bagas Sanjaya @ 2022-08-23 3:00 UTC (permalink / raw)
To: linux-doc, linux-mips, linux-kernel
Cc: Thomas Bogendoerfer, Rikard Falkeborn, Sergey Ryazanov,
Ralf Baechle, Jonathan Corbet, Aditya Srivastava, Bagas Sanjaya,
kernel test robot, stable
kernel test robot reported kernel-doc warning:
arch/mips/pci/pci-ar2315.c:6: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
* Both AR2315 and AR2316 chips have PCI interface unit, which supports DMA
The warning above is caused by an extraneous asterisk on the top level
(description) comment of pci-ar2315.c, for which the comment is confused as
kernel-doc comment instead.
Remove the asterisk.
Link: https://lore.kernel.org/linux-doc/202208221854.8ASrzjKa-lkp@intel.com/
Fixes: 3ed7a2a702dc0f ("MIPS: ath25: add AR2315 PCI host controller driver")
Fixes: 3e58e839150db0 ("scripts: kernel-doc: add warning for comment not following kernel-doc syntax")
Reported-by: kernel test robot <lkp@intel.com>
Cc: stable@vger.kernel.org # v5.15, v5.19
Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
---
The second Fixes: commit exposes the kernel-doc warning, which the
culprit is actually the first Fixes: commit, so it make sense to apply
this patch to supported stable branches after the second commit one.
arch/mips/pci/pci-ar2315.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips/pci/pci-ar2315.c b/arch/mips/pci/pci-ar2315.c
index 30e0922f4ceaec..e17d862cfa4c6a 100644
--- a/arch/mips/pci/pci-ar2315.c
+++ b/arch/mips/pci/pci-ar2315.c
@@ -2,7 +2,7 @@
/*
*/
-/**
+/*
* Both AR2315 and AR2316 chips have PCI interface unit, which supports DMA
* and interrupt. PCI interface supports MMIO access method, but does not
* seem to support I/O ports.
base-commit: 072e51356cd5a4a1c12c1020bc054c99b98333df
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mips: pci: remove extraneous asterisk from top level comment of ar2315 PCI driver
2022-08-23 3:00 ` [PATCH] mips: pci: remove extraneous asterisk from top level comment of ar2315 PCI driver Bagas Sanjaya
@ 2022-08-23 6:28 ` Greg KH
2022-08-23 7:55 ` Bagas Sanjaya
2022-08-23 8:06 ` Sergey Ryazanov
1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2022-08-23 6:28 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: linux-doc, linux-mips, linux-kernel, Thomas Bogendoerfer,
Rikard Falkeborn, Sergey Ryazanov, Ralf Baechle, Jonathan Corbet,
Aditya Srivastava, kernel test robot, stable
On Tue, Aug 23, 2022 at 10:00:56AM +0700, Bagas Sanjaya wrote:
> kernel test robot reported kernel-doc warning:
>
> arch/mips/pci/pci-ar2315.c:6: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Both AR2315 and AR2316 chips have PCI interface unit, which supports DMA
>
> The warning above is caused by an extraneous asterisk on the top level
> (description) comment of pci-ar2315.c, for which the comment is confused as
> kernel-doc comment instead.
>
> Remove the asterisk.
>
> Link: https://lore.kernel.org/linux-doc/202208221854.8ASrzjKa-lkp@intel.com/
> Fixes: 3ed7a2a702dc0f ("MIPS: ath25: add AR2315 PCI host controller driver")
> Fixes: 3e58e839150db0 ("scripts: kernel-doc: add warning for comment not following kernel-doc syntax")
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: stable@vger.kernel.org # v5.15, v5.19
kerneldoc issues are not stable worth, sorry.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mips: pci: remove extraneous asterisk from top level comment of ar2315 PCI driver
2022-08-23 6:28 ` Greg KH
@ 2022-08-23 7:55 ` Bagas Sanjaya
0 siblings, 0 replies; 4+ messages in thread
From: Bagas Sanjaya @ 2022-08-23 7:55 UTC (permalink / raw)
To: Greg KH
Cc: linux-doc, linux-mips, linux-kernel, Thomas Bogendoerfer,
Rikard Falkeborn, Sergey Ryazanov, Ralf Baechle, Jonathan Corbet,
Aditya Srivastava, kernel test robot, stable
On 8/23/22 13:28, Greg KH wrote:
> On Tue, Aug 23, 2022 at 10:00:56AM +0700, Bagas Sanjaya wrote:
>> kernel test robot reported kernel-doc warning:
>>
>> arch/mips/pci/pci-ar2315.c:6: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
>> * Both AR2315 and AR2316 chips have PCI interface unit, which supports DMA
>>
>> The warning above is caused by an extraneous asterisk on the top level
>> (description) comment of pci-ar2315.c, for which the comment is confused as
>> kernel-doc comment instead.
>>
>> Remove the asterisk.
>>
>> Link: https://lore.kernel.org/linux-doc/202208221854.8ASrzjKa-lkp@intel.com/
>> Fixes: 3ed7a2a702dc0f ("MIPS: ath25: add AR2315 PCI host controller driver")
>> Fixes: 3e58e839150db0 ("scripts: kernel-doc: add warning for comment not following kernel-doc syntax")
>> Reported-by: kernel test robot <lkp@intel.com>
>> Cc: stable@vger.kernel.org # v5.15, v5.19
>
> kerneldoc issues are not stable worth, sorry.
>
Thanks for reminding me. Should I resend without Cc stable?
--
An old man doll... just what I always wanted! - Clara
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mips: pci: remove extraneous asterisk from top level comment of ar2315 PCI driver
2022-08-23 3:00 ` [PATCH] mips: pci: remove extraneous asterisk from top level comment of ar2315 PCI driver Bagas Sanjaya
2022-08-23 6:28 ` Greg KH
@ 2022-08-23 8:06 ` Sergey Ryazanov
1 sibling, 0 replies; 4+ messages in thread
From: Sergey Ryazanov @ 2022-08-23 8:06 UTC (permalink / raw)
To: Bagas Sanjaya
Cc: linux-doc, linux-mips, open list, Thomas Bogendoerfer,
Rikard Falkeborn, Ralf Baechle, Jonathan Corbet,
Aditya Srivastava, kernel test robot, stable
On Tue, Aug 23, 2022 at 6:01 AM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> kernel test robot reported kernel-doc warning:
>
> arch/mips/pci/pci-ar2315.c:6: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Both AR2315 and AR2316 chips have PCI interface unit, which supports DMA
>
> The warning above is caused by an extraneous asterisk on the top level
> (description) comment of pci-ar2315.c, for which the comment is confused as
> kernel-doc comment instead.
>
> Remove the asterisk.
>
> Link: https://lore.kernel.org/linux-doc/202208221854.8ASrzjKa-lkp@intel.com/
> Fixes: 3ed7a2a702dc0f ("MIPS: ath25: add AR2315 PCI host controller driver")
> Fixes: 3e58e839150db0 ("scripts: kernel-doc: add warning for comment not following kernel-doc syntax")
> Reported-by: kernel test robot <lkp@intel.com>
> Cc: stable@vger.kernel.org # v5.15, v5.19
> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
Acked-by: Sergey Ryazanov <ryazanov.s.a@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-23 8:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <202208221854.8ASrzjKa-lkp@intel.com>
2022-08-23 3:00 ` [PATCH] mips: pci: remove extraneous asterisk from top level comment of ar2315 PCI driver Bagas Sanjaya
2022-08-23 6:28 ` Greg KH
2022-08-23 7:55 ` Bagas Sanjaya
2022-08-23 8:06 ` Sergey Ryazanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox