From: Aurelien Jarno <aurelien@aurel32.net>
To: Florian Schirmer <jolt@tuxbox.org>
Cc: Michael Buesch <mb@bu3sch.de>, Andrew Morton <akpm@osdl.org>,
linux-mips@linux-mips.org, Waldemar Brodkorb <wbx@openwrt.org>,
Felix Fietkau <nbd@openwrt.org>
Subject: Re: [PATCH -mm 2/4] MIPS: BCM947xx support (v2)
Date: Tue, 07 Aug 2007 10:05:50 +0200 [thread overview]
Message-ID: <46B827DE.4040406@aurel32.net> (raw)
In-Reply-To: <46B7851B.1050008@tuxbox.org>
Florian Schirmer a écrit :
> Hi,
>
> Aurelien Jarno wrote:
>> The patch below against 2.6.23-rc1-mm2 adds support for BCM947xx CPUs.
>> It originally comes from the OpenWrt patches.
>>
>> Cc: Michael Buesch <mb@bu3sch.de>
>> Cc: Waldemar Brodkorb <wbx@openwrt.org>
>> Cc: Felix Fietkau <nbd@openwrt.org>
>> Cc: Florian Schirmer <jolt@tuxbox.org>
>> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
>>
>
> I'm not sure whether it's a good idea to export a symbol named "ssb".
> Maybe bcm47xx_ssb would be a better name? I've no idea what the general
> rule on exporting symbols is though. Otherwise:
I don't not either, but looking in other parts of the kernel it seems it
is done the other way, ie ssb_bcm947xx would be the correct name.
I will send an updated patch.
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
next prev parent reply other threads:[~2007-08-07 8:06 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-06 15:09 [PATCH -mm 2/4] MIPS: BCM947xx support Aurelien Jarno
2007-08-06 18:05 ` Michael Buesch
2007-08-06 18:33 ` Aurelien Jarno
2007-08-06 18:37 ` Michael Buesch
2007-08-06 19:17 ` [PATCH -mm 2/4] MIPS: BCM947xx support (v2) Aurelien Jarno
2007-08-06 19:22 ` Michael Buesch
2007-08-06 20:31 ` Florian Schirmer
2007-08-07 8:05 ` Aurelien Jarno [this message]
2007-08-07 0:40 ` Yoichi Yuasa
2007-08-07 8:01 ` Aurelien Jarno
2007-08-07 8:02 ` Aurelien Jarno
2007-08-07 8:04 ` Aurelien Jarno
2007-08-07 12:16 ` [PATCH -mm 2/4] MIPS: BCM947xx support (v3) Aurelien Jarno
2007-08-08 1:33 ` Andrew Morton
2007-08-09 0:41 ` [PATCH 0/4][RFC] MIPS BCM947xx CPUs support Aurelien Jarno
2007-08-09 0:43 ` [PATCH 1/4][RFC] MIPS: Detect BCM947xx CPUs Aurelien Jarno
2007-08-09 0:44 ` [PATCH 2/4][RFC] MIPS: BCM947xx support Aurelien Jarno
2007-08-09 10:00 ` Michael Buesch
2007-08-09 10:38 ` Aurelien Jarno
2007-08-09 10:51 ` Michael Buesch
2007-08-09 11:26 ` Aurelien Jarno
2007-08-09 12:12 ` Michael Buesch
2007-08-09 0:45 ` [PATCH 3/4] RFC: Add BCM947XX to Kconfig Aurelien Jarno
2007-08-09 20:40 ` Andrew Morton
2007-08-09 0:45 ` [PATCH 4/4][RFC] MIPS: Add BCM947xx to Makefile Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B827DE.4040406@aurel32.net \
--to=aurelien@aurel32.net \
--cc=akpm@osdl.org \
--cc=jolt@tuxbox.org \
--cc=linux-mips@linux-mips.org \
--cc=mb@bu3sch.de \
--cc=nbd@openwrt.org \
--cc=wbx@openwrt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox