[PATCH] PbAu1200: fix header breakage

[PATCH] PbAu1200: fix header breakage

[Sergei Shtylyov]

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

---
Looks like nobody ever cared since the code was merged -- there's no defconfig.

 include/asm-mips/mach-pb1x00/pb1200.h |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/include/asm-mips/mach-pb1x00/pb1200.h
===================================================================
--- linux-2.6.orig/include/asm-mips/mach-pb1x00/pb1200.h
+++ linux-2.6/include/asm-mips/mach-pb1x00/pb1200.h
@@ -245,7 +245,7 @@ enum external_pb1200_ints {
 	PB1200_SD1_INSERT_INT,
 	PB1200_SD1_EJECT_INT,
 
-	PB1200_INT_END			(PB1200_INT_BEGIN + 15)
+	PB1200_INT_END		= PB1200_INT_BEGIN + 15
 };
 
 /* For drivers/pcmcia/au1000_db1x00.c */

Re: [PATCH] PbAu1200: fix header breakage

[Ralf Baechle]

On Wed, Apr 02, 2008 at 11:53:19PM +0400, Sergei Shtylyov wrote:

> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> 
> ---
> Looks like nobody ever cared since the code was merged -- there's no defconfig.

Applied, sigh.

  Ralf

Re: [PATCH] PbAu1200: fix header breakage

[Sergei Shtylyov]

Hello, I wrote:

> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> ---
> Looks like nobody ever cared since the code was merged -- there's no defconfig.

    Er, no... the breakage has been introduced by the commit 
95c4eb3ef4484ca85da5c98780d358cffd546b90 ([MIPS] Alchemy: Renumber interrupts 
so irq_cpu can work.), so thanks go to its hasty author. ;-)

WBR, Sergei

Re: [PATCH] PbAu1200: fix header breakage

[Ralf Baechle]

On Thu, Apr 03, 2008 at 04:39:34PM +0400, Sergei Shtylyov wrote:

>> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
>> ---
>> Looks like nobody ever cared since the code was merged -- there's no defconfig.
>
>    Er, no... the breakage has been introduced by the commit 
> 95c4eb3ef4484ca85da5c98780d358cffd546b90 ([MIPS] Alchemy: Renumber 
> interrupts so irq_cpu can work.), so thanks go to its hasty author. ;-)

Peple throw all sorts of MIPS kit at me but no big iron that could be
used for regular test builds.  So that sort of mistakes which to a degree
is unavoidable oftens stays hidden for too long.

  Ralf

Re: [PATCH] PbAu1200: fix header breakage

[Sergei Shtylyov]

Hello, I wrote:

> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

    Er, the boards are called Pb1x00, not PbAu1x00, so Ralf please change the 
summary before comitting (if you feel inclined :-).
    (Luckily, DBAu1200 uses its own header, so it wasn't hurt by this error.)

WBR, Sergei

Re: [PATCH] PbAu1200: fix header breakage

[Ralf Baechle]

On Thu, Apr 03, 2008 at 07:45:30PM +0400, Sergei Shtylyov wrote:

>> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
>
>    Er, the boards are called Pb1x00, not PbAu1x00, so Ralf please change 
> the summary before comitting (if you feel inclined :-).
>    (Luckily, DBAu1200 uses its own header, so it wasn't hurt by this error.)

Sorry, I already had committed the patch.  I'll fix it up in what I'm
going to send to Linus though.

  Ralf

Re: [PATCH] PbAu1200: fix header breakage

[Sergei Shtylyov]

Ralf Baechle wrote:

>>>Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

>>   Er, the boards are called Pb1x00, not PbAu1x00, so Ralf please change 
>>the summary before comitting (if you feel inclined :-).
>>   (Luckily, DBAu1200 uses its own header, so it wasn't hurt by this error.)

> Sorry, I already had committed the patch.  I'll fix it up in what I'm
> going to send to Linus though.

    Er, thanks. May I also ask you to pickup the "Make KGDB compile on UP" 
patch which I psted 2 weeks ago? :-)

>   Ralf

WBR, Sergei