From: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Adrian Bunk <bunk@kernel.org>, linux-mips@linux-mips.org
Subject: Re: [2.6 patch] malta_mtd.c: add MODULE_LICENSE
Date: Mon, 16 Jun 2008 17:34:58 +0300 [thread overview]
Message-ID: <48567A12.3050206@movial.fi> (raw)
In-Reply-To: <20080616133049.GA24056@linux-mips.org>
Ralf Baechle wrote:
> On Sun, Jun 15, 2008 at 07:13:21PM +0300, Adrian Bunk wrote:
>
>> This patch adds the missing MODULE_LICENSE("GPL").
>>
>> Reported-by: Adrian Bunk <bunk@kernel.org>
>> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> NACK. This file is only a module because 2.6.20 wouldn't build otherwise.
> That's long fixed.
Every time I come across this file I wonder whether this needs to be
modularized at all. Isn't you chainsaw itching for this as well? :)
Dmitri
>
> Ralf
>
next prev parent reply other threads:[~2008-06-16 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 16:13 [2.6 patch] malta_mtd.c: add MODULE_LICENSE Adrian Bunk
2008-06-16 13:30 ` Ralf Baechle
2008-06-16 14:34 ` Dmitri Vorobiev [this message]
2008-06-16 14:37 ` Ralf Baechle
2008-06-16 14:40 ` Dmitri Vorobiev
2008-06-17 8:52 ` Dmitri Vorobiev
2008-06-18 7:01 ` Dmitri Vorobiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48567A12.3050206@movial.fi \
--to=dmitri.vorobiev@movial.fi \
--cc=bunk@kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox