From: Dmitri Vorobiev <dmitri.vorobiev@movial.fi>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Adrian Bunk <bunk@kernel.org>, linux-mips@linux-mips.org
Subject: Re: [2.6 patch] malta_mtd.c: add MODULE_LICENSE
Date: Tue, 17 Jun 2008 11:52:38 +0300 [thread overview]
Message-ID: <48577B56.8010008@movial.fi> (raw)
In-Reply-To: <20080616143700.GA28471@linux-mips.org>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
Ralf Baechle wrote:
> On Mon, Jun 16, 2008 at 05:34:58PM +0300, Dmitri Vorobiev wrote:
>
>> Every time I come across this file I wonder whether this needs to be
>> modularized at all. Isn't you chainsaw itching for this as well? :)
>
> The reason why it was implemented as a module was that due to a MTD
> "feature" the code wouldn't compile in 2.6.20 and earlier. So yes, I
> chainsawed it into the right shape, patch is on the way to Linus.
Looks like Linus has applied the patch.
I think that module_init() needs to be replaced by device_initcall() in
malta_mtd.c. Not that it would make any difference at all, but just some
nitpicking - I simply get a bit nervous and irritated when looking at
the `module' word in the core kernel code. :)
Patch attached.
Dmitri
>
> Ralf
>
next prev parent reply other threads:[~2008-06-17 8:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-15 16:13 [2.6 patch] malta_mtd.c: add MODULE_LICENSE Adrian Bunk
2008-06-16 13:30 ` Ralf Baechle
2008-06-16 14:34 ` Dmitri Vorobiev
2008-06-16 14:37 ` Ralf Baechle
2008-06-16 14:40 ` Dmitri Vorobiev
2008-06-17 8:52 ` Dmitri Vorobiev [this message]
2008-06-18 7:01 ` Dmitri Vorobiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48577B56.8010008@movial.fi \
--to=dmitri.vorobiev@movial.fi \
--cc=bunk@kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox