[PATCH] [MIPS] change EARLY_PRINTK default to n

[PATCH] [MIPS] change EARLY_PRINTK default to n

[David Pelton]

This patch changes the default for CONFIG_EARLY_PRINTK to n.  Prior to
this change, the presence of SYS_HAS_EARLY_PRINTK would always set
EARLY_PRINTK to y if either EMBEDDED or DEBUG_KERNEL were not set.  As
this is a debugging option, it should default to n.

Signed-off-by: David Pelton <david.r.pelton@gmail.com>
---

Hi,

while fiddling with kernel configuration options for the Broadcom eval
board I am working with, I noticed that turning off DEBUG_KERNEL would
make many bad things happen.  I did not get to the root cause, but I
think that some of the early printk drivers have some dependency on
functionality enabled by DEBUG_KERNEL.  The 2.6.25.6 kernel has a
default value of "y" for EARLY_PRINTK, and this default will be applied
anytime the platform claims to support early printk.  In particular, if
DEBUG_KERNEL is not selected, there is no way to disable EARLY_PRINTK.
This patch changes the default to "n" to avoid these problems.

- David Pelton


 arch/mips/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


diff -Nraup linux-2.6.25.6-clean/arch/mips/Kconfig linux-2.6.25.6/arch/mips/Kconfig
--- linux-2.6.25.6-clean/arch/mips/Kconfig      2008-06-09 14:27:19.000000000 -0400
+++ linux-2.6.25.6/arch/mips/Kconfig    2008-06-16 14:34:33.229160000 -0400
@@ -807,7 +807,7 @@ config DMA_NEED_PCI_MAP_STATE
 config EARLY_PRINTK
        bool "Early printk" if EMBEDDED && DEBUG_KERNEL
        depends on SYS_HAS_EARLY_PRINTK
-       default y
+       default n
        help
          This option enables special console drivers which allow the kernel
          to print messages very early in the bootup process.

Re: [PATCH] [MIPS] change EARLY_PRINTK default to n

[Atsushi Nemoto]

On Mon, 16 Jun 2008 15:15:39 -0400, David Pelton <david.r.pelton@gmail.com> wrote:
> This patch changes the default for CONFIG_EARLY_PRINTK to n.  Prior to
> this change, the presence of SYS_HAS_EARLY_PRINTK would always set
> EARLY_PRINTK to y if either EMBEDDED or DEBUG_KERNEL were not set.  As
> this is a debugging option, it should default to n.
> 
> Signed-off-by: David Pelton <david.r.pelton@gmail.com>

Acked-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>

Ralf, any problem with this patch?

---
Atsushi Nemoto

Re: [PATCH] [MIPS] change EARLY_PRINTK default to n

[Atsushi Nemoto]

On Tue, 29 Jul 2008 01:26:49 +0900 (JST), Atsushi Nemoto <anemo@mba.ocn.ne.jp> wrote:
> > This patch changes the default for CONFIG_EARLY_PRINTK to n.  Prior to
> > this change, the presence of SYS_HAS_EARLY_PRINTK would always set
> > EARLY_PRINTK to y if either EMBEDDED or DEBUG_KERNEL were not set.  As
> > this is a debugging option, it should default to n.
> > 
> > Signed-off-by: David Pelton <david.r.pelton@gmail.com>
> 
> Acked-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
> 
> Ralf, any problem with this patch?

Oops, the patch cannot be applied due to tab/space issue.
But it can be fixed easily :)

---
Atsushi Nemoto