* [PATCH] Spinlock initialisation au1000_eth.c
@ 2008-07-21 9:53 Martin Gebert
0 siblings, 0 replies; only message in thread
From: Martin Gebert @ 2008-07-21 9:53 UTC (permalink / raw)
To: linux-mips
Seems like the spinlock for the AU1x00 ethernet device is initialised too
late, as it is already used in enable_mac(), which is called via
mii_probe() before the init takes place.
The attached patch is working here for a Linux Au1100 2.6.22.6 kernel,
and as far as I checked should also be applicable to the current head
(just line numbers differ).
Signed-off-by: Martin Gebert <Martin.Gebert@alpha-bit.de>
--- drivers/net/au1000_eth.c 2008-06-26 14:21:53.000000000 +0200
+++ drivers/net/au1000_eth.c 2008-06-26 14:23:00.000000000 +0200
@@ -656,6 +656,7 @@
dev->name, base, irq);
aup = dev->priv;
+ spin_lock_init(&aup->lock);
/* Allocate the data buffers */
/* Snooping works fine with eth on all au1xxx */
@@ -766,7 +767,6 @@
aup->tx_db_inuse[i] = pDB;
}
- spin_lock_init(&aup->lock);
dev->base_addr = base;
dev->irq = irq;
dev->open = au1000_open;
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2008-07-21 9:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-21 9:53 [PATCH] Spinlock initialisation au1000_eth.c Martin Gebert
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox