From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: akpm@linux-foundation.org
Cc: ralf@linux-mips.org, linux-mips@linux-mips.org,
alessandro.zummo@towertech.it, tsbogend@alpha.franken.de
Subject: Re: [patch 3/3] drivers/rtc/rtc-m48t35.c is borked too
Date: Thu, 30 Oct 2008 14:03:43 +0300 [thread overview]
Message-ID: <4909948F.3090202@ru.mvista.com> (raw)
In-Reply-To: <200810292121.m9TLLYjd019910@imap1.linux-foundation.org>
Hello.
akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
>
> drivers/rtc/rtc-m48t35.c: In function 'm48t35_read_time':
> drivers/rtc/rtc-m48t35.c:59: error: implicit declaration of function 'readb'
> drivers/rtc/rtc-m48t35.c:60: error: implicit declaration of function 'writeb'
> drivers/rtc/rtc-m48t35.c: In function 'm48t35_probe':
> drivers/rtc/rtc-m48t35.c:168: error: implicit declaration of function 'ioremap'
> drivers/rtc/rtc-m48t35.c:168: warning: assignment makes pointer from integer without a cast
> drivers/rtc/rtc-m48t35.c:188: error: implicit declaration of function 'iounmap'
>
I wonder how that's possible with the correct #include's?
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Alessandro Zummo <alessandro.zummo@towertech.it>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
[...]
> diff -puN drivers/rtc/Kconfig~drivers-rtc-rtc-m48t35c-is-borked-too drivers/rtc/Kconfig
> --- a/drivers/rtc/Kconfig~drivers-rtc-rtc-m48t35c-is-borked-too
> +++ a/drivers/rtc/Kconfig
> @@ -432,6 +432,7 @@ config RTC_DRV_M48T86
>
> config RTC_DRV_M48T35
> tristate "ST M48T35"
> + depends on MIPS
>
It shouldn't really be MIPS specific -- the patch seems wrong.
WBR, Sergei
prev parent reply other threads:[~2008-10-30 11:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 21:21 [patch 3/3] drivers/rtc/rtc-m48t35.c is borked too akpm
2008-10-29 23:19 ` Ralf Baechle
2008-10-30 11:03 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4909948F.3090202@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=akpm@linux-foundation.org \
--cc=alessandro.zummo@towertech.it \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox