* [patch 3/3] drivers/rtc/rtc-m48t35.c is borked too
@ 2008-10-29 21:21 akpm
2008-10-29 23:19 ` Ralf Baechle
2008-10-30 11:03 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: akpm @ 2008-10-29 21:21 UTC (permalink / raw)
To: ralf; +Cc: linux-mips, akpm, alessandro.zummo, tsbogend
From: Andrew Morton <akpm@linux-foundation.org>
drivers/rtc/rtc-m48t35.c: In function 'm48t35_read_time':
drivers/rtc/rtc-m48t35.c:59: error: implicit declaration of function 'readb'
drivers/rtc/rtc-m48t35.c:60: error: implicit declaration of function 'writeb'
drivers/rtc/rtc-m48t35.c: In function 'm48t35_probe':
drivers/rtc/rtc-m48t35.c:168: error: implicit declaration of function 'ioremap'
drivers/rtc/rtc-m48t35.c:168: warning: assignment makes pointer from integer without a cast
drivers/rtc/rtc-m48t35.c:188: error: implicit declaration of function 'iounmap'
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Alessandro Zummo <alessandro.zummo@towertech.it>
Cc: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
drivers/rtc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff -puN drivers/rtc/Kconfig~drivers-rtc-rtc-m48t35c-is-borked-too drivers/rtc/Kconfig
--- a/drivers/rtc/Kconfig~drivers-rtc-rtc-m48t35c-is-borked-too
+++ a/drivers/rtc/Kconfig
@@ -432,6 +432,7 @@ config RTC_DRV_M48T86
config RTC_DRV_M48T35
tristate "ST M48T35"
+ depends on MIPS
help
If you say Y here you will get support for the
ST M48T35 RTC chip.
_
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 3/3] drivers/rtc/rtc-m48t35.c is borked too
2008-10-29 21:21 [patch 3/3] drivers/rtc/rtc-m48t35.c is borked too akpm
@ 2008-10-29 23:19 ` Ralf Baechle
2008-10-30 11:03 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Ralf Baechle @ 2008-10-29 23:19 UTC (permalink / raw)
To: akpm; +Cc: linux-mips, alessandro.zummo, tsbogend
On Wed, Oct 29, 2008 at 02:21:34PM -0700, akpm@linux-foundation.org wrote:
> Subject: [patch 3/3] drivers/rtc/rtc-m48t35.c is borked too
>
> From: Andrew Morton <akpm@linux-foundation.org>
>
> drivers/rtc/rtc-m48t35.c: In function 'm48t35_read_time':
> drivers/rtc/rtc-m48t35.c:59: error: implicit declaration of function 'readb'
> drivers/rtc/rtc-m48t35.c:60: error: implicit declaration of function 'writeb'
> drivers/rtc/rtc-m48t35.c: In function 'm48t35_probe':
> drivers/rtc/rtc-m48t35.c:168: error: implicit declaration of function 'ioremap'
> drivers/rtc/rtc-m48t35.c:168: warning: assignment makes pointer from integer without a cast
> drivers/rtc/rtc-m48t35.c:188: error: implicit declaration of function 'iounmap'
Same for this one; commit ID d7a6119f457f48a94985fdbdc400cbb03e136a76 should
have solved this one also.
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 3/3] drivers/rtc/rtc-m48t35.c is borked too
2008-10-29 21:21 [patch 3/3] drivers/rtc/rtc-m48t35.c is borked too akpm
2008-10-29 23:19 ` Ralf Baechle
@ 2008-10-30 11:03 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2008-10-30 11:03 UTC (permalink / raw)
To: akpm; +Cc: ralf, linux-mips, alessandro.zummo, tsbogend
Hello.
akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
>
> drivers/rtc/rtc-m48t35.c: In function 'm48t35_read_time':
> drivers/rtc/rtc-m48t35.c:59: error: implicit declaration of function 'readb'
> drivers/rtc/rtc-m48t35.c:60: error: implicit declaration of function 'writeb'
> drivers/rtc/rtc-m48t35.c: In function 'm48t35_probe':
> drivers/rtc/rtc-m48t35.c:168: error: implicit declaration of function 'ioremap'
> drivers/rtc/rtc-m48t35.c:168: warning: assignment makes pointer from integer without a cast
> drivers/rtc/rtc-m48t35.c:188: error: implicit declaration of function 'iounmap'
>
I wonder how that's possible with the correct #include's?
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Alessandro Zummo <alessandro.zummo@towertech.it>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
>
[...]
> diff -puN drivers/rtc/Kconfig~drivers-rtc-rtc-m48t35c-is-borked-too drivers/rtc/Kconfig
> --- a/drivers/rtc/Kconfig~drivers-rtc-rtc-m48t35c-is-borked-too
> +++ a/drivers/rtc/Kconfig
> @@ -432,6 +432,7 @@ config RTC_DRV_M48T86
>
> config RTC_DRV_M48T35
> tristate "ST M48T35"
> + depends on MIPS
>
It shouldn't really be MIPS specific -- the patch seems wrong.
WBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-30 11:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-29 21:21 [patch 3/3] drivers/rtc/rtc-m48t35.c is borked too akpm
2008-10-29 23:19 ` Ralf Baechle
2008-10-30 11:03 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox