From: Kumba <kumba@gentoo.org>
To: James Perkins <james@loowit.net>
Cc: libc-ports@sources.redhat.com, Daniel Jacobowitz <drow@false.org>,
Linux MIPS List <linux-mips@linux-mips.org>
Subject: Re: [PATCH]: R10000 Needs LL/SC Workaround in Glibc
Date: Tue, 04 Nov 2008 02:16:52 -0500 [thread overview]
Message-ID: <490FF6E4.9000300@gentoo.org> (raw)
In-Reply-To: <490C907A.40005@loowit.net>
James Perkins wrote:
> "move %1,%3\n\t" \
> "sc %1,%4\n\t" \
> - "beqz %1,1b\n" \
> + R10K_BEQZ_INSN \
> acq "\n\t" \
> ".set pop\n" \
>
> Is it possible to leave the parameters in the inline code and
> remove them from the macro definition? I feel the code is more
> readable without having to refer to the macro definition if
> the parameters are left in place.
Makes sense, I'll keep this in mind for the next patch revision I make.
--
Joshua Kinard
Gentoo/MIPS
kumba@gentoo.org
"The past tempts us, the present confuses us, the future frightens us. And our
lives slip away, moment by moment, lost in that vast, terrible in-between."
--Emperor Turhan, Centauri Republic
next prev parent reply other threads:[~2008-11-04 7:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 5:01 [PATCH]: R10000 Needs LL/SC Workaround in Glibc Kumba
2008-11-01 7:33 ` Kumba
2008-11-01 11:26 ` Ralf Baechle
2008-11-04 7:16 ` Kumba
2008-11-01 17:23 ` James Perkins
2008-11-04 7:16 ` Kumba [this message]
2008-11-23 4:16 ` Kumba
2009-01-27 15:29 ` Daniel Jacobowitz
2009-01-27 16:13 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=490FF6E4.9000300@gentoo.org \
--to=kumba@gentoo.org \
--cc=drow@false.org \
--cc=james@loowit.net \
--cc=libc-ports@sources.redhat.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox