Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] Don't use ttyS* serial device name for board specific PNX8XXX UART serial
Date: Thu, 15 Jan 2009 01:04:14 +0300	[thread overview]
Message-ID: <496E615E.9060006@ru.mvista.com> (raw)
In-Reply-To: <1231943742.8457.6.camel@EPBYMINW0568>

Hello.

Ihar Hrachyshka wrote:
> I think that's a better solution for the problem I said so please commit
> this patch rather previous one...
>   

   Such comments are to be placed after --- tearline. Using several such 
tearlines makes it harder to apply your patch...
   And why do you expect the MIPS maintainer to commit a patch to the 
serial driver? Such patches should be addressed to 
linux-serial@vger.kernel.org and (most probably) Alan Cox...

> ---
>
> Don't use ttyS[0-1] serial device name for board specific PNX8XXX UART
> serial. Rather create ttyPNX[0-1]. Also changed minor number to be
> different with sa1100 serial driver one.
>
> Signed-off-by: Ihar Hrachyshka <ihar.hrachyshka@gmail.com>
>   
[...]
> diff --git a/drivers/serial/pnx8xxx_uart.c b/drivers/serial/pnx8xxx_uart.c
> index 22e30d2..96870f1 100644
> --- a/drivers/serial/pnx8xxx_uart.c
> +++ b/drivers/serial/pnx8xxx_uart.c
> @@ -34,9 +34,8 @@
>  #include <asm/io.h>
>  #include <asm/irq.h>
>  
> -/* We'll be using StrongARM sa1100 serial port major/minor */
>  #define SERIAL_PNX8XXX_MAJOR	204
> -#define MINOR_START		5
> +#define MINOR_START		96
>   

   This major-minor pair is reserved for the Altix serial cards. Have 
you tried registering the minor on http://www.lanana.org

WBR, Sergei

  reply	other threads:[~2009-01-14 22:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-14 14:35 [PATCH] Don't use ttyS* serial device name for board specific PNX8XXX UART serial Ihar Hrachyshka
2009-01-14 22:04 ` Sergei Shtylyov [this message]
2009-01-14 22:20   ` Ihar Hrachyshka
2009-01-14 22:20     ` Ihar Hrachyshka
  -- strict thread matches above, loose matches on Subject: below --
2009-01-14 13:55 Ihar Hrachyshka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496E615E.9060006@ru.mvista.com \
    --to=sshtylyov@ru.mvista.com \
    --cc=ihar.hrachyshka@gmail.com \
    --cc=linux-mips@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox