[PATCH] MIPS: Loongson: irq.c: Misc cleanups

[PATCH] MIPS: Loongson: irq.c: Misc cleanups

[Shinya Kuribayashi]

* Remove unnecessary 'if (int_status & (1 <<10))' statement
* s/if (foo != 0)/if (foo)/
* Remove unused 'inst_status &= ~(1 << i);' line

Signed-off-by: Shinya Kuribayashi <skuribay@pobox.com>
---
 Noticed while I'm reworking on interrupt code for EMMA2RH.
 This is not for inclusion, but just for letting Wu-san know.

 arch/mips/loongson/common/irq.c |   11 ++++-------
 1 files changed, 4 insertions(+), 7 deletions(-)

diff --git a/arch/mips/loongson/common/irq.c b/arch/mips/loongson/common/irq.c
index 20e7328..25a11df 100644
--- a/arch/mips/loongson/common/irq.c
+++ b/arch/mips/loongson/common/irq.c
@@ -21,19 +21,16 @@ void bonito_irqdispatch(void)
 
 	/* workaround the IO dma problem: let cpu looping to allow DMA finish */
 	int_status = LOONGSON_INTISR;
-	if (int_status & (1 << 10)) {
-		while (int_status & (1 << 10)) {
-			udelay(1);
-			int_status = LOONGSON_INTISR;
-		}
+	while (int_status & (1 << 10)) {
+		udelay(1);
+		int_status = LOONGSON_INTISR;
 	}
 
 	/* Get pending sources, masked by current enables */
 	int_status = LOONGSON_INTISR & LOONGSON_INTEN;
 
-	if (int_status != 0) {
+	if (int_status) {
 		i = __ffs(int_status);
-		int_status &= ~(1 << i);
 		do_IRQ(LOONGSON_IRQ_BASE + i);
 	}
 }
-- 
1.7.1

Re: [PATCH] MIPS: Loongson: irq.c: Misc cleanups

[wu zhangjin]

Hi,

Looks find to me, thanks!

Acked-by: Wu Zhangjin <wuzhangjin@gmail.com>

On Sun, Jun 27, 2010 at 9:52 PM, Shinya Kuribayashi <skuribay@pobox.com> wrote:
> * Remove unnecessary 'if (int_status & (1 <<10))' statement
> * s/if (foo != 0)/if (foo)/
> * Remove unused 'inst_status &= ~(1 << i);' line
>
> Signed-off-by: Shinya Kuribayashi <skuribay@pobox.com>
> ---
>  Noticed while I'm reworking on interrupt code for EMMA2RH.
>  This is not for inclusion, but just for letting Wu-san know.
>
>  arch/mips/loongson/common/irq.c |   11 ++++-------
>  1 files changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/arch/mips/loongson/common/irq.c b/arch/mips/loongson/common/irq.c
> index 20e7328..25a11df 100644
> --- a/arch/mips/loongson/common/irq.c
> +++ b/arch/mips/loongson/common/irq.c
> @@ -21,19 +21,16 @@ void bonito_irqdispatch(void)
>
>        /* workaround the IO dma problem: let cpu looping to allow DMA finish */
>        int_status = LOONGSON_INTISR;
> -       if (int_status & (1 << 10)) {
> -               while (int_status & (1 << 10)) {
> -                       udelay(1);
> -                       int_status = LOONGSON_INTISR;
> -               }
> +       while (int_status & (1 << 10)) {
> +               udelay(1);
> +               int_status = LOONGSON_INTISR;
>        }
>
>        /* Get pending sources, masked by current enables */
>        int_status = LOONGSON_INTISR & LOONGSON_INTEN;
>
> -       if (int_status != 0) {
> +       if (int_status) {
>                i = __ffs(int_status);
> -               int_status &= ~(1 << i);
>                do_IRQ(LOONGSON_IRQ_BASE + i);
>        }
>  }
> --
> 1.7.1
>
>