* [PATCH] MIPS: Octeon: Kconfig: fix helper dependency
@ 2011-02-17 14:28 Antony Pavlov
2011-02-17 18:01 ` David Daney
0 siblings, 1 reply; 2+ messages in thread
From: Antony Pavlov @ 2011-02-17 14:28 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips, Antony Pavlov
The option CAVIUM_OCTEON_HELPER does not depend
on CPU_CAVIUM_OCTEON option.
So my .config file for MIPS Malta board contains
CONFIG_MIPS_MALTA=y
...
# CONFIG_CAVIUM_OCTEON_SIMULATOR is not set
# CONFIG_CAVIUM_OCTEON_REFERENCE_BOARD is not set
...
CONFIG_CAVIUM_OCTEON_HELPER=y
Signed-off-by: Antony Pavlov <antonynpavlov@gmail.com>
---
arch/mips/cavium-octeon/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/cavium-octeon/Kconfig b/arch/mips/cavium-octeon/Kconfig
index caae228..a6a2f3c 100644
--- a/arch/mips/cavium-octeon/Kconfig
+++ b/arch/mips/cavium-octeon/Kconfig
@@ -97,7 +97,7 @@ config ARCH_SPARSEMEM_ENABLE
config CAVIUM_OCTEON_HELPER
def_bool y
- depends on OCTEON_ETHERNET || PCI
+ depends on CPU_CAVIUM_OCTEON && (OCTEON_ETHERNET || PCI)
config IOMMU_HELPER
bool
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: Octeon: Kconfig: fix helper dependency
2011-02-17 14:28 [PATCH] MIPS: Octeon: Kconfig: fix helper dependency Antony Pavlov
@ 2011-02-17 18:01 ` David Daney
0 siblings, 0 replies; 2+ messages in thread
From: David Daney @ 2011-02-17 18:01 UTC (permalink / raw)
To: Antony Pavlov; +Cc: Ralf Baechle, linux-mips
On 02/17/2011 06:28 AM, Antony Pavlov wrote:
> The option CAVIUM_OCTEON_HELPER does not depend
> on CPU_CAVIUM_OCTEON option.
> So my .config file for MIPS Malta board contains
>
> CONFIG_MIPS_MALTA=y
> ...
> # CONFIG_CAVIUM_OCTEON_SIMULATOR is not set
> # CONFIG_CAVIUM_OCTEON_REFERENCE_BOARD is not set
> ...
> CONFIG_CAVIUM_OCTEON_HELPER=y
>
> Signed-off-by: Antony Pavlov<antonynpavlov@gmail.com>
NAK.
I have a patch that takes a different approach.
David Daney
> ---
> arch/mips/cavium-octeon/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/Kconfig b/arch/mips/cavium-octeon/Kconfig
> index caae228..a6a2f3c 100644
> --- a/arch/mips/cavium-octeon/Kconfig
> +++ b/arch/mips/cavium-octeon/Kconfig
> @@ -97,7 +97,7 @@ config ARCH_SPARSEMEM_ENABLE
>
> config CAVIUM_OCTEON_HELPER
> def_bool y
> - depends on OCTEON_ETHERNET || PCI
> + depends on CPU_CAVIUM_OCTEON&& (OCTEON_ETHERNET || PCI)
>
> config IOMMU_HELPER
> bool
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-17 18:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-17 14:28 [PATCH] MIPS: Octeon: Kconfig: fix helper dependency Antony Pavlov
2011-02-17 18:01 ` David Daney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox