* Re: [PATCH] Kbuild: append missing-syscalls to the default target list [not found] ` <20111101232233.GA32441@sepie.suse.cz> @ 2011-11-07 20:44 ` Ralf Baechle 2011-11-07 21:19 ` Michal Marek 0 siblings, 1 reply; 10+ messages in thread From: Ralf Baechle @ 2011-11-07 20:44 UTC (permalink / raw) To: Michal Marek Cc: Arnaud Lacombe, linux-kbuild, linux-kernel, linux-mips, David Daney On Wed, Nov 02, 2011 at 12:22:33AM +0100, Michal Marek wrote: > On Wed, Sep 14, 2011 at 01:17:10AM -0400, Arnaud Lacombe wrote: > > 2011/9/9 Michal Marek <mmarek@suse.cz>: > > > On 25.8.2011 03:03, Arnaud Lacombe wrote: > > >> +always += missing-syscalls > > >> +targets += missing-syscalls > > >> + > > >> quiet_cmd_syscalls = CALL $< > > >> cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) > > > > > > checksyscalls.sh needs to depend on generated/asm-offsets.h, otherwise a > > > parallel build will fail. > > > > > true. > > > > This: > > > > diff --git a/Kbuild b/Kbuild > > index 1a2eb32..4caab4f 100644 > > --- a/Kbuild > > +++ b/Kbuild > > @@ -94,7 +94,7 @@ targets += missing-syscalls > > quiet_cmd_syscalls = CALL $< > > cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) > > > > -missing-syscalls: scripts/checksyscalls.sh FORCE > > +missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE > > $(call cmd,syscalls) > > OK, applied to kbuild/kbuild with this fixup. 5f7efb4c6da9f90cb306923ced2a6494d065a595 breaks 64-bit MIPS builds that have 32-bit binary compatibility enabled, for example ip27_defconfig or cavium-octeon_defconfig: CC arch/mips/kernel/asm-offsets.s In file included from include/linux/bitops.h:22:0, from include/linux/kernel.h:17, from include/linux/cache.h:4, from include/linux/time.h:7, from include/linux/stat.h:60, from include/linux/compat.h:10, from arch/mips/kernel/asm-offsets.c:11: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h: In function ‘__fls’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:570:2: warning: left shift count >= width of type [enabled by default] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:572:3: warning: left shift count >= width of type [enabled by default] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:575:2: warning: left shift count >= width of type [enabled by default] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:579:2: warning: left shift count >= width of type [enabled by default] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:583:2: warning: left shift count >= width of type [enabled by default] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:587:2: warning: left shift count >= width of type [enabled by default] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:591:2: warning: left shift count >= width of type [enabled by default] In file included from /home/ralf/src/linux/linux-mips/arch/mips/include/asm/page.h:46:0, from /home/ralf/src/linux/linux-mips/arch/mips/include/asm/compat.h:8, from include/linux/compat.h:18, from arch/mips/kernel/asm-offsets.c:11: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘phys_to_virt’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:136:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘isa_bus_to_virt’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:149:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘outq’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘inq’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘outq_p’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘inq_p’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘__mem_outq’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘__mem_inq’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘__mem_outq_p’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘__mem_inq_p’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:444:1: error: size of unnamed array is negative In file included from /home/ralf/src/linux/linux-mips/arch/mips/include/asm/pgtable.h:15:0, from include/linux/mm.h:42, from arch/mips/kernel/asm-offsets.c:14: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/pgtable-64.h: In function ‘mk_swap_pte’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/pgtable-64.h:273:1: warning: left shift count >= width of type [enabled by default] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/pgtable-64.h:273:1: warning: left shift count >= width of type [enabled by default] In file included from arch/mips/kernel/asm-offsets.c:14:0: include/linux/mm.h: In function ‘virt_to_head_page’: include/linux/mm.h:393:9: warning: right shift count >= width of type [enabled by default] In file included from arch/mips/kernel/asm-offsets.c:14:0: include/linux/mm.h: In function ‘lowmem_page_address’: include/linux/mm.h:723:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] make[1]: *** [arch/mips/kernel/asm-offsets.s] Error 1 make: *** [archprepare] Error 2 Not yet sure what the fix should be. Ralf ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Kbuild: append missing-syscalls to the default target list 2011-11-07 20:44 ` [PATCH] Kbuild: append missing-syscalls to the default target list Ralf Baechle @ 2011-11-07 21:19 ` Michal Marek 2011-11-07 23:33 ` Ralf Baechle 0 siblings, 1 reply; 10+ messages in thread From: Michal Marek @ 2011-11-07 21:19 UTC (permalink / raw) To: Ralf Baechle Cc: Arnaud Lacombe, linux-kbuild, linux-kernel, linux-mips, David Daney On Mon, Nov 07, 2011 at 08:44:49PM +0000, Ralf Baechle wrote: > 5f7efb4c6da9f90cb306923ced2a6494d065a595 breaks 64-bit MIPS builds that > have 32-bit binary compatibility enabled, for example ip27_defconfig > or cavium-octeon_defconfig: > > CC arch/mips/kernel/asm-offsets.s > In file included from include/linux/bitops.h:22:0, > from include/linux/kernel.h:17, > from include/linux/cache.h:4, > from include/linux/time.h:7, > from include/linux/stat.h:60, > from include/linux/compat.h:10, > from arch/mips/kernel/asm-offsets.c:11: Wild guess - does this patch help? diff --git a/Kbuild b/Kbuild index 4caab4f..77c191a 100644 --- a/Kbuild +++ b/Kbuild @@ -94,7 +94,7 @@ targets += missing-syscalls quiet_cmd_syscalls = CALL $< cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) -missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE +missing-syscalls: scripts/checksyscalls.sh $(offsets-file) $(bounds-file) FORCE $(call cmd,syscalls) # Keep these two files during make clean If not, please attach logs of make V=1 with clean Linus' tree and with 5f7efb4c6da9f90cb306923ced2a6494d065a595 reverted. Michal ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] Kbuild: append missing-syscalls to the default target list 2011-11-07 21:19 ` Michal Marek @ 2011-11-07 23:33 ` Ralf Baechle 2011-11-08 8:25 ` Michal Marek 0 siblings, 1 reply; 10+ messages in thread From: Ralf Baechle @ 2011-11-07 23:33 UTC (permalink / raw) To: Michal Marek Cc: Arnaud Lacombe, linux-kbuild, linux-kernel, linux-mips, David Daney On Mon, Nov 07, 2011 at 10:19:00PM +0100, Michal Marek wrote: > Wild guess - does this patch help? > > > diff --git a/Kbuild b/Kbuild > index 4caab4f..77c191a 100644 > --- a/Kbuild > +++ b/Kbuild > @@ -94,7 +94,7 @@ targets += missing-syscalls > quiet_cmd_syscalls = CALL $< > cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) > > -missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE > +missing-syscalls: scripts/checksyscalls.sh $(offsets-file) $(bounds-file) FORCE > $(call cmd,syscalls) > > # Keep these two files during make clean No, it didn't. > If not, please attach logs of make V=1 with clean Linus' tree and with > 5f7efb4c6da9f90cb306923ced2a6494d065a595 reverted. $ git checkout 31555213f03bca37d2c02e10946296052f4ecfcd $ git revert 5f7efb4c6da9f90cb306923ced2a6494d065a595 $ make ARCH=mips ip27_defconfig $ make ARCH=mips V=1 2>&1 | tee log make -f /home/ralf/src/linux/linux-mips/Makefile silentoldconfig make -f scripts/Makefile.build obj=scripts/basic rm -f .tmp_quiet_recordmcount mkdir -p include/linux include/config make -f scripts/Makefile.build obj=scripts/kconfig silentoldconfig mkdir -p include/generated scripts/kconfig/conf --silentoldconfig Kconfig warning: (AX88796_93CX6 && RTL8180 && RTL8187 && ADM8211 && RT2400PCI && RT2500PCI && RT61PCI && RT2800PCI && R8187SE) selects EEPROM_93CX6 which has unmet direct dependencies (MISC_DEVICES) warning: (AX88796_93CX6 && RTL8180 && RTL8187 && ADM8211 && RT2400PCI && RT2500PCI && RT61PCI && RT2800PCI && R8187SE) selects EEPROM_93CX6 which has unmet direct dependencies (MISC_DEVICES) rm -f include/config/kernel.release echo "3.1.0$(/bin/sh /home/ralf/src/linux/linux-mips/scripts/setlocalversion /home/ralf/src/linux/linux-mips)" > include/config/kernel.release make -f /home/ralf/src/linux/linux-mips/scripts/Makefile.asm-generic \ obj=arch/mips/include/generated/asm set -e; : ' CHK include/linux/version.h'; mkdir -p include/linux/; (echo \#define LINUX_VERSION_CODE 196864; echo '#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))';) < /home/ralf/src/linux/linux-mips/Makefile > include/linux/version.h.tmp; if [ -r include/linux/version.h ] && cmp -s include/linux/version.h include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else : ' UPD include/linux/version.h'; mv -f include/linux/version.h.tmp include/linux/version.h; fi set -e; : ' CHK include/generated/utsrelease.h'; mkdir -p include/generated/; if [ `echo -n "3.1.0-10325-g3155521-dirty" | wc -c ` -gt 64 ]; then echo '"3.1.0-10325-g3155521-dirty" exceeds 64 characters' >&2; exit 1; fi; (echo \#define UTS_RELEASE \"3.1.0-10325-g3155521-dirty\";) < include/config/kernel.release > include/generated/utsrelease.h.tmp; if [ -r include/generated/utsrelease.h ] && cmp -s include/generated/utsrelease.h include/generated/utsrelease.h.tmp; then rm -f include/generated/utsrelease.h.tmp; else : ' UPD include/generated/utsrelease.h'; mv -f include/generated/utsrelease.h.tmp include/generated/utsrelease.h; fi mkdir -p .tmp_versions ; rm -f .tmp_versions/* make -f scripts/Makefile.build obj=scripts/basic (cat /dev/null; ) > scripts/basic/modules.order rm -f .tmp_quiet_recordmcount Checking missing-syscalls for N32 make -f scripts/Makefile.build obj=. missing-syscalls ccflags-y="-mabi=n32" /bin/sh scripts/checksyscalls.sh mips64-linux-gcc -Wp,-MD,./.missing-syscalls.d -nostdinc -isystem /usr/lib64/gcc/mips64-linux/4.6.0/include -I/home/ralf/src/linux/linux-mips/arch/mips/include -Iarch/mips/include/generated -Iinclude -include /home/ralf/src/linux/linux-mips/include/linux/kconfig.h -D__KERNEL__ -D"VMLINUX_LOAD_ADDRESS=0xa80000000001c000" -D"DATAOFFSET=0" -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -fno-delete-null-pointer-checks -O2 -mno-check-zero-division -mabi=64 -G 0 -mno-abicalls -fno-pic -pipe -msoft-float -ffreestanding -march=r10000 -Wa,--trap -I/home/ralf/src/linux/linux-mips/arch/mips/include/asm/mach-ip27 -I/home/ralf/src/linux/linux-mips/arch/mips/include/asm/mach-generic -Wframe-larger-than=2048 -fno-stack-protector -Wno-unused-but-set-variable -fomit-frame-pointer -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fconserve-stack -DCC_HAVE_ASM_GOTO -mabi=n32 -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(missing_syscalls)" -D"KBUILD_MODNAME=KBUILD_STR(missing_syscalls)" <stdin>:1562:2: warning: #warning syscall process_vm_readv not implemented [-Wcpp] <stdin>:1566:2: warning: #warning syscall process_vm_writev not implemented [-Wcpp] Checking missing-syscalls for O32 make -f scripts/Makefile.build obj=. missing-syscalls ccflags-y="-mabi=32" /bin/sh scripts/checksyscalls.sh mips64-linux-gcc -Wp,-MD,./.missing-syscalls.d -nostdinc -isystem /usr/lib64/gcc/mips64-linux/4.6.0/include -I/home/ralf/src/linux/linux-mips/arch/mips/include -Iarch/mips/include/generated -Iinclude -include /home/ralf/src/linux/linux-mips/include/linux/kconfig.h -D__KERNEL__ -D"VMLINUX_LOAD_ADDRESS=0xa80000000001c000" -D"DATAOFFSET=0" -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -fno-delete-null-pointer-checks -O2 -mno-check-zero-division -mabi=64 -G 0 -mno-abicalls -fno-pic -pipe -msoft-float -ffreestanding -march=r10000 -Wa,--trap -I/home/ralf/src/linux/linux-mips/arch/mips/include/asm/mach-ip27 -I/home/ralf/src/linux/linux-mips/arch/mips/include/asm/mach-generic -Wframe-larger-than=2048 -fno-stack-protector -Wno-unused-but-set-variable -fomit-frame-pointer -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fconserve-stack -DCC_HAVE_ASM_GOTO -mabi=32 -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(missing_syscalls)" -D"KBUILD_MODNAME=KBUILD_STR(missing_syscalls)" <stdin>:1562:2: warning: #warning syscall process_vm_readv not implemented [-Wcpp] <stdin>:1566:2: warning: #warning syscall process_vm_writev not implemented [-Wcpp] make -f scripts/Makefile.build obj=. (cat /dev/null; ) > modules.order mkdir -p kernel/ mips64-linux-gcc -Wp,-MD,kernel/.bounds.s.d -nostdinc -isystem /usr/lib64/gcc/mips64-linux/4.6.0/include -I/home/ralf/src/linux/linux-mips/arch/mips/include -Iarch/mips/include/generated -Iinclude -include /home/ralf/src/linux/linux-mips/include/linux/kconfig.h -D__KERNEL__ -D"VMLINUX_LOAD_ADDRESS=0xa80000000001c000" -D"DATAOFFSET=0" -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -fno-delete-null-pointer-checks -O2 -mno-check-zero-division -mabi=64 -G 0 -mno-abicalls -fno-pic -pipe -msoft-float -ffreestanding -march=r10000 -Wa,--trap -I/home/ralf/src/linux/linux-mips/arch/mips/include/asm/mach-ip27 -I/home/ralf/src/linux/linux-mips/arch/mips/include/asm/mach-generic -Wframe-larger-than=2048 -fno-stack-protector -Wno-unused-but-set-variable -fomit-frame-pointer -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fconserve-stack -DCC_HAVE_ASM_GOTO -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(bounds)" -D"KBUILD_MODNAME=KBUILD_STR(bounds)" -fverbose-asm -S -o kernel/bounds.s kernel/bounds.c mkdir -p include/generated/ (set -e; echo "#ifndef __LINUX_BOUNDS_H__"; echo "#define __LINUX_BOUNDS_H__"; echo "/*"; echo " * DO NOT MODIFY."; echo " *"; echo " * This file was generated by Kbuild"; echo " *"; echo " */"; echo ""; sed -ne "/^->/{s:->#\(.*\):/* \1 */:; s:^->\([^ ]*\) [\$#]*\([-0-9]*\) \(.*\):#define \1 \2 /* \3 */:; s:^->\([^ ]*\) [\$#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 */:; s:->::; p;}" kernel/bounds.s; echo ""; echo "#endif" ) > include/generated/bounds.h mkdir -p arch/mips/kernel/ mips64-linux-gcc -Wp,-MD,arch/mips/kernel/.asm-offsets.s.d -nostdinc -isystem /usr/lib64/gcc/mips64-linux/4.6.0/include -I/home/ralf/src/linux/linux-mips/arch/mips/include -Iarch/mips/include/generated -Iinclude -include /home/ralf/src/linux/linux-mips/include/linux/kconfig.h -D__KERNEL__ -D"VMLINUX_LOAD_ADDRESS=0xa80000000001c000" -D"DATAOFFSET=0" -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -fno-delete-null-pointer-checks -O2 -mno-check-zero-division -mabi=64 -G 0 -mno-abicalls -fno-pic -pipe -msoft-float -ffreestanding -march=r10000 -Wa,--trap -I/home/ralf/src/linux/linux-mips/arch/mips/include/asm/mach-ip27 -I/home/ralf/src/linux/linux-mips/arch/mips/include/asm/mach-generic -Wframe-larger-than=2048 -fno-stack-protector -Wno-unused-but-set-variable -fomit-frame-pointer -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fconserve-stack -DCC_HAVE_ASM_GOTO -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(asm_offsets)" -D"KBUILD_MODNAME=KBUILD_STR(asm_offsets)" -fverbose-asm -S -o arch/mips/kernel/asm-offsets.s arch/mips/kernel/asm-offsets.c (set -e; echo "#ifndef __ASM_OFFSETS_H__"; echo "#define __ASM_OFFSETS_H__"; echo "/*"; echo " * DO NOT MODIFY."; echo " *"; echo " * This file was generated by Kbuild"; echo " *"; echo " */"; echo ""; sed -ne "/^->/{s:->#\(.*\):/* \1 */:; s:^->\([^ ]*\) [\$#]*\([-0-9]*\) \(.*\):#define \1 \2 /* \3 */:; s:^->\([^ ]*\) [\$#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 */:; s:->::; p;}" arch/mips/kernel/asm-offsets.s; echo ""; echo "#endif" ) > include/generated/asm-offsets.h make -f scripts/Makefile.build obj=. missing-syscalls /bin/sh scripts/checksyscalls.sh mips64-linux-gcc -Wp,-MD,./.missing-syscalls.d -nostdinc -isystem /usr/lib64/gcc/mips64-linux/4.6.0/include -I/home/ralf/src/linux/linux-mips/arch/mips/include -Iarch/mips/include/generated -Iinclude -include /home/ralf/src/linux/linux-mips/include/linux/kconfig.h -D__KERNEL__ -D"VMLINUX_LOAD_ADDRESS=0xa80000000001c000" -D"DATAOFFSET=0" -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -fno-delete-null-pointer-checks -O2 -mno-check-zero-division -mabi=64 -G 0 -mno-abicalls -fno-pic -pipe -msoft-float -ffreestanding -march=r10000 -Wa,--trap -I/home/ralf/src/linux/linux-mips/arch/mips/include/asm/mach-ip27 -I/home/ralf/src/linux/linux-mips/arch/mips/include/asm/mach-generic -Wframe-larger-than=2048 -fno-stack-protector -Wno-unused-but-set-variable -fomit-frame-pointer -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fconserve-stack -DCC_HAVE_ASM_GOTO -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(missing_syscalls)" -D"KBUILD_MODNAME=KBUILD_STR(missing_syscalls)" <stdin>:1562:2: warning: #warning syscall process_vm_readv not implemented [-Wcpp] <stdin>:1566:2: warning: #warning syscall process_vm_writev not implemented [-Wcpp] make -f scripts/Makefile.build obj=scripts make -f scripts/Makefile.build obj=scripts/mod Thanks, Ralf ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Kbuild: append missing-syscalls to the default target list 2011-11-07 23:33 ` Ralf Baechle @ 2011-11-08 8:25 ` Michal Marek 2011-11-08 9:53 ` Ralf Baechle 2011-11-08 18:21 ` David Daney 0 siblings, 2 replies; 10+ messages in thread From: Michal Marek @ 2011-11-08 8:25 UTC (permalink / raw) To: Ralf Baechle Cc: Arnaud Lacombe, linux-kbuild, linux-kernel, linux-mips, David Daney On 8.11.2011 00:33, Ralf Baechle wrote: > On Mon, Nov 07, 2011 at 10:19:00PM +0100, Michal Marek wrote: > >> Wild guess - does this patch help? >> >> >> diff --git a/Kbuild b/Kbuild >> index 4caab4f..77c191a 100644 >> --- a/Kbuild >> +++ b/Kbuild >> @@ -94,7 +94,7 @@ targets += missing-syscalls >> quiet_cmd_syscalls = CALL $< >> cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) >> >> -missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE >> +missing-syscalls: scripts/checksyscalls.sh $(offsets-file) $(bounds-file) FORCE >> $(call cmd,syscalls) >> >> # Keep these two files during make clean > > No, it didn't. > >> If not, please attach logs of make V=1 with clean Linus' tree and with >> 5f7efb4c6da9f90cb306923ced2a6494d065a595 reverted. > > $ git checkout 31555213f03bca37d2c02e10946296052f4ecfcd > $ git revert 5f7efb4c6da9f90cb306923ced2a6494d065a595 > $ make ARCH=mips ip27_defconfig > $ make ARCH=mips V=1 2>&1 | tee log Thanks, can you also post a log without the revert? Michal ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Kbuild: append missing-syscalls to the default target list 2011-11-08 8:25 ` Michal Marek @ 2011-11-08 9:53 ` Ralf Baechle 2011-11-08 18:21 ` David Daney 1 sibling, 0 replies; 10+ messages in thread From: Ralf Baechle @ 2011-11-08 9:53 UTC (permalink / raw) To: Michal Marek Cc: Arnaud Lacombe, linux-kbuild, linux-kernel, linux-mips, David Daney On Tue, Nov 08, 2011 at 09:25:01AM +0100, Michal Marek wrote: > Thanks, can you also post a log without the revert? $ git checkout 31555213f03bca37d2c02e10946296052f4ecfcd $ make ARCH=mips ip27_defconfig $ make ARCH=mips V=1 2>&1 | tee log make -f /home/ralf/src/linux/linux-mips/Makefile silentoldconfig make -f scripts/Makefile.build obj=scripts/basic rm -f .tmp_quiet_recordmcount mkdir -p include/linux include/config make -f scripts/Makefile.build obj=scripts/kconfig silentoldconfig mkdir -p include/generated scripts/kconfig/conf --silentoldconfig Kconfig warning: (AX88796_93CX6 && RTL8180 && RTL8187 && ADM8211 && RT2400PCI && RT2500PCI && RT61PCI && RT2800PCI && R8187SE) selects EEPROM_93CX6 which has unmet direct dependencies (MISC_DEVICES) warning: (AX88796_93CX6 && RTL8180 && RTL8187 && ADM8211 && RT2400PCI && RT2500PCI && RT61PCI && RT2800PCI && R8187SE) selects EEPROM_93CX6 which has unmet direct dependencies (MISC_DEVICES) rm -f include/config/kernel.release echo "3.1.0$(/bin/sh /home/ralf/src/linux/linux-mips/scripts/setlocalversion /home/ralf/src/linux/linux-mips)" > include/config/kernel.release make -f /home/ralf/src/linux/linux-mips/scripts/Makefile.asm-generic \ obj=arch/mips/include/generated/asm set -e; : ' CHK include/linux/version.h'; mkdir -p include/linux/; (echo \#define LINUX_VERSION_CODE 196864; echo '#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))';) < /home/ralf/src/linux/linux-mips/Makefile > include/linux/version.h.tmp; if [ -r include/linux/version.h ] && cmp -s include/linux/version.h include/linux/version.h.tmp; then rm -f include/linux/version.h.tmp; else : ' UPD include/linux/version.h'; mv -f include/linux/version.h.tmp include/linux/version.h; fi set -e; : ' CHK include/generated/utsrelease.h'; mkdir -p include/generated/; if [ `echo -n "3.1.0-10325-g3155521" | wc -c ` -gt 64 ]; then echo '"3.1.0-10325-g3155521" exceeds 64 characters' >&2; exit 1; fi; (echo \#define UTS_RELEASE \"3.1.0-10325-g3155521\";) < include/config/kernel.release > include/generated/utsrelease.h.tmp; if [ -r include/generated/utsrelease.h ] && cmp -s include/generated/utsrelease.h include/generated/utsrelease.h.tmp; then rm -f include/generated/utsrelease.h.tmp; else : ' UPD include/generated/utsrelease.h'; mv -f include/generated/utsrelease.h.tmp include/generated/utsrelease.h; fi mkdir -p .tmp_versions ; rm -f .tmp_versions/* make -f scripts/Makefile.build obj=scripts/basic (cat /dev/null; ) > scripts/basic/modules.order rm -f .tmp_quiet_recordmcount Checking missing-syscalls for N32 make -f scripts/Makefile.build obj=. missing-syscalls ccflags-y="-mabi=n32" mkdir -p kernel/ mips64-linux-gcc -Wp,-MD,kernel/.bounds.s.d -nostdinc -isystem /usr/lib64/gcc/mips64-linux/4.6.0/include -I/home/ralf/src/linux/linux-mips/arch/mips/include -Iarch/mips/include/generated -Iinclude -include /home/ralf/src/linux/linux-mips/include/linux/kconfig.h -D__KERNEL__ -D"VMLINUX_LOAD_ADDRESS=0xa80000000001c000" -D"DATAOFFSET=0" -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -fno-delete-null-pointer-checks -O2 -mno-check-zero-division -mabi=64 -G 0 -mno-abicalls -fno-pic -pipe -msoft-float -ffreestanding -march=r10000 -Wa,--trap -I/home/ralf/src/linux/linux-mips/arch/mips/include/asm/mach-ip27 -I/home/ralf/src/linux/linux-mips/arch/mips/include/asm/mach-generic -Wframe-larger-than=2048 -fno-stack-protector -Wno-unused-but-set-variable -fomit-frame-pointer -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fconserve-stack -DCC_HAVE_ASM_GOTO -mabi=n32 -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(bounds)" -D"KBUILD_MODNAME=KBUILD_STR(bounds)" -fverbose-asm -S -o kernel/bounds.s kernel/bounds.c mkdir -p include/generated/ (set -e; echo "#ifndef __LINUX_BOUNDS_H__"; echo "#define __LINUX_BOUNDS_H__"; echo "/*"; echo " * DO NOT MODIFY."; echo " *"; echo " * This file was generated by Kbuild"; echo " *"; echo " */"; echo ""; sed -ne "/^->/{s:->#\(.*\):/* \1 */:; s:^->\([^ ]*\) [\$#]*\([-0-9]*\) \(.*\):#define \1 \2 /* \3 */:; s:^->\([^ ]*\) [\$#]*\([^ ]*\) \(.*\):#define \1 \2 /* \3 */:; s:->::; p;}" kernel/bounds.s; echo ""; echo "#endif" ) > include/generated/bounds.h mkdir -p arch/mips/kernel/ mips64-linux-gcc -Wp,-MD,arch/mips/kernel/.asm-offsets.s.d -nostdinc -isystem /usr/lib64/gcc/mips64-linux/4.6.0/include -I/home/ralf/src/linux/linux-mips/arch/mips/include -Iarch/mips/include/generated -Iinclude -include /home/ralf/src/linux/linux-mips/include/linux/kconfig.h -D__KERNEL__ -D"VMLINUX_LOAD_ADDRESS=0xa80000000001c000" -D"DATAOFFSET=0" -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -Werror-implicit-function-declaration -Wno-format-security -fno-delete-null-pointer-checks -O2 -mno-check-zero-division -mabi=64 -G 0 -mno-abicalls -fno-pic -pipe -msoft-float -ffreestanding -march=r10000 -Wa,--trap -I/home/ralf/src/linux/linux-mips/arch/mips/include/asm/mach-ip27 -I/home/ralf/src/linux/linux-mips/arch/mips/include/asm/mach-generic -Wframe-larger-than=2048 -fno-stack-protector -Wno-unused-but-set-variable -fomit-frame-pointer -Wdeclaration-after-statement -Wno-pointer-sign -fno-strict-overflow -fconserve-stack -DCC_HAVE_ASM_GOTO -mabi=n32 -D"KBUILD_STR(s)=#s" -D"KBUILD_BASENAME=KBUILD_STR(asm_offsets)" -D"KBUILD_MODNAME=KBUILD_STR(asm_offsets)" -fverbose-asm -S -o arch/mips/kernel/asm-offsets.s arch/mips/kernel/asm-offsets.c In file included from include/linux/bitops.h:22:0, from include/linux/kernel.h:17, from include/linux/cache.h:4, from include/linux/time.h:7, from include/linux/stat.h:60, from include/linux/compat.h:10, from arch/mips/kernel/asm-offsets.c:11: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h: In function ‘__fls’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:570:2: warning: left shift count >= width of type [enabled by default] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:572:3: warning: left shift count >= width of type [enabled by default] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:575:2: warning: left shift count >= width of type [enabled by default] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:579:2: warning: left shift count >= width of type [enabled by default] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:583:2: warning: left shift count >= width of type [enabled by default] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:587:2: warning: left shift count >= width of type [enabled by default] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/bitops.h:591:2: warning: left shift count >= width of type [enabled by default] In file included from /home/ralf/src/linux/linux-mips/arch/mips/include/asm/page.h:46:0, from /home/ralf/src/linux/linux-mips/arch/mips/include/asm/compat.h:8, from include/linux/compat.h:18, from arch/mips/kernel/asm-offsets.c:11: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘phys_to_virt’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:136:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘isa_bus_to_virt’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:149:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘outq’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:436:1: error: size of unnamed array is negative /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘inq’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:436:1: error: size of unnamed array is negative /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘outq_p’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:436:1: error: size of unnamed array is negative /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘inq_p’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:436:1: error: size of unnamed array is negative /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘__mem_outq’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:436:1: error: size of unnamed array is negative /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘__mem_inq’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:436:1: error: size of unnamed array is negative /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘__mem_outq_p’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:436:1: error: size of unnamed array is negative /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h: In function ‘__mem_inq_p’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/io.h:436:1: error: size of unnamed array is negative In file included from /home/ralf/src/linux/linux-mips/arch/mips/include/asm/pgtable.h:15:0, from include/linux/mm.h:42, from arch/mips/kernel/asm-offsets.c:14: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/pgtable-64.h: In function ‘mk_swap_pte’: /home/ralf/src/linux/linux-mips/arch/mips/include/asm/pgtable-64.h:273:1: warning: left shift count >= width of type [enabled by default] /home/ralf/src/linux/linux-mips/arch/mips/include/asm/pgtable-64.h:273:1: warning: left shift count >= width of type [enabled by default] In file included from arch/mips/kernel/asm-offsets.c:14:0: include/linux/mm.h: In function ‘virt_to_head_page’: include/linux/mm.h:407:9: warning: right shift count >= width of type [enabled by default] In file included from arch/mips/kernel/asm-offsets.c:14:0: include/linux/mm.h: In function ‘lowmem_page_address’: include/linux/mm.h:737:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] make[1]: *** [arch/mips/kernel/asm-offsets.s] Error 1 make: *** [archprepare] Error 2 The issue is related to archprepare: ifdef CONFIG_MIPS32_N32 @echo ' Checking missing-syscalls for N32' $(Q)$(MAKE) $(build)=. missing-syscalls ccflags-y="-mabi=n32" endif ifdef CONFIG_MIPS32_O32 @echo ' Checking missing-syscalls for O32' $(Q)$(MAKE) $(build)=. missing-syscalls ccflags-y="-mabi=32" endif that if the ifdef'ed code is removed or both if conditions are false compilation will succeed. Ralf ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Kbuild: append missing-syscalls to the default target list 2011-11-08 8:25 ` Michal Marek 2011-11-08 9:53 ` Ralf Baechle @ 2011-11-08 18:21 ` David Daney 2011-11-08 18:21 ` David Daney 2011-11-08 22:30 ` Michal Marek 1 sibling, 2 replies; 10+ messages in thread From: David Daney @ 2011-11-08 18:21 UTC (permalink / raw) To: Michal Marek Cc: Ralf Baechle, Arnaud Lacombe, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Daney, David [-- Attachment #1: Type: text/plain, Size: 1394 bytes --] On 11/08/2011 12:25 AM, Michal Marek wrote: > On 8.11.2011 00:33, Ralf Baechle wrote: >> On Mon, Nov 07, 2011 at 10:19:00PM +0100, Michal Marek wrote: >> >>> Wild guess - does this patch help? >>> >>> >>> diff --git a/Kbuild b/Kbuild >>> index 4caab4f..77c191a 100644 >>> --- a/Kbuild >>> +++ b/Kbuild >>> @@ -94,7 +94,7 @@ targets += missing-syscalls >>> quiet_cmd_syscalls = CALL $< >>> cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) >>> >>> -missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE >>> +missing-syscalls: scripts/checksyscalls.sh $(offsets-file) $(bounds-file) FORCE >>> $(call cmd,syscalls) >>> >>> # Keep these two files during make clean >> >> No, it didn't. >> >>> If not, please attach logs of make V=1 with clean Linus' tree and with >>> 5f7efb4c6da9f90cb306923ced2a6494d065a595 reverted. >> >> $ git checkout 31555213f03bca37d2c02e10946296052f4ecfcd >> $ git revert 5f7efb4c6da9f90cb306923ced2a6494d065a595 >> $ make ARCH=mips ip27_defconfig >> $ make ARCH=mips V=1 2>&1 | tee log > > Thanks, can you also post a log without the revert? > The problem is that compiler options meant to be used only for the compiling done by scripts/checksyscalls.sh are now leaking into the compilation of other parts of the kernel (asm-offsets.c), where they wreak havoc. Something like the attached is what I think needs to be done. David Daney [-- Attachment #2: 0001-kbuild-Fix-missing-system-calls-check-on-mips.patch --] [-- Type: text/plain, Size: 1481 bytes --] >From e23608d2612092a8576d408425f6719f0860f5ff Mon Sep 17 00:00:00 2001 From: David Daney <david.daney@cavium.com> Date: Tue, 8 Nov 2011 10:20:10 -0800 Subject: [PATCH] kbuild: Fix missing system calls check on mips. Signed-off-by: David Daney <david.daney@cavium.com> --- Kbuild | 2 +- arch/mips/Makefile | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Kbuild b/Kbuild index 4caab4f..b8b708a 100644 --- a/Kbuild +++ b/Kbuild @@ -92,7 +92,7 @@ always += missing-syscalls targets += missing-syscalls quiet_cmd_syscalls = CALL $< - cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) + cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) $(missing_syscalls_flags) missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE $(call cmd,syscalls) diff --git a/arch/mips/Makefile b/arch/mips/Makefile index 9b4cb00..0be3186 100644 --- a/arch/mips/Makefile +++ b/arch/mips/Makefile @@ -286,11 +286,11 @@ CLEAN_FILES += vmlinux.32 vmlinux.64 archprepare: ifdef CONFIG_MIPS32_N32 @echo ' Checking missing-syscalls for N32' - $(Q)$(MAKE) $(build)=. missing-syscalls ccflags-y="-mabi=n32" + $(Q)$(MAKE) $(build)=. missing-syscalls missing_syscalls_flags="-mabi=n32" endif ifdef CONFIG_MIPS32_O32 @echo ' Checking missing-syscalls for O32' - $(Q)$(MAKE) $(build)=. missing-syscalls ccflags-y="-mabi=32" + $(Q)$(MAKE) $(build)=. missing-syscalls missing_syscalls_flags="-mabi=32" endif install: -- 1.7.2.3 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] Kbuild: append missing-syscalls to the default target list 2011-11-08 18:21 ` David Daney @ 2011-11-08 18:21 ` David Daney 2011-11-08 22:30 ` Michal Marek 1 sibling, 0 replies; 10+ messages in thread From: David Daney @ 2011-11-08 18:21 UTC (permalink / raw) To: Michal Marek Cc: Ralf Baechle, Arnaud Lacombe, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Daney, David [-- Attachment #1: Type: text/plain, Size: 1394 bytes --] On 11/08/2011 12:25 AM, Michal Marek wrote: > On 8.11.2011 00:33, Ralf Baechle wrote: >> On Mon, Nov 07, 2011 at 10:19:00PM +0100, Michal Marek wrote: >> >>> Wild guess - does this patch help? >>> >>> >>> diff --git a/Kbuild b/Kbuild >>> index 4caab4f..77c191a 100644 >>> --- a/Kbuild >>> +++ b/Kbuild >>> @@ -94,7 +94,7 @@ targets += missing-syscalls >>> quiet_cmd_syscalls = CALL $< >>> cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) >>> >>> -missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE >>> +missing-syscalls: scripts/checksyscalls.sh $(offsets-file) $(bounds-file) FORCE >>> $(call cmd,syscalls) >>> >>> # Keep these two files during make clean >> >> No, it didn't. >> >>> If not, please attach logs of make V=1 with clean Linus' tree and with >>> 5f7efb4c6da9f90cb306923ced2a6494d065a595 reverted. >> >> $ git checkout 31555213f03bca37d2c02e10946296052f4ecfcd >> $ git revert 5f7efb4c6da9f90cb306923ced2a6494d065a595 >> $ make ARCH=mips ip27_defconfig >> $ make ARCH=mips V=1 2>&1 | tee log > > Thanks, can you also post a log without the revert? > The problem is that compiler options meant to be used only for the compiling done by scripts/checksyscalls.sh are now leaking into the compilation of other parts of the kernel (asm-offsets.c), where they wreak havoc. Something like the attached is what I think needs to be done. David Daney [-- Attachment #2: 0001-kbuild-Fix-missing-system-calls-check-on-mips.patch --] [-- Type: text/plain, Size: 1480 bytes --] From e23608d2612092a8576d408425f6719f0860f5ff Mon Sep 17 00:00:00 2001 From: David Daney <david.daney@cavium.com> Date: Tue, 8 Nov 2011 10:20:10 -0800 Subject: [PATCH] kbuild: Fix missing system calls check on mips. Signed-off-by: David Daney <david.daney@cavium.com> --- Kbuild | 2 +- arch/mips/Makefile | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Kbuild b/Kbuild index 4caab4f..b8b708a 100644 --- a/Kbuild +++ b/Kbuild @@ -92,7 +92,7 @@ always += missing-syscalls targets += missing-syscalls quiet_cmd_syscalls = CALL $< - cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) + cmd_syscalls = $(CONFIG_SHELL) $< $(CC) $(c_flags) $(missing_syscalls_flags) missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE $(call cmd,syscalls) diff --git a/arch/mips/Makefile b/arch/mips/Makefile index 9b4cb00..0be3186 100644 --- a/arch/mips/Makefile +++ b/arch/mips/Makefile @@ -286,11 +286,11 @@ CLEAN_FILES += vmlinux.32 vmlinux.64 archprepare: ifdef CONFIG_MIPS32_N32 @echo ' Checking missing-syscalls for N32' - $(Q)$(MAKE) $(build)=. missing-syscalls ccflags-y="-mabi=n32" + $(Q)$(MAKE) $(build)=. missing-syscalls missing_syscalls_flags="-mabi=n32" endif ifdef CONFIG_MIPS32_O32 @echo ' Checking missing-syscalls for O32' - $(Q)$(MAKE) $(build)=. missing-syscalls ccflags-y="-mabi=32" + $(Q)$(MAKE) $(build)=. missing-syscalls missing_syscalls_flags="-mabi=32" endif install: -- 1.7.2.3 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] Kbuild: append missing-syscalls to the default target list 2011-11-08 18:21 ` David Daney 2011-11-08 18:21 ` David Daney @ 2011-11-08 22:30 ` Michal Marek 2011-11-09 9:54 ` Ralf Baechle 1 sibling, 1 reply; 10+ messages in thread From: Michal Marek @ 2011-11-08 22:30 UTC (permalink / raw) To: David Daney Cc: Ralf Baechle, Arnaud Lacombe, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Daney, David On 8.11.2011 19:21, David Daney wrote: > The problem is that compiler options meant to be used only for the > compiling done by scripts/checksyscalls.sh are now leaking into the > compilation of other parts of the kernel (asm-offsets.c), where they > wreak havoc. > > Something like the attached is what I think needs to be done. Ah, right. That makes a lot of sense now. Ralf, does the patch at https://lkml.org/lkml/2011/11/8/312 work for you? Michal ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Kbuild: append missing-syscalls to the default target list 2011-11-08 22:30 ` Michal Marek @ 2011-11-09 9:54 ` Ralf Baechle 2011-11-09 13:43 ` Michal Marek 0 siblings, 1 reply; 10+ messages in thread From: Ralf Baechle @ 2011-11-09 9:54 UTC (permalink / raw) To: Michal Marek Cc: David Daney, Arnaud Lacombe, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Daney, David On Tue, Nov 08, 2011 at 11:30:48PM +0100, Michal Marek wrote: > On 8.11.2011 19:21, David Daney wrote: > > The problem is that compiler options meant to be used only for the > > compiling done by scripts/checksyscalls.sh are now leaking into the > > compilation of other parts of the kernel (asm-offsets.c), where they > > wreak havoc. > > > > Something like the attached is what I think needs to be done. > > Ah, right. That makes a lot of sense now. Ralf, does the patch at > https://lkml.org/lkml/2011/11/8/312 work for you? Yes, it does - and unlike David's first version this one also looks reasonably elegant. Acked-by: Ralf Baechle <ralf@linux-mips.org> Ralf ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] Kbuild: append missing-syscalls to the default target list 2011-11-09 9:54 ` Ralf Baechle @ 2011-11-09 13:43 ` Michal Marek 0 siblings, 0 replies; 10+ messages in thread From: Michal Marek @ 2011-11-09 13:43 UTC (permalink / raw) To: Ralf Baechle Cc: David Daney, Arnaud Lacombe, linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, Daney, David Dne 9.11.2011 10:54, Ralf Baechle napsal(a): > On Tue, Nov 08, 2011 at 11:30:48PM +0100, Michal Marek wrote: > >> On 8.11.2011 19:21, David Daney wrote: >>> The problem is that compiler options meant to be used only for the >>> compiling done by scripts/checksyscalls.sh are now leaking into the >>> compilation of other parts of the kernel (asm-offsets.c), where they >>> wreak havoc. >>> >>> Something like the attached is what I think needs to be done. >> >> Ah, right. That makes a lot of sense now. Ralf, does the patch at >> https://lkml.org/lkml/2011/11/8/312 work for you? > > Yes, it does - and unlike David's first version this one also looks > reasonably elegant. > > Acked-by: Ralf Baechle <ralf@linux-mips.org> Thanks to both of you, applied to kbuild.git#rc-fixes. Michal ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2011-11-09 13:43 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1314234210-11090-1-git-send-email-lacombar@gmail.com>
[not found] ` <4E69FEC9.2080204@suse.cz>
[not found] ` <CACqU3MUFyn_jh2pN4GLENqcGVUzAwcMJUR_WLY2EtqOhMheceQ@mail.gmail.com>
[not found] ` <20111101232233.GA32441@sepie.suse.cz>
2011-11-07 20:44 ` [PATCH] Kbuild: append missing-syscalls to the default target list Ralf Baechle
2011-11-07 21:19 ` Michal Marek
2011-11-07 23:33 ` Ralf Baechle
2011-11-08 8:25 ` Michal Marek
2011-11-08 9:53 ` Ralf Baechle
2011-11-08 18:21 ` David Daney
2011-11-08 18:21 ` David Daney
2011-11-08 22:30 ` Michal Marek
2011-11-09 9:54 ` Ralf Baechle
2011-11-09 13:43 ` Michal Marek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox