From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Michael Büsch" <m@bues.ch>
Cc: linville@tuxdriver.com, zajec5@gmail.com,
b43-dev@lists.infradead.org, linux-mips@linux-mips.org,
linux-wireless@vger.kernel.org, arend@broadcom.com
Subject: Re: [PATCH 04/11] ssb: add ccode
Date: Sun, 19 Feb 2012 20:28:35 +0100 [thread overview]
Message-ID: <4F414D63.1070409@hauke-m.de> (raw)
In-Reply-To: <20120219194923.566f3fe8@milhouse>
On 02/19/2012 07:49 PM, Michael Büsch wrote:
> On Sun, 19 Feb 2012 19:32:18 +0100
> Hauke Mehrtens <hauke@hauke-m.de> wrote:
>
>> This member contains the country code encoded with two chars
>>
>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>> ---
>> include/linux/ssb/ssb.h | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/linux/ssb/ssb.h b/include/linux/ssb/ssb.h
>> index 4928419..44e486e 100644
>> --- a/include/linux/ssb/ssb.h
>> +++ b/include/linux/ssb/ssb.h
>> @@ -33,6 +33,7 @@ struct ssb_sprom {
>> u8 et1mdcport; /* MDIO for enet1 */
>> u16 board_rev; /* Board revision number from SPROM. */
>> u8 country_code; /* Country Code */
>> + char ccode[2]; /* Country Code as two chars like EU or US */
>
> This usually is referred to as "alpha2". So we should name it like that, too.
I can not find any references to "alpha2" in the spec, the broadcom
code, ssb, bcma or b43. ccode was the name broadcom gave this value so I
took it.
http://bcm-v4.sipsolutions.net/SPROM wrongly maps ccode to country_code,
but cc is stored into country_code in ssb.
Hauke
next prev parent reply other threads:[~2012-02-19 19:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 18:32 [PATCH 00/11] ssb/bcma/BCM47XX: sprom fixes and extensions Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 01/11] ssb: sprom fix some sizes / signedness Hauke Mehrtens
2012-02-23 18:14 ` Rafał Miłecki
2012-02-23 21:27 ` Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 02/11] ssb: remove 5GHz antenna gain from sprom Hauke Mehrtens
2012-02-19 19:14 ` Larry Finger
2012-02-19 19:17 ` Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 03/11] ssb: fix per path sprom vars Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 04/11] ssb: add ccode Hauke Mehrtens
2012-02-19 18:49 ` Michael Büsch
2012-02-19 19:28 ` Hauke Mehrtens [this message]
2012-02-19 19:50 ` Michael Büsch
2012-02-19 20:01 ` Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 05/11] ssb: add some missing sprom attributes Hauke Mehrtens
2012-02-19 22:16 ` Gábor Stefanik
2012-02-19 18:32 ` [PATCH 06/11] bcma: export bcma_find_core Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 07/11] bcma: add support for sprom not found on the device Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 08/11] MIPS: BCM47XX: return number of written bytes in nvram_getenv Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 09/11] MIPS: BCM47XX: fix signature of nvram_parse_macaddr Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 10/11] MIPS: BCM47XX: move and extend sprom parsing Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 11/11] MIPS: BCM47XX: provide sprom to bcma bus Hauke Mehrtens
2012-02-20 11:08 ` Sergei Shtylyov
2012-02-21 19:37 ` [PATCH 00/11] ssb/bcma/BCM47XX: sprom fixes and extensions John W. Linville
2012-02-21 19:52 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F414D63.1070409@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=arend@broadcom.com \
--cc=b43-dev@lists.infradead.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=m@bues.ch \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox