From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: linville@tuxdriver.com, b43-dev@lists.infradead.org,
linux-mips@linux-mips.org, linux-wireless@vger.kernel.org,
arend@broadcom.com, m@bues.ch
Subject: Re: [PATCH 01/11] ssb: sprom fix some sizes / signedness
Date: Thu, 23 Feb 2012 22:27:29 +0100 [thread overview]
Message-ID: <4F46AF41.6060803@hauke-m.de> (raw)
In-Reply-To: <CACna6rwNEPY3iJCeWV3AmbBy7fQwQrgr9Oji6tro-Dr23y5udQ@mail.gmail.com>
On 02/23/2012 07:14 PM, Rafał Miłecki wrote:
> 2012/2/19 Hauke Mehrtens <hauke@hauke-m.de>:
>> @@ -53,10 +53,10 @@ struct ssb_sprom {
>> u8 gpio1; /* GPIO pin 1 */
>> u8 gpio2; /* GPIO pin 2 */
>> u8 gpio3; /* GPIO pin 3 */
>> - u16 maxpwr_bg; /* 2.4GHz Amplifier Max Power (in dBm Q5.2) */
>> - u16 maxpwr_al; /* 5.2GHz Amplifier Max Power (in dBm Q5.2) */
>> - u16 maxpwr_a; /* 5.3GHz Amplifier Max Power (in dBm Q5.2) */
>> - u16 maxpwr_ah; /* 5.8GHz Amplifier Max Power (in dBm Q5.2) */
>> + u8 maxpwr_bg; /* 2.4GHz Amplifier Max Power (in dBm Q5.2) */
>> + u8 maxpwr_al; /* 5.2GHz Amplifier Max Power (in dBm Q5.2) */
>> + u8 maxpwr_a; /* 5.3GHz Amplifier Max Power (in dBm Q5.2) */
>> + u8 maxpwr_ah; /* 5.8GHz Amplifier Max Power (in dBm Q5.2) */
>> u8 itssi_a; /* Idle TSSI Target for A-PHY */
>> u8 itssi_bg; /* Idle TSSI Target for B/G-PHY */
>> u8 tri2g; /* 2.4GHz TX isolation */
>
> Just a note in case you're going to develop ssb/bcma/b43/brcm code.
> Please note we're trying to switch from properties you modified to
> struct ssb_sprom_core_pwr_info.
These vars are available in sprom 1-3,8,9 and the ones in struct
ssb_sprom_core_pwr_info just for sprom 4,5,8,9. The old are probably not
used by newer chips any more. I just found these because I generated my
parsing code from broadcom open source code and got a compiler warning
because of wrong sizes.
>
> The patch still looks fine.
>
next prev parent reply other threads:[~2012-02-23 21:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 18:32 [PATCH 00/11] ssb/bcma/BCM47XX: sprom fixes and extensions Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 01/11] ssb: sprom fix some sizes / signedness Hauke Mehrtens
2012-02-23 18:14 ` Rafał Miłecki
2012-02-23 21:27 ` Hauke Mehrtens [this message]
2012-02-19 18:32 ` [PATCH 02/11] ssb: remove 5GHz antenna gain from sprom Hauke Mehrtens
2012-02-19 19:14 ` Larry Finger
2012-02-19 19:17 ` Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 03/11] ssb: fix per path sprom vars Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 04/11] ssb: add ccode Hauke Mehrtens
2012-02-19 18:49 ` Michael Büsch
2012-02-19 19:28 ` Hauke Mehrtens
2012-02-19 19:50 ` Michael Büsch
2012-02-19 20:01 ` Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 05/11] ssb: add some missing sprom attributes Hauke Mehrtens
2012-02-19 22:16 ` Gábor Stefanik
2012-02-19 18:32 ` [PATCH 06/11] bcma: export bcma_find_core Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 07/11] bcma: add support for sprom not found on the device Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 08/11] MIPS: BCM47XX: return number of written bytes in nvram_getenv Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 09/11] MIPS: BCM47XX: fix signature of nvram_parse_macaddr Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 10/11] MIPS: BCM47XX: move and extend sprom parsing Hauke Mehrtens
2012-02-19 18:32 ` [PATCH 11/11] MIPS: BCM47XX: provide sprom to bcma bus Hauke Mehrtens
2012-02-20 11:08 ` Sergei Shtylyov
2012-02-21 19:37 ` [PATCH 00/11] ssb/bcma/BCM47XX: sprom fixes and extensions John W. Linville
2012-02-21 19:52 ` Hauke Mehrtens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F46AF41.6060803@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=arend@broadcom.com \
--cc=b43-dev@lists.infradead.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=m@bues.ch \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox