* [PATCH 0/3] Cleanup raw handling of online/possible map [not found] <87wr7pbwbz.fsf@rustcorp.com.au> @ 2012-02-14 22:49 ` Venkatesh Pallipadi 2012-02-14 22:49 ` [PATCH 1/3] hexagon: Avoid raw handling of cpu_possible_map Venkatesh Pallipadi ` (2 more replies) 0 siblings, 3 replies; 5+ messages in thread From: Venkatesh Pallipadi @ 2012-02-14 22:49 UTC (permalink / raw) To: Rusty Russell Cc: Tony Luck, Srivatsa S. Bhat, Andrew Morton, KOSAKI Motohiro, KOSAKI Motohiro, Mike Travis, Paul E. McKenney, Rafael J. Wysocki, Paul Gortmaker, linux-kernel, Richard Kuo, linux-hexagon, Ralf Baechle, linux-mips, Jeff Dike, Richard Weinberger, user-mode-linux-devel > Yes, and the other architectures. Here are the patches for other instances I see in plain git grep. I have been brave (foolish) enough to send this without any testing. So, this comes with 'use it at your own risk' tag :-). Thanks, Venki ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/3] hexagon: Avoid raw handling of cpu_possible_map 2012-02-14 22:49 ` [PATCH 0/3] Cleanup raw handling of online/possible map Venkatesh Pallipadi @ 2012-02-14 22:49 ` Venkatesh Pallipadi 2012-02-14 22:49 ` [PATCH 2/3] mips: Avoid raw handling of cpu_possible_map/cpu_online_map Venkatesh Pallipadi 2012-02-14 22:49 ` [PATCH 3/3] um: Avoid raw handling of cpu_online_map Venkatesh Pallipadi 2 siblings, 0 replies; 5+ messages in thread From: Venkatesh Pallipadi @ 2012-02-14 22:49 UTC (permalink / raw) To: Rusty Russell Cc: Tony Luck, Srivatsa S. Bhat, Andrew Morton, KOSAKI Motohiro, KOSAKI Motohiro, Mike Travis, Paul E. McKenney, Rafael J. Wysocki, Paul Gortmaker, linux-kernel, Richard Kuo, linux-hexagon, Ralf Baechle, linux-mips, Jeff Dike, Richard Weinberger, user-mode-linux-devel, Venkatesh Pallipadi Use set_cpu_possible instead. Signed-off-by: Venkatesh Pallipadi <venki@google.com> --- arch/hexagon/kernel/smp.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/arch/hexagon/kernel/smp.c b/arch/hexagon/kernel/smp.c index c871a2c..8962705 100644 --- a/arch/hexagon/kernel/smp.c +++ b/arch/hexagon/kernel/smp.c @@ -272,5 +272,5 @@ void smp_start_cpus(void) int i; for (i = 0; i < NR_CPUS; i++) - cpu_set(i, cpu_possible_map); + set_cpu_possible(i, true); } -- 1.7.7.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/3] mips: Avoid raw handling of cpu_possible_map/cpu_online_map 2012-02-14 22:49 ` [PATCH 0/3] Cleanup raw handling of online/possible map Venkatesh Pallipadi 2012-02-14 22:49 ` [PATCH 1/3] hexagon: Avoid raw handling of cpu_possible_map Venkatesh Pallipadi @ 2012-02-14 22:49 ` Venkatesh Pallipadi 2012-02-27 22:19 ` David Daney 2012-02-14 22:49 ` [PATCH 3/3] um: Avoid raw handling of cpu_online_map Venkatesh Pallipadi 2 siblings, 1 reply; 5+ messages in thread From: Venkatesh Pallipadi @ 2012-02-14 22:49 UTC (permalink / raw) To: Rusty Russell Cc: Tony Luck, Srivatsa S. Bhat, Andrew Morton, KOSAKI Motohiro, KOSAKI Motohiro, Mike Travis, Paul E. McKenney, Rafael J. Wysocki, Paul Gortmaker, linux-kernel, Richard Kuo, linux-hexagon, Ralf Baechle, linux-mips, Jeff Dike, Richard Weinberger, user-mode-linux-devel, Venkatesh Pallipadi Use set_cpu_* and init_cpu_* variants instead. Signed-off-by: Venkatesh Pallipadi <venki@google.com> --- arch/mips/cavium-octeon/smp.c | 2 +- arch/mips/kernel/smp.c | 4 ++-- arch/mips/netlogic/xlr/smp.c | 4 ++-- arch/mips/pmc-sierra/yosemite/smp.c | 4 ++-- arch/mips/sgi-ip27/ip27-smp.c | 2 +- arch/mips/sibyte/bcm1480/smp.c | 5 ++--- arch/mips/sibyte/sb1250/smp.c | 5 ++--- 7 files changed, 12 insertions(+), 14 deletions(-) diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c index efcfff4..5cce09c 100644 --- a/arch/mips/cavium-octeon/smp.c +++ b/arch/mips/cavium-octeon/smp.c @@ -268,7 +268,7 @@ static int octeon_cpu_disable(void) spin_lock(&smp_reserve_lock); - cpu_clear(cpu, cpu_online_map); + set_cpu_online(cpu, false); cpu_clear(cpu, cpu_callin_map); local_irq_disable(); fixup_irqs(); diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c index 32c1e95..28777ff 100644 --- a/arch/mips/kernel/smp.c +++ b/arch/mips/kernel/smp.c @@ -148,7 +148,7 @@ static void stop_this_cpu(void *dummy) /* * Remove this CPU: */ - cpu_clear(smp_processor_id(), cpu_online_map); + set_cpu_online(smp_processor_id(), false); for (;;) { if (cpu_wait) (*cpu_wait)(); /* Wait if available. */ @@ -248,7 +248,7 @@ int __cpuinit __cpu_up(unsigned int cpu) while (!cpu_isset(cpu, cpu_callin_map)) udelay(100); - cpu_set(cpu, cpu_online_map); + set_cpu_online(cpu, true); return 0; } diff --git a/arch/mips/netlogic/xlr/smp.c b/arch/mips/netlogic/xlr/smp.c index 080284d..8084221 100644 --- a/arch/mips/netlogic/xlr/smp.c +++ b/arch/mips/netlogic/xlr/smp.c @@ -154,7 +154,7 @@ void __init nlm_smp_setup(void) cpu_set(boot_cpu, phys_cpu_present_map); __cpu_number_map[boot_cpu] = 0; __cpu_logical_map[0] = boot_cpu; - cpu_set(0, cpu_possible_map); + set_cpu_possible(0, true); num_cpus = 1; for (i = 0; i < NR_CPUS; i++) { @@ -166,7 +166,7 @@ void __init nlm_smp_setup(void) cpu_set(i, phys_cpu_present_map); __cpu_number_map[i] = num_cpus; __cpu_logical_map[num_cpus] = i; - cpu_set(num_cpus, cpu_possible_map); + set_cpu_possible(num_cpus, true); ++num_cpus; } } diff --git a/arch/mips/pmc-sierra/yosemite/smp.c b/arch/mips/pmc-sierra/yosemite/smp.c index 2608752..b2b23eb 100644 --- a/arch/mips/pmc-sierra/yosemite/smp.c +++ b/arch/mips/pmc-sierra/yosemite/smp.c @@ -155,10 +155,10 @@ static void __init yos_smp_setup(void) { int i; - cpus_clear(cpu_possible_map); + init_cpu_possible(cpumask_of(0)); for (i = 0; i < 2; i++) { - cpu_set(i, cpu_possible_map); + set_cpu_possible(i, true); __cpu_number_map[i] = i; __cpu_logical_map[i] = i; } diff --git a/arch/mips/sgi-ip27/ip27-smp.c b/arch/mips/sgi-ip27/ip27-smp.c index c6851df..735b43b 100644 --- a/arch/mips/sgi-ip27/ip27-smp.c +++ b/arch/mips/sgi-ip27/ip27-smp.c @@ -76,7 +76,7 @@ static int do_cpumask(cnodeid_t cnode, nasid_t nasid, int highest) /* Only let it join in if it's marked enabled */ if ((acpu->cpu_info.flags & KLINFO_ENABLE) && (tot_cpus_found != NR_CPUS)) { - cpu_set(cpuid, cpu_possible_map); + set_cpu_possible(cpuid, true); alloc_cpupda(cpuid, tot_cpus_found); cpus_found++; tot_cpus_found++; diff --git a/arch/mips/sibyte/bcm1480/smp.c b/arch/mips/sibyte/bcm1480/smp.c index d667875..63d2211 100644 --- a/arch/mips/sibyte/bcm1480/smp.c +++ b/arch/mips/sibyte/bcm1480/smp.c @@ -147,14 +147,13 @@ static void __init bcm1480_smp_setup(void) { int i, num; - cpus_clear(cpu_possible_map); - cpu_set(0, cpu_possible_map); + init_cpu_possible(cpumask_of(0)); __cpu_number_map[0] = 0; __cpu_logical_map[0] = 0; for (i = 1, num = 0; i < NR_CPUS; i++) { if (cfe_cpu_stop(i) == 0) { - cpu_set(i, cpu_possible_map); + set_cpu_possible(i, true); __cpu_number_map[i] = ++num; __cpu_logical_map[num] = i; } diff --git a/arch/mips/sibyte/sb1250/smp.c b/arch/mips/sibyte/sb1250/smp.c index 38e7f6b..77f0df5 100644 --- a/arch/mips/sibyte/sb1250/smp.c +++ b/arch/mips/sibyte/sb1250/smp.c @@ -135,14 +135,13 @@ static void __init sb1250_smp_setup(void) { int i, num; - cpus_clear(cpu_possible_map); - cpu_set(0, cpu_possible_map); + init_cpu_possible(cpumask_of(0)); __cpu_number_map[0] = 0; __cpu_logical_map[0] = 0; for (i = 1, num = 0; i < NR_CPUS; i++) { if (cfe_cpu_stop(i) == 0) { - cpu_set(i, cpu_possible_map); + set_cpu_possible(i, true); __cpu_number_map[i] = ++num; __cpu_logical_map[num] = i; } -- 1.7.7.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 2/3] mips: Avoid raw handling of cpu_possible_map/cpu_online_map 2012-02-14 22:49 ` [PATCH 2/3] mips: Avoid raw handling of cpu_possible_map/cpu_online_map Venkatesh Pallipadi @ 2012-02-27 22:19 ` David Daney 0 siblings, 0 replies; 5+ messages in thread From: David Daney @ 2012-02-27 22:19 UTC (permalink / raw) To: Venkatesh Pallipadi, Ralf Baechle Cc: Rusty Russell, Tony Luck, Srivatsa S. Bhat, Andrew Morton, KOSAKI Motohiro, KOSAKI Motohiro, Mike Travis, Paul E. McKenney, Rafael J. Wysocki, Paul Gortmaker, linux-kernel, Richard Kuo, linux-hexagon, linux-mips, Jeff Dike, Richard Weinberger, user-mode-linux-devel On 02/14/2012 02:49 PM, Venkatesh Pallipadi wrote: > Use set_cpu_* and init_cpu_* variants instead. > > Signed-off-by: Venkatesh Pallipadi<venki@google.com> I came up with the same thing, so... Acked-by: David Daney <david.daney@cavium.com> Ralf: If you too were to Acknowledge the patch, we might get it merged. David Daney > --- > arch/mips/cavium-octeon/smp.c | 2 +- > arch/mips/kernel/smp.c | 4 ++-- > arch/mips/netlogic/xlr/smp.c | 4 ++-- > arch/mips/pmc-sierra/yosemite/smp.c | 4 ++-- > arch/mips/sgi-ip27/ip27-smp.c | 2 +- > arch/mips/sibyte/bcm1480/smp.c | 5 ++--- > arch/mips/sibyte/sb1250/smp.c | 5 ++--- > 7 files changed, 12 insertions(+), 14 deletions(-) > > diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c > index efcfff4..5cce09c 100644 > --- a/arch/mips/cavium-octeon/smp.c > +++ b/arch/mips/cavium-octeon/smp.c > @@ -268,7 +268,7 @@ static int octeon_cpu_disable(void) > > spin_lock(&smp_reserve_lock); > > - cpu_clear(cpu, cpu_online_map); > + set_cpu_online(cpu, false); > cpu_clear(cpu, cpu_callin_map); > local_irq_disable(); > fixup_irqs(); > diff --git a/arch/mips/kernel/smp.c b/arch/mips/kernel/smp.c > index 32c1e95..28777ff 100644 > --- a/arch/mips/kernel/smp.c > +++ b/arch/mips/kernel/smp.c > @@ -148,7 +148,7 @@ static void stop_this_cpu(void *dummy) > /* > * Remove this CPU: > */ > - cpu_clear(smp_processor_id(), cpu_online_map); > + set_cpu_online(smp_processor_id(), false); > for (;;) { > if (cpu_wait) > (*cpu_wait)(); /* Wait if available. */ > @@ -248,7 +248,7 @@ int __cpuinit __cpu_up(unsigned int cpu) > while (!cpu_isset(cpu, cpu_callin_map)) > udelay(100); > > - cpu_set(cpu, cpu_online_map); > + set_cpu_online(cpu, true); > > return 0; > } > diff --git a/arch/mips/netlogic/xlr/smp.c b/arch/mips/netlogic/xlr/smp.c > index 080284d..8084221 100644 > --- a/arch/mips/netlogic/xlr/smp.c > +++ b/arch/mips/netlogic/xlr/smp.c > @@ -154,7 +154,7 @@ void __init nlm_smp_setup(void) > cpu_set(boot_cpu, phys_cpu_present_map); > __cpu_number_map[boot_cpu] = 0; > __cpu_logical_map[0] = boot_cpu; > - cpu_set(0, cpu_possible_map); > + set_cpu_possible(0, true); > > num_cpus = 1; > for (i = 0; i< NR_CPUS; i++) { > @@ -166,7 +166,7 @@ void __init nlm_smp_setup(void) > cpu_set(i, phys_cpu_present_map); > __cpu_number_map[i] = num_cpus; > __cpu_logical_map[num_cpus] = i; > - cpu_set(num_cpus, cpu_possible_map); > + set_cpu_possible(num_cpus, true); > ++num_cpus; > } > } > diff --git a/arch/mips/pmc-sierra/yosemite/smp.c b/arch/mips/pmc-sierra/yosemite/smp.c > index 2608752..b2b23eb 100644 > --- a/arch/mips/pmc-sierra/yosemite/smp.c > +++ b/arch/mips/pmc-sierra/yosemite/smp.c > @@ -155,10 +155,10 @@ static void __init yos_smp_setup(void) > { > int i; > > - cpus_clear(cpu_possible_map); > + init_cpu_possible(cpumask_of(0)); > > for (i = 0; i< 2; i++) { > - cpu_set(i, cpu_possible_map); > + set_cpu_possible(i, true); > __cpu_number_map[i] = i; > __cpu_logical_map[i] = i; > } > diff --git a/arch/mips/sgi-ip27/ip27-smp.c b/arch/mips/sgi-ip27/ip27-smp.c > index c6851df..735b43b 100644 > --- a/arch/mips/sgi-ip27/ip27-smp.c > +++ b/arch/mips/sgi-ip27/ip27-smp.c > @@ -76,7 +76,7 @@ static int do_cpumask(cnodeid_t cnode, nasid_t nasid, int highest) > /* Only let it join in if it's marked enabled */ > if ((acpu->cpu_info.flags& KLINFO_ENABLE)&& > (tot_cpus_found != NR_CPUS)) { > - cpu_set(cpuid, cpu_possible_map); > + set_cpu_possible(cpuid, true); > alloc_cpupda(cpuid, tot_cpus_found); > cpus_found++; > tot_cpus_found++; > diff --git a/arch/mips/sibyte/bcm1480/smp.c b/arch/mips/sibyte/bcm1480/smp.c > index d667875..63d2211 100644 > --- a/arch/mips/sibyte/bcm1480/smp.c > +++ b/arch/mips/sibyte/bcm1480/smp.c > @@ -147,14 +147,13 @@ static void __init bcm1480_smp_setup(void) > { > int i, num; > > - cpus_clear(cpu_possible_map); > - cpu_set(0, cpu_possible_map); > + init_cpu_possible(cpumask_of(0)); > __cpu_number_map[0] = 0; > __cpu_logical_map[0] = 0; > > for (i = 1, num = 0; i< NR_CPUS; i++) { > if (cfe_cpu_stop(i) == 0) { > - cpu_set(i, cpu_possible_map); > + set_cpu_possible(i, true); > __cpu_number_map[i] = ++num; > __cpu_logical_map[num] = i; > } > diff --git a/arch/mips/sibyte/sb1250/smp.c b/arch/mips/sibyte/sb1250/smp.c > index 38e7f6b..77f0df5 100644 > --- a/arch/mips/sibyte/sb1250/smp.c > +++ b/arch/mips/sibyte/sb1250/smp.c > @@ -135,14 +135,13 @@ static void __init sb1250_smp_setup(void) > { > int i, num; > > - cpus_clear(cpu_possible_map); > - cpu_set(0, cpu_possible_map); > + init_cpu_possible(cpumask_of(0)); > __cpu_number_map[0] = 0; > __cpu_logical_map[0] = 0; > > for (i = 1, num = 0; i< NR_CPUS; i++) { > if (cfe_cpu_stop(i) == 0) { > - cpu_set(i, cpu_possible_map); > + set_cpu_possible(i, true); > __cpu_number_map[i] = ++num; > __cpu_logical_map[num] = i; > } ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 3/3] um: Avoid raw handling of cpu_online_map 2012-02-14 22:49 ` [PATCH 0/3] Cleanup raw handling of online/possible map Venkatesh Pallipadi 2012-02-14 22:49 ` [PATCH 1/3] hexagon: Avoid raw handling of cpu_possible_map Venkatesh Pallipadi 2012-02-14 22:49 ` [PATCH 2/3] mips: Avoid raw handling of cpu_possible_map/cpu_online_map Venkatesh Pallipadi @ 2012-02-14 22:49 ` Venkatesh Pallipadi 2 siblings, 0 replies; 5+ messages in thread From: Venkatesh Pallipadi @ 2012-02-14 22:49 UTC (permalink / raw) To: Rusty Russell Cc: Tony Luck, Srivatsa S. Bhat, Andrew Morton, KOSAKI Motohiro, KOSAKI Motohiro, Mike Travis, Paul E. McKenney, Rafael J. Wysocki, Paul Gortmaker, linux-kernel, Richard Kuo, linux-hexagon, Ralf Baechle, linux-mips, Jeff Dike, Richard Weinberger, user-mode-linux-devel, Venkatesh Pallipadi Use init_cpu_online and set_cpu_online instead. Signed-off-by: Venkatesh Pallipadi <venki@google.com> --- arch/um/kernel/skas/process.c | 2 +- arch/um/kernel/smp.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/arch/um/kernel/skas/process.c b/arch/um/kernel/skas/process.c index 2e9852c..5daa0f5 100644 --- a/arch/um/kernel/skas/process.c +++ b/arch/um/kernel/skas/process.c @@ -41,7 +41,7 @@ static int __init start_kernel_proc(void *unused) cpu_tasks[0].pid = pid; cpu_tasks[0].task = current; #ifdef CONFIG_SMP - cpu_online_map = cpumask_of_cpu(0); + init_cpu_online(cpumask_of(0)); #endif start_kernel(); return 0; diff --git a/arch/um/kernel/smp.c b/arch/um/kernel/smp.c index 155206a..b5d2ca9 100644 --- a/arch/um/kernel/smp.c +++ b/arch/um/kernel/smp.c @@ -76,7 +76,7 @@ static int idle_proc(void *cpup) cpu_relax(); notify_cpu_starting(cpu); - cpu_set(cpu, cpu_online_map); + set_cpu_online(cpu, true); default_idle(); return 0; } @@ -110,8 +110,8 @@ void smp_prepare_cpus(unsigned int maxcpus) for (i = 0; i < ncpus; ++i) set_cpu_possible(i, true); - cpu_clear(me, cpu_online_map); - cpu_set(me, cpu_online_map); + set_cpu_online(me, false); + set_cpu_online(me, true); cpu_set(me, cpu_callin_map); err = os_pipe(cpu_data[me].ipi_pipe, 1, 1); @@ -138,7 +138,7 @@ void smp_prepare_cpus(unsigned int maxcpus) void smp_prepare_boot_cpu(void) { - cpu_set(smp_processor_id(), cpu_online_map); + set_cpu_online(smp_processor_id(), true); } int __cpu_up(unsigned int cpu) -- 1.7.7.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-02-27 22:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <87wr7pbwbz.fsf@rustcorp.com.au>
2012-02-14 22:49 ` [PATCH 0/3] Cleanup raw handling of online/possible map Venkatesh Pallipadi
2012-02-14 22:49 ` [PATCH 1/3] hexagon: Avoid raw handling of cpu_possible_map Venkatesh Pallipadi
2012-02-14 22:49 ` [PATCH 2/3] mips: Avoid raw handling of cpu_possible_map/cpu_online_map Venkatesh Pallipadi
2012-02-27 22:19 ` David Daney
2012-02-14 22:49 ` [PATCH 3/3] um: Avoid raw handling of cpu_online_map Venkatesh Pallipadi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox