* [PATCH 5/7] USB: r8a66597-hcd: restore big-endian operation. [not found] <1331311133-26937-1-git-send-email-thomas@codesourcery.com> @ 2012-03-09 16:38 ` Thomas Schwinge 2012-03-09 16:38 ` Thomas Schwinge 2012-03-10 11:02 ` Sergei Shtylyov 0 siblings, 2 replies; 4+ messages in thread From: Thomas Schwinge @ 2012-03-09 16:38 UTC (permalink / raw) Cc: Thomas Schwinge, Paul Mundt, linux-sh, linux-usb, linux-arm-kernel, linux-mips On SH, as of 37b7a97884ba64bf7d403351ac2a9476ab4f1bba we have to use the endianess-agnostic I/O accessor functions. This driver is also enabled in ARM's viper_defconfig as well as MIPS' bcm47xx_defconfig and fuloong2e_defconfig -- I suppose none of these are operating in big-endian mode, or this issue should already have been noticed before. The device is now recognized correctly for both litte-endian and big-endian sh7785lcr, but I have not tested this any further, as the board is situated in a remote data center. Signed-off-by: Thomas Schwinge <thomas@codesourcery.com> Cc: Paul Mundt <lethal@linux-sh.org> Cc: linux-sh@vger.kernel.org Cc: linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mips@linux-mips.org --- drivers/usb/host/r8a66597.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/r8a66597.h b/drivers/usb/host/r8a66597.h index f28782d..c2ea6d1 100644 --- a/drivers/usb/host/r8a66597.h +++ b/drivers/usb/host/r8a66597.h @@ -170,7 +170,7 @@ static inline struct urb *r8a66597_get_urb(struct r8a66597 *r8a66597, static inline u16 r8a66597_read(struct r8a66597 *r8a66597, unsigned long offset) { - return ioread16(r8a66597->reg + offset); + return __raw_readw(r8a66597->reg + offset); } static inline void r8a66597_read_fifo(struct r8a66597 *r8a66597, @@ -198,7 +198,7 @@ static inline void r8a66597_read_fifo(struct r8a66597 *r8a66597, static inline void r8a66597_write(struct r8a66597 *r8a66597, u16 val, unsigned long offset) { - iowrite16(val, r8a66597->reg + offset); + __raw_writew(val, r8a66597->reg + offset); } static inline void r8a66597_mdfy(struct r8a66597 *r8a66597, -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 5/7] USB: r8a66597-hcd: restore big-endian operation. 2012-03-09 16:38 ` [PATCH 5/7] USB: r8a66597-hcd: restore big-endian operation Thomas Schwinge @ 2012-03-09 16:38 ` Thomas Schwinge 2012-03-10 11:02 ` Sergei Shtylyov 1 sibling, 0 replies; 4+ messages in thread From: Thomas Schwinge @ 2012-03-09 16:38 UTC (permalink / raw) Cc: Thomas Schwinge, Paul Mundt, linux-sh, linux-usb, linux-arm-kernel, linux-mips On SH, as of 37b7a97884ba64bf7d403351ac2a9476ab4f1bba we have to use the endianess-agnostic I/O accessor functions. This driver is also enabled in ARM's viper_defconfig as well as MIPS' bcm47xx_defconfig and fuloong2e_defconfig -- I suppose none of these are operating in big-endian mode, or this issue should already have been noticed before. The device is now recognized correctly for both litte-endian and big-endian sh7785lcr, but I have not tested this any further, as the board is situated in a remote data center. Signed-off-by: Thomas Schwinge <thomas@codesourcery.com> Cc: Paul Mundt <lethal@linux-sh.org> Cc: linux-sh@vger.kernel.org Cc: linux-usb@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-mips@linux-mips.org --- drivers/usb/host/r8a66597.h | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/r8a66597.h b/drivers/usb/host/r8a66597.h index f28782d..c2ea6d1 100644 --- a/drivers/usb/host/r8a66597.h +++ b/drivers/usb/host/r8a66597.h @@ -170,7 +170,7 @@ static inline struct urb *r8a66597_get_urb(struct r8a66597 *r8a66597, static inline u16 r8a66597_read(struct r8a66597 *r8a66597, unsigned long offset) { - return ioread16(r8a66597->reg + offset); + return __raw_readw(r8a66597->reg + offset); } static inline void r8a66597_read_fifo(struct r8a66597 *r8a66597, @@ -198,7 +198,7 @@ static inline void r8a66597_read_fifo(struct r8a66597 *r8a66597, static inline void r8a66597_write(struct r8a66597 *r8a66597, u16 val, unsigned long offset) { - iowrite16(val, r8a66597->reg + offset); + __raw_writew(val, r8a66597->reg + offset); } static inline void r8a66597_mdfy(struct r8a66597 *r8a66597, -- 1.7.4.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 5/7] USB: r8a66597-hcd: restore big-endian operation. 2012-03-09 16:38 ` [PATCH 5/7] USB: r8a66597-hcd: restore big-endian operation Thomas Schwinge 2012-03-09 16:38 ` Thomas Schwinge @ 2012-03-10 11:02 ` Sergei Shtylyov 2012-03-10 11:02 ` Sergei Shtylyov 1 sibling, 1 reply; 4+ messages in thread From: Sergei Shtylyov @ 2012-03-10 11:02 UTC (permalink / raw) To: Thomas Schwinge Hello. On 09-03-2012 20:38, Thomas Schwinge wrote: > On SH, as of 37b7a97884ba64bf7d403351ac2a9476ab4f1bba we have to use the Please also specify the summary of thta commit in parens. > endianess-agnostic I/O accessor functions. > This driver is also enabled in ARM's viper_defconfig as well as MIPS' > bcm47xx_defconfig and fuloong2e_defconfig -- I suppose none of these are > operating in big-endian mode, or this issue should already have been noticed > before. > The device is now recognized correctly for both litte-endian and big-endian > sh7785lcr, but I have not tested this any further, as the board is situated in > a remote data center. > Signed-off-by: Thomas Schwinge<thomas@codesourcery.com> > Cc: Paul Mundt<lethal@linux-sh.org> > Cc: linux-sh@vger.kernel.org > Cc: linux-usb@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mips@linux-mips.org WBR, Sergei ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 5/7] USB: r8a66597-hcd: restore big-endian operation. 2012-03-10 11:02 ` Sergei Shtylyov @ 2012-03-10 11:02 ` Sergei Shtylyov 0 siblings, 0 replies; 4+ messages in thread From: Sergei Shtylyov @ 2012-03-10 11:02 UTC (permalink / raw) To: Thomas Schwinge Cc: Paul Mundt, linux-sh, linux-usb, linux-arm-kernel, linux-mips Hello. On 09-03-2012 20:38, Thomas Schwinge wrote: > On SH, as of 37b7a97884ba64bf7d403351ac2a9476ab4f1bba we have to use the Please also specify the summary of thta commit in parens. > endianess-agnostic I/O accessor functions. > This driver is also enabled in ARM's viper_defconfig as well as MIPS' > bcm47xx_defconfig and fuloong2e_defconfig -- I suppose none of these are > operating in big-endian mode, or this issue should already have been noticed > before. > The device is now recognized correctly for both litte-endian and big-endian > sh7785lcr, but I have not tested this any further, as the board is situated in > a remote data center. > Signed-off-by: Thomas Schwinge<thomas@codesourcery.com> > Cc: Paul Mundt<lethal@linux-sh.org> > Cc: linux-sh@vger.kernel.org > Cc: linux-usb@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-mips@linux-mips.org WBR, Sergei ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-03-10 11:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1331311133-26937-1-git-send-email-thomas@codesourcery.com>
2012-03-09 16:38 ` [PATCH 5/7] USB: r8a66597-hcd: restore big-endian operation Thomas Schwinge
2012-03-09 16:38 ` Thomas Schwinge
2012-03-10 11:02 ` Sergei Shtylyov
2012-03-10 11:02 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox