From: Leonid Yegoshin <yegoshin@mips.com>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: "Steven J. Hill" <sjhill@mips.com>, <linux-mips@linux-mips.org>,
<ralf@linux-mips.org>
Subject: Re: [PATCH] Revert "MIPS: cache: Provide cache flush operations for XFS"
Date: Tue, 10 Apr 2012 11:03:35 -0700 [thread overview]
Message-ID: <4F8475F7.9060809@mips.com> (raw)
In-Reply-To: <CAJiQ=7AjtSB8KQ9+edUOvW+70nAWzh6c8B26ehnEpuud6QeMJA@mail.gmail.com>
On 04/09/2012 07:44 PM, Kevin Cernekee wrote:
> On Mon,Is there a reason why Ralf's original approach was not workable?
It doesn't work with HIGHMEM + cache aliasing. It also uses cache flush
(blast_dcache) to buffer instead of cache invalidate after read I/O is
completed.
> I suspect that reimplementing the *_kernel_vmap_range functions using
> _dma_cache_* would result in a double L2 flush on the same memory
> regions on systems with cache aliases, and an unnecessary L1+L2 flush
> on systems without aliases.
Good point. I put that to set it working. Now, after your comment, I
think it has sense to try with L1 only.
- Leonid.
WARNING: multiple messages have this Message-ID (diff)
From: Leonid Yegoshin <yegoshin@mips.com>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: "Steven J. Hill" <sjhill@mips.com>,
linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH] Revert "MIPS: cache: Provide cache flush operations for XFS"
Date: Tue, 10 Apr 2012 11:03:35 -0700 [thread overview]
Message-ID: <4F8475F7.9060809@mips.com> (raw)
Message-ID: <20120410180335.rIlSdI460FSKcZPTXfzEOPXQNFeto0W3r2tHIw3SSuE@z> (raw)
In-Reply-To: <CAJiQ=7AjtSB8KQ9+edUOvW+70nAWzh6c8B26ehnEpuud6QeMJA@mail.gmail.com>
On 04/09/2012 07:44 PM, Kevin Cernekee wrote:
> On Mon,Is there a reason why Ralf's original approach was not workable?
It doesn't work with HIGHMEM + cache aliasing. It also uses cache flush
(blast_dcache) to buffer instead of cache invalidate after read I/O is
completed.
> I suspect that reimplementing the *_kernel_vmap_range functions using
> _dma_cache_* would result in a double L2 flush on the same memory
> regions on systems with cache aliases, and an unnecessary L1+L2 flush
> on systems without aliases.
Good point. I put that to set it working. Now, after your comment, I
think it has sense to try with L1 only.
- Leonid.
next prev parent reply other threads:[~2012-04-10 18:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-09 16:13 [PATCH] Revert "MIPS: cache: Provide cache flush operations for XFS" Steven J. Hill
2012-04-10 2:44 ` Kevin Cernekee
2012-04-10 18:03 ` Leonid Yegoshin [this message]
2012-04-10 18:03 ` Leonid Yegoshin
2012-05-07 19:21 ` Hill, Steven
2012-05-07 19:28 ` Leonid Yegoshin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8475F7.9060809@mips.com \
--to=yegoshin@mips.com \
--cc=cernekee@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sjhill@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox