From: David Daney <david.daney@cavium.com>
To: "Maciej W. Rozycki" <macro@linux-mips.org>
Cc: "Steven J. Hill" <sjhill@mips.com>,
linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH 04/10] MIPS: Add micro-assembler support for 'ins' and 'ext' instructions.
Date: Mon, 30 Apr 2012 17:51:19 -0700 [thread overview]
Message-ID: <4F9F3387.1050500@cavium.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1204300459120.19691@eddie.linux-mips.org>
On 04/30/2012 05:26 PM, Maciej W. Rozycki wrote:
> On Sat, 7 Apr 2012, Steven J. Hill wrote:
>
>> diff --git a/arch/mips/mm/uasm.c b/arch/mips/mm/uasm.c
>> index 5fa1851..fb6d8e27 100644
>> --- a/arch/mips/mm/uasm.c
>> +++ b/arch/mips/mm/uasm.c
>> @@ -63,6 +63,7 @@ enum opcode {
>> insn_bne, insn_cache, insn_daddu, insn_daddiu, insn_dmfc0,
>> insn_dmtc0, insn_dsll, insn_dsll32, insn_dsra, insn_dsrl,
>> insn_dsrl32, insn_drotr, insn_drotr32, insn_dsubu, insn_eret,
>> + insn_ins, insn_ext,
>> insn_j, insn_jal, insn_jr, insn_ld, insn_ll, insn_lld,
>> insn_lui, insn_lw, insn_mfc0, insn_mtc0, insn_or, insn_ori,
>> insn_pref, insn_rfe, insn_sc, insn_scd, insn_sd, insn_sll,
>> @@ -113,6 +114,8 @@ static struct insn insn_table[] __uasminitdata = {
>> { insn_drotr32, M(spec_op, 1, 0, 0, 0, dsrl32_op), RT | RD | RE },
>> { insn_dsubu, M(spec_op, 0, 0, 0, 0, dsubu_op), RS | RT | RD },
>> { insn_eret, M(cop0_op, cop_op, 0, 0, 0, eret_op), 0 },
>> + { insn_ins, M(spec3_op, 0, 0, 0, 0, ins_op), RS | RT | RD | RE },
>> + { insn_ext, M(spec3_op, 0, 0, 0, 0, ext_op), RS | RT | RD | RE },
>> { insn_j, M(j_op, 0, 0, 0, 0, 0), JIMM },
>> { insn_jal, M(jal_op, 0, 0, 0, 0, 0), JIMM },
>> { insn_jr, M(spec_op, 0, 0, 0, 0, jr_op), RS },
>
> Not an extensive review -- just noticed this issue while browsing...
>
> These two data definitions are clearly alphabetically ordered, so please
> keep them as such. It seems rather a trivial update in this case -- just
> swap the new entries. Thanks.
Well I broke the ordering with a bunch of my patches lower down.
Perhaps we should fix it so it goes back to being ordered.
David Daney
next prev parent reply other threads:[~2012-05-01 0:51 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-07 16:48 [PATCH 00/10] Add support MIPS SEAD-3 Development Platform Steven J. Hill
2012-04-07 16:48 ` [PATCH 01/10] MIPS: Add core files for MIPS SEAD-3 development platform Steven J. Hill
2012-04-10 1:03 ` Shinya Kuribayashi
2012-05-07 20:16 ` Hill, Steven
2012-05-08 4:01 ` Shinya Kuribayashi
2012-05-08 11:16 ` Maciej W. Rozycki
2012-05-08 20:38 ` Hill, Steven
2012-05-11 7:37 ` Maciej W. Rozycki
2012-04-07 16:48 ` [PATCH 02/10] MIPS: Changes to configuration files for SEAD-3 platform Steven J. Hill
2012-04-10 1:19 ` Shinya Kuribayashi
2012-04-07 16:48 ` [PATCH 03/10] MIPS: Add support for the M14K core Steven J. Hill
2012-04-07 16:48 ` [PATCH 04/10] MIPS: Add micro-assembler support for 'ins' and 'ext' instructions Steven J. Hill
2012-05-01 0:26 ` Maciej W. Rozycki
2012-05-01 0:51 ` David Daney [this message]
2012-05-07 5:18 ` Maciej W. Rozycki
2012-05-07 13:33 ` Hill, Steven
2012-05-01 0:49 ` David Daney
2012-04-07 16:48 ` [PATCH 05/10] MIPS: GIC interrupt changes for M14K and SEAD-3 support Steven J. Hill
2012-04-07 16:48 ` [PATCH 06/10] MIPS: Code formatting fixes Steven J. Hill
2012-04-07 16:48 ` [PATCH 07/10] MIPS: Add support for early serial debug and LCD device on SEAD-3 Steven J. Hill
2012-04-07 16:48 ` [PATCH 08/10] MIPS: MIPS32R2 optimisations for pipeline stalls and code size Steven J. Hill
2012-04-07 16:48 ` [PATCH 09/10] cobalt_lcdfb: LCD panel framebuffer support for SEAD-3 platform Steven J. Hill
2012-04-07 16:48 ` [PATCH 10/10] usb: host: mips: sead3: USB Host controller " Steven J. Hill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9F3387.1050500@cavium.com \
--to=david.daney@cavium.com \
--cc=linux-mips@linux-mips.org \
--cc=macro@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sjhill@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox