* [PATCH] usb: host: mips: sead3: Update for EHCI register structure.
@ 2012-08-06 22:29 Steven J. Hill
2012-08-07 10:04 ` Sergei Shtylyov
2012-08-07 17:21 ` Alan Stern
0 siblings, 2 replies; 4+ messages in thread
From: Steven J. Hill @ 2012-08-06 22:29 UTC (permalink / raw)
To: Alan Stern; +Cc: Steven J. Hill, linux-usb, linux-mips
From: "Steven J. Hill" <sjhill@mips.com>
One line fix after 'struct ehci_regs' definition was changed
in commit a46af4ebf9ffec35eea0390e89935197b833dc61.
Signed-off-by: Steven J. Hill <sjhill@mips.com>
---
drivers/usb/host/ehci-sead3.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/host/ehci-sead3.c b/drivers/usb/host/ehci-sead3.c
index 58c96bd..0c9e43c 100644
--- a/drivers/usb/host/ehci-sead3.c
+++ b/drivers/usb/host/ehci-sead3.c
@@ -40,7 +40,7 @@ static int ehci_sead3_setup(struct usb_hcd *hcd)
ehci->need_io_watchdog = 0;
/* Set burst length to 16 words. */
- ehci_writel(ehci, 0x1010, &ehci->regs->reserved[1]);
+ ehci_writel(ehci, 0x1010, &ehci->regs->reserved1[1]);
return ret;
}
--
1.7.11.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: host: mips: sead3: Update for EHCI register structure.
2012-08-06 22:29 [PATCH] usb: host: mips: sead3: Update for EHCI register structure Steven J. Hill
@ 2012-08-07 10:04 ` Sergei Shtylyov
2012-08-07 17:21 ` Alan Stern
1 sibling, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2012-08-07 10:04 UTC (permalink / raw)
To: Steven J. Hill; +Cc: Alan Stern, linux-usb, linux-mips
Hello.
On 07.08.2012 2:29, Steven J. Hill wrote:
> From: "Steven J. Hill" <sjhill@mips.com>
> One line fix after 'struct ehci_regs' definition was changed
> in commit a46af4ebf9ffec35eea0390e89935197b833dc61.
Please also specify that commit's summary in parens.
> Signed-off-by: Steven J. Hill <sjhill@mips.com>
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] usb: host: mips: sead3: Update for EHCI register structure.
2012-08-06 22:29 [PATCH] usb: host: mips: sead3: Update for EHCI register structure Steven J. Hill
2012-08-07 10:04 ` Sergei Shtylyov
@ 2012-08-07 17:21 ` Alan Stern
2012-08-07 17:21 ` Alan Stern
1 sibling, 1 reply; 4+ messages in thread
From: Alan Stern @ 2012-08-07 17:21 UTC (permalink / raw)
To: Steven J. Hill; +Cc: linux-usb, linux-mips
On Mon, 6 Aug 2012, Steven J. Hill wrote:
> From: "Steven J. Hill" <sjhill@mips.com>
>
> One line fix after 'struct ehci_regs' definition was changed
> in commit a46af4ebf9ffec35eea0390e89935197b833dc61.
>
> Signed-off-by: Steven J. Hill <sjhill@mips.com>
> ---
> drivers/usb/host/ehci-sead3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-sead3.c b/drivers/usb/host/ehci-sead3.c
> index 58c96bd..0c9e43c 100644
> --- a/drivers/usb/host/ehci-sead3.c
> +++ b/drivers/usb/host/ehci-sead3.c
> @@ -40,7 +40,7 @@ static int ehci_sead3_setup(struct usb_hcd *hcd)
> ehci->need_io_watchdog = 0;
>
> /* Set burst length to 16 words. */
> - ehci_writel(ehci, 0x1010, &ehci->regs->reserved[1]);
> + ehci_writel(ehci, 0x1010, &ehci->regs->reserved1[1]);
>
> return ret;
> }
Acked-by: Alan Stern <stern@rowland.harvard.edu>
I never thought to check if any of the platform drivers were actually
using these reserved memory addresses.
Alan Stern
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: host: mips: sead3: Update for EHCI register structure.
2012-08-07 17:21 ` Alan Stern
@ 2012-08-07 17:21 ` Alan Stern
0 siblings, 0 replies; 4+ messages in thread
From: Alan Stern @ 2012-08-07 17:21 UTC (permalink / raw)
To: Steven J. Hill; +Cc: linux-usb, linux-mips
On Mon, 6 Aug 2012, Steven J. Hill wrote:
> From: "Steven J. Hill" <sjhill@mips.com>
>
> One line fix after 'struct ehci_regs' definition was changed
> in commit a46af4ebf9ffec35eea0390e89935197b833dc61.
>
> Signed-off-by: Steven J. Hill <sjhill@mips.com>
> ---
> drivers/usb/host/ehci-sead3.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/ehci-sead3.c b/drivers/usb/host/ehci-sead3.c
> index 58c96bd..0c9e43c 100644
> --- a/drivers/usb/host/ehci-sead3.c
> +++ b/drivers/usb/host/ehci-sead3.c
> @@ -40,7 +40,7 @@ static int ehci_sead3_setup(struct usb_hcd *hcd)
> ehci->need_io_watchdog = 0;
>
> /* Set burst length to 16 words. */
> - ehci_writel(ehci, 0x1010, &ehci->regs->reserved[1]);
> + ehci_writel(ehci, 0x1010, &ehci->regs->reserved1[1]);
>
> return ret;
> }
Acked-by: Alan Stern <stern@rowland.harvard.edu>
I never thought to check if any of the platform drivers were actually
using these reserved memory addresses.
Alan Stern
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-08-07 17:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-06 22:29 [PATCH] usb: host: mips: sead3: Update for EHCI register structure Steven J. Hill
2012-08-07 10:04 ` Sergei Shtylyov
2012-08-07 17:21 ` Alan Stern
2012-08-07 17:21 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox