* [PATCH v3 13/32] PCI/MIPS: use PCIe capabilities access functions to simplify implementation [not found] <1343836477-7287-1-git-send-email-jiang.liu@huawei.com> @ 2012-08-01 15:54 ` Jiang Liu 2012-08-13 21:40 ` David Daney 0 siblings, 1 reply; 2+ messages in thread From: Jiang Liu @ 2012-08-01 15:54 UTC (permalink / raw) To: Bjorn Helgaas, Don Dutile, Ralf Baechle Cc: Jiang Liu, Yinghai Lu, Taku Izumi, Rafael J . Wysocki, Kenji Kaneshige, Yijing Wang, linux-kernel, linux-mips, linux-pci, Jiang Liu From: Jiang Liu <jiang.liu@huawei.com> Use PCIe capabilities access functions to simplify PCIe MIPS implementation. Signed-off-by: Jiang Liu <liuj97@gmail.com> --- arch/mips/pci/pci-octeon.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/arch/mips/pci/pci-octeon.c b/arch/mips/pci/pci-octeon.c index 52a1ba7..aaed2ad 100644 --- a/arch/mips/pci/pci-octeon.c +++ b/arch/mips/pci/pci-octeon.c @@ -117,16 +117,11 @@ int pcibios_plat_dev_init(struct pci_dev *dev) } /* Enable the PCIe normal error reporting */ - pos = pci_find_capability(dev, PCI_CAP_ID_EXP); - if (pos) { - /* Update Device Control */ - pci_read_config_word(dev, pos + PCI_EXP_DEVCTL, &config); - config |= PCI_EXP_DEVCTL_CERE; /* Correctable Error Reporting */ - config |= PCI_EXP_DEVCTL_NFERE; /* Non-Fatal Error Reporting */ - config |= PCI_EXP_DEVCTL_FERE; /* Fatal Error Reporting */ - config |= PCI_EXP_DEVCTL_URRE; /* Unsupported Request */ - pci_write_config_word(dev, pos + PCI_EXP_DEVCTL, config); - } + config = PCI_EXP_DEVCTL_CERE; /* Correctable Error Reporting */ + config |= PCI_EXP_DEVCTL_NFERE; /* Non-Fatal Error Reporting */ + config |= PCI_EXP_DEVCTL_FERE; /* Fatal Error Reporting */ + config |= PCI_EXP_DEVCTL_URRE; /* Unsupported Request */ + pci_pcie_capability_change_word(dev, PCI_EXP_DEVCTL, config, 0); /* Find the Advanced Error Reporting capability */ pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ERR); -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 13/32] PCI/MIPS: use PCIe capabilities access functions to simplify implementation 2012-08-01 15:54 ` [PATCH v3 13/32] PCI/MIPS: use PCIe capabilities access functions to simplify implementation Jiang Liu @ 2012-08-13 21:40 ` David Daney 0 siblings, 0 replies; 2+ messages in thread From: David Daney @ 2012-08-13 21:40 UTC (permalink / raw) To: Jiang Liu, Ralf Baechle Cc: Bjorn Helgaas, Don Dutile, Jiang Liu, Yinghai Lu, Taku Izumi, Rafael J . Wysocki, Kenji Kaneshige, Yijing Wang, linux-kernel, linux-mips, linux-pci On 08/01/2012 08:54 AM, Jiang Liu wrote: > From: Jiang Liu<jiang.liu@huawei.com> > > Use PCIe capabilities access functions to simplify PCIe MIPS implementation. > > Signed-off-by: Jiang Liu<liuj97@gmail.com> Acked-by: David Daney <david.daney@cavium.com> > --- > arch/mips/pci/pci-octeon.c | 15 +++++---------- > 1 file changed, 5 insertions(+), 10 deletions(-) > > diff --git a/arch/mips/pci/pci-octeon.c b/arch/mips/pci/pci-octeon.c > index 52a1ba7..aaed2ad 100644 > --- a/arch/mips/pci/pci-octeon.c > +++ b/arch/mips/pci/pci-octeon.c > @@ -117,16 +117,11 @@ int pcibios_plat_dev_init(struct pci_dev *dev) > } > > /* Enable the PCIe normal error reporting */ > - pos = pci_find_capability(dev, PCI_CAP_ID_EXP); > - if (pos) { > - /* Update Device Control */ > - pci_read_config_word(dev, pos + PCI_EXP_DEVCTL,&config); > - config |= PCI_EXP_DEVCTL_CERE; /* Correctable Error Reporting */ > - config |= PCI_EXP_DEVCTL_NFERE; /* Non-Fatal Error Reporting */ > - config |= PCI_EXP_DEVCTL_FERE; /* Fatal Error Reporting */ > - config |= PCI_EXP_DEVCTL_URRE; /* Unsupported Request */ > - pci_write_config_word(dev, pos + PCI_EXP_DEVCTL, config); > - } > + config = PCI_EXP_DEVCTL_CERE; /* Correctable Error Reporting */ > + config |= PCI_EXP_DEVCTL_NFERE; /* Non-Fatal Error Reporting */ > + config |= PCI_EXP_DEVCTL_FERE; /* Fatal Error Reporting */ > + config |= PCI_EXP_DEVCTL_URRE; /* Unsupported Request */ > + pci_pcie_capability_change_word(dev, PCI_EXP_DEVCTL, config, 0); > > /* Find the Advanced Error Reporting capability */ > pos = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ERR); ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-08-13 21:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1343836477-7287-1-git-send-email-jiang.liu@huawei.com>
2012-08-01 15:54 ` [PATCH v3 13/32] PCI/MIPS: use PCIe capabilities access functions to simplify implementation Jiang Liu
2012-08-13 21:40 ` David Daney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox