From: John Crispin <john@phrozen.org>
To: linux-mips@linux-mips.org
Subject: Re: [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs.
Date: Tue, 21 Aug 2012 20:40:36 +0200 [thread overview]
Message-ID: <5033D624.30704@phrozen.org> (raw)
In-Reply-To: <5033D62D.9070508@gmail.com>
On 21/08/12 20:40, David Daney wrote:
> On 08/21/2012 11:35 AM, John Crispin wrote:
>> On 21/08/12 20:33, David Daney wrote:
>>> On 08/21/2012 11:23 AM, John Crispin wrote:
>>>> On 11/05/12 23:34, David Daney wrote:
>>>>> From: David Daney <david.daney@cavium.com>
>>>>>
>>>>> Add the driver, link it into the kbuild system and provide device tree
>>>>> binding documentation.
>>>>>
>>>>> Signed-off-by: David Daney <david.daney@cavium.com>
>>>>
>>>> Thanks, queued for 3.7.
>>>>
>>>
>>> This cannot go in like this.
>>>
>>> There were a bunch of requests by other maintainers that were never
>>> done. Also since it is in a foreign subsystem, it at a minimum needs
>>> some additional Acked-bys
>>
>> hmmm ... you are right about the Acked-by ... i forgot to merge add it
>> ...
>>
>> i did ask you about this on IRC and you said the driver was ok to be
>> merged like this. inside the thread linus wllej at some point says that
>> his comment was bogus if i am not mistaken ?
>
> OK, I think I won't answer this type of question on IRC in the future. I
> really should have looked at it in more detail. But at the end of the
> day, I need to fix it up before it can go in.
>
> David Daney
i agree, i just removed it from the queue ...
next prev parent reply other threads:[~2012-08-21 18:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-11 21:34 [PATCH 0/2] MIPS/spi: New driver for SPI master controller for OCTEON SOCs David Daney
2012-05-11 21:34 ` [PATCH 1/2] MIPS: OCTEON: Add register definitions for SPI host hardware David Daney
2012-05-14 20:02 ` Linus Walleij
2012-05-20 5:23 ` Grant Likely
2012-08-21 18:23 ` John Crispin
2012-05-11 21:34 ` [PATCH 2/2] spi: Add SPI master controller for OCTEON SOCs David Daney
2012-05-14 5:46 ` Shubhrajyoti Datta
2012-05-14 18:13 ` David Daney
2012-05-20 5:26 ` Grant Likely
2012-05-20 5:26 ` Grant Likely
2012-05-14 20:07 ` Linus Walleij
2012-05-20 5:46 ` Grant Likely
2012-08-21 19:30 ` David Daney
2012-08-21 18:23 ` John Crispin
2012-08-21 18:33 ` David Daney
2012-08-21 18:35 ` John Crispin
2012-08-21 18:40 ` David Daney
2012-08-21 18:40 ` John Crispin [this message]
2012-08-21 19:49 ` [2/2] " Guenter Roeck
2012-08-21 20:38 ` David Daney
2012-08-21 20:38 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5033D624.30704@phrozen.org \
--to=john@phrozen.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox