[PATCH] MIPS: PNX8550: Fix build failures

[PATCH] MIPS: PNX8550: Fix build failures

[Thierry Reding]

The OHCI support code fails to build because the PCI_BASE and udelay()
macros which are defined in pci.h and linux/time.h respectively. Adding
corresponding includes fixes these build failures.

Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
 arch/mips/pnx8550/common/platform.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/mips/pnx8550/common/platform.c b/arch/mips/pnx8550/common/platform.c
index 0a8faea..9782fde 100644
--- a/arch/mips/pnx8550/common/platform.c
+++ b/arch/mips/pnx8550/common/platform.c
@@ -19,10 +19,12 @@
 #include <linux/resource.h>
 #include <linux/serial.h>
 #include <linux/serial_pnx8xxx.h>
+#include <linux/delay.h>
 #include <linux/platform_device.h>
 #include <linux/usb/ohci_pdriver.h>
 
 #include <int.h>
+#include <pci.h>
 #include <usb.h>
 #include <uart.h>
 
-- 
1.8.1

Re: [PATCH] MIPS: PNX8550: Fix build failures

[Florian Fainelli]

On 01/16/2013 08:07 AM, Thierry Reding wrote:
> The OHCI support code fails to build because the PCI_BASE and udelay()
> macros which are defined in pci.h and linux/time.h respectively. Adding
> corresponding includes fixes these build failures.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>

Thanks for fixing this Thierry, I completely missed that when moving the 
OHCI code to platform.c

Acked-by: Florian Fainelli <florian@openwrt.org>

> ---
>   arch/mips/pnx8550/common/platform.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/pnx8550/common/platform.c b/arch/mips/pnx8550/common/platform.c
> index 0a8faea..9782fde 100644
> --- a/arch/mips/pnx8550/common/platform.c
> +++ b/arch/mips/pnx8550/common/platform.c
> @@ -19,10 +19,12 @@
>   #include <linux/resource.h>
>   #include <linux/serial.h>
>   #include <linux/serial_pnx8xxx.h>
> +#include <linux/delay.h>
>   #include <linux/platform_device.h>
>   #include <linux/usb/ohci_pdriver.h>
>   
>   #include <int.h>
> +#include <pci.h>
>   #include <usb.h>
>   #include <uart.h>
>   

Re: [PATCH] MIPS: PNX8550: Fix build failures

[Geert Uytterhoeven]

On Wed, Jan 16, 2013 at 8:07 AM, Thierry Reding
<thierry.reding@avionic-design.de> wrote:
> The OHCI support code fails to build because the PCI_BASE and udelay()
> macros which are defined in pci.h and linux/time.h respectively. Adding

> +#include <linux/delay.h>

time.h or delay.h?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] MIPS: PNX8550: Fix build failures

[Thierry Reding]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

On Wed, Jan 16, 2013 at 10:51:47AM +0100, Geert Uytterhoeven wrote:
> On Wed, Jan 16, 2013 at 8:07 AM, Thierry Reding
> <thierry.reding@avionic-design.de> wrote:
> > The OHCI support code fails to build because the PCI_BASE and udelay()
> > macros which are defined in pci.h and linux/time.h respectively. Adding
> 
> > +#include <linux/delay.h>
> 
> time.h or delay.h?

That'd be delay.h. Can this be fixed up when the patch is committed or
shall I resend?

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]