Re: [PATCH] MIPS: bcm47xx: Fix BCMA build failure

[Hauke Mehrtens <hauke@hauke-m.de>]

On 01/16/2013 08:28 AM, Thierry Reding wrote:
> Enabling the BCMA driver automatically selects BCMA_DRIVER_GPIO, which
> in turn depends on GPIOLIB. GPIOLIB support is not enabled by default,
> however, so Kconfig complains about it:
> 
> 	warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO which has unmet direct dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
> 	warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO which has unmet direct dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
> 	warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO which has unmet direct dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
> 	warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO which has unmet direct dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
> 
> This patch fixes the issue by explicitly selecting GPIOLIB if
> BCM47XX_BCMA is enabled.
> 
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>

Arend van Spriel already send a similar patch fixing this issue, but it
was not applied yet:
https://patchwork.linux-mips.org/patch/4759/

CONFIG_GPIOLIB should also be selected by CONFIG_BCM47XX_SSB.

> ---
>  arch/mips/bcm47xx/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/bcm47xx/Kconfig b/arch/mips/bcm47xx/Kconfig
> index d7af29f..0f95b5e 100644
> --- a/arch/mips/bcm47xx/Kconfig
> +++ b/arch/mips/bcm47xx/Kconfig
> @@ -19,6 +19,7 @@ config BCM47XX_SSB
>  config BCM47XX_BCMA
>  	bool "BCMA Support for Broadcom BCM47XX"
>  	select SYS_HAS_CPU_MIPS32_R2
> +	select GPIOLIB
>  	select BCMA
>  	select BCMA_HOST_SOC
>  	select BCMA_DRIVER_MIPS
>