From: Thierry Reding <thierry.reding@avionic-design.de>
To: Hauke Mehrtens <hauke@hauke-m.de>
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org, Arend van Spriel <arend@broadcom.com>
Subject: Re: [PATCH] MIPS: bcm47xx: Fix BCMA build failure
Date: Wed, 16 Jan 2013 10:51:14 +0100 [thread overview]
Message-ID: <20130116095114.GC18848@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <50F67719.5010005@hauke-m.de>
[-- Attachment #1: Type: text/plain, Size: 1282 bytes --]
On Wed, Jan 16, 2013 at 10:47:05AM +0100, Hauke Mehrtens wrote:
> On 01/16/2013 08:28 AM, Thierry Reding wrote:
> > Enabling the BCMA driver automatically selects BCMA_DRIVER_GPIO, which
> > in turn depends on GPIOLIB. GPIOLIB support is not enabled by default,
> > however, so Kconfig complains about it:
> >
> > warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO which has unmet direct dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
> > warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO which has unmet direct dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
> > warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO which has unmet direct dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
> > warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO which has unmet direct dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
> >
> > This patch fixes the issue by explicitly selecting GPIOLIB if
> > BCM47XX_BCMA is enabled.
> >
> > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
>
> Arend van Spriel already send a similar patch fixing this issue, but it
> was not applied yet:
> https://patchwork.linux-mips.org/patch/4759/
>
> CONFIG_GPIOLIB should also be selected by CONFIG_BCM47XX_SSB.
Okay, great. I wasn't aware of it, sorry for the noise.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-01-16 9:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 7:28 [PATCH] MIPS: bcm47xx: Fix BCMA build failure Thierry Reding
2013-01-16 9:47 ` Hauke Mehrtens
2013-01-16 9:51 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130116095114.GC18848@avionic-0098.adnet.avionic-design.de \
--to=thierry.reding@avionic-design.de \
--cc=arend@broadcom.com \
--cc=hauke@hauke-m.de \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox