* [PATCH] MIPS: bcm47xx: Fix BCMA build failure
@ 2013-01-16 7:28 Thierry Reding
2013-01-16 9:47 ` Hauke Mehrtens
0 siblings, 1 reply; 3+ messages in thread
From: Thierry Reding @ 2013-01-16 7:28 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
Enabling the BCMA driver automatically selects BCMA_DRIVER_GPIO, which
in turn depends on GPIOLIB. GPIOLIB support is not enabled by default,
however, so Kconfig complains about it:
warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO which has unmet direct dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO which has unmet direct dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO which has unmet direct dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO which has unmet direct dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
This patch fixes the issue by explicitly selecting GPIOLIB if
BCM47XX_BCMA is enabled.
Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
---
arch/mips/bcm47xx/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/mips/bcm47xx/Kconfig b/arch/mips/bcm47xx/Kconfig
index d7af29f..0f95b5e 100644
--- a/arch/mips/bcm47xx/Kconfig
+++ b/arch/mips/bcm47xx/Kconfig
@@ -19,6 +19,7 @@ config BCM47XX_SSB
config BCM47XX_BCMA
bool "BCMA Support for Broadcom BCM47XX"
select SYS_HAS_CPU_MIPS32_R2
+ select GPIOLIB
select BCMA
select BCMA_HOST_SOC
select BCMA_DRIVER_MIPS
--
1.8.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: bcm47xx: Fix BCMA build failure
2013-01-16 7:28 [PATCH] MIPS: bcm47xx: Fix BCMA build failure Thierry Reding
@ 2013-01-16 9:47 ` Hauke Mehrtens
2013-01-16 9:51 ` Thierry Reding
0 siblings, 1 reply; 3+ messages in thread
From: Hauke Mehrtens @ 2013-01-16 9:47 UTC (permalink / raw)
To: Thierry Reding; +Cc: Ralf Baechle, linux-mips, Arend van Spriel
On 01/16/2013 08:28 AM, Thierry Reding wrote:
> Enabling the BCMA driver automatically selects BCMA_DRIVER_GPIO, which
> in turn depends on GPIOLIB. GPIOLIB support is not enabled by default,
> however, so Kconfig complains about it:
>
> warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO which has unmet direct dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
> warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO which has unmet direct dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
> warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO which has unmet direct dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
> warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO which has unmet direct dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
>
> This patch fixes the issue by explicitly selecting GPIOLIB if
> BCM47XX_BCMA is enabled.
>
> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
Arend van Spriel already send a similar patch fixing this issue, but it
was not applied yet:
https://patchwork.linux-mips.org/patch/4759/
CONFIG_GPIOLIB should also be selected by CONFIG_BCM47XX_SSB.
> ---
> arch/mips/bcm47xx/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/bcm47xx/Kconfig b/arch/mips/bcm47xx/Kconfig
> index d7af29f..0f95b5e 100644
> --- a/arch/mips/bcm47xx/Kconfig
> +++ b/arch/mips/bcm47xx/Kconfig
> @@ -19,6 +19,7 @@ config BCM47XX_SSB
> config BCM47XX_BCMA
> bool "BCMA Support for Broadcom BCM47XX"
> select SYS_HAS_CPU_MIPS32_R2
> + select GPIOLIB
> select BCMA
> select BCMA_HOST_SOC
> select BCMA_DRIVER_MIPS
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] MIPS: bcm47xx: Fix BCMA build failure
2013-01-16 9:47 ` Hauke Mehrtens
@ 2013-01-16 9:51 ` Thierry Reding
0 siblings, 0 replies; 3+ messages in thread
From: Thierry Reding @ 2013-01-16 9:51 UTC (permalink / raw)
To: Hauke Mehrtens; +Cc: Ralf Baechle, linux-mips, Arend van Spriel
[-- Attachment #1: Type: text/plain, Size: 1282 bytes --]
On Wed, Jan 16, 2013 at 10:47:05AM +0100, Hauke Mehrtens wrote:
> On 01/16/2013 08:28 AM, Thierry Reding wrote:
> > Enabling the BCMA driver automatically selects BCMA_DRIVER_GPIO, which
> > in turn depends on GPIOLIB. GPIOLIB support is not enabled by default,
> > however, so Kconfig complains about it:
> >
> > warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO which has unmet direct dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
> > warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO which has unmet direct dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
> > warning: (BCM47XX_SSB) selects SSB_DRIVER_GPIO which has unmet direct dependencies (SSB_POSSIBLE && SSB && GPIOLIB)
> > warning: (BCM47XX_BCMA) selects BCMA_DRIVER_GPIO which has unmet direct dependencies (BCMA_POSSIBLE && BCMA && GPIOLIB)
> >
> > This patch fixes the issue by explicitly selecting GPIOLIB if
> > BCM47XX_BCMA is enabled.
> >
> > Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
>
> Arend van Spriel already send a similar patch fixing this issue, but it
> was not applied yet:
> https://patchwork.linux-mips.org/patch/4759/
>
> CONFIG_GPIOLIB should also be selected by CONFIG_BCM47XX_SSB.
Okay, great. I wasn't aware of it, sorry for the noise.
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-01-16 9:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-16 7:28 [PATCH] MIPS: bcm47xx: Fix BCMA build failure Thierry Reding
2013-01-16 9:47 ` Hauke Mehrtens
2013-01-16 9:51 ` Thierry Reding
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox