From: Florian Fainelli <florian@openwrt.org>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH V3 10/10] MIPS: ralink: adds Kbuild files
Date: Thu, 31 Jan 2013 13:56:55 +0100 [thread overview]
Message-ID: <510A6A17.5050003@openwrt.org> (raw)
In-Reply-To: <1359633561-4980-11-git-send-email-blogic@openwrt.org>
Hello John,
On 01/31/2013 12:59 PM, John Crispin wrote:
[snip]
>
> config MIPS_L1_CACHE_SHIFT
> int
> - default "4" if MACH_DECSTATION || MIKROTIK_RB532 || PMC_MSP4200_EVAL
> + default "4" if MACH_DECSTATION || MIKROTIK_RB532 || PMC_MSP4200_EVAL || RALINK_RT288X
I got slightly confused here because this is actually ok, RALINK_RT288X
should have MIPS_L1_CACHE_SHIFT=4, but rt305x and rt3883 have
MIPS_L1_CACHE_SHIFT=5. So I would drop this hunk until you add support
for rt288x.
--
Florian
next prev parent reply other threads:[~2013-01-31 12:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 11:59 [PATCH V3 00/10] MIPS: ralink: adds support for ralink platform John Crispin
2013-01-31 11:59 ` [PATCH V3 01/10] MIPS: ralink: adds include files John Crispin
2013-01-31 13:35 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 02/10] MIPS: ralink: adds irq code John Crispin
2013-01-31 13:36 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 03/10] MIPS: ralink: adds reset code John Crispin
2013-01-31 13:36 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 04/10] MIPS: ralink: adds prom and cmdline code John Crispin
2013-01-31 13:36 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 05/10] MIPS: ralink: adds clkdev code John Crispin
2013-01-31 13:37 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 06/10] MIPS: ralink: adds OF code John Crispin
2013-01-31 13:37 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 07/10] MIPS: ralink: adds early_printk support John Crispin
2013-01-31 13:37 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 08/10] MIPS: ralink: adds support for RT305x SoC family John Crispin
2013-01-31 13:06 ` Florian Fainelli
2013-01-31 13:08 ` John Crispin
2013-01-31 13:38 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 09/10] MIPS: ralink: adds rt305x devicetree John Crispin
2013-01-31 12:59 ` Florian Fainelli
2013-01-31 13:13 ` John Crispin
2013-01-31 14:11 ` Gabor Juhos
2013-01-31 11:59 ` [PATCH V3 10/10] MIPS: ralink: adds Kbuild files John Crispin
2013-01-31 12:56 ` Florian Fainelli [this message]
2013-01-31 12:57 ` John Crispin
2013-01-31 13:39 ` Gabor Juhos
2013-02-01 11:40 ` [PATCH V3 00/10] MIPS: ralink: adds support for ralink platform Florian Fainelli
2013-02-01 11:47 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=510A6A17.5050003@openwrt.org \
--to=florian@openwrt.org \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox